[z3-five] FiveException in Zope 2 trunk?

[Philipp von Weitershausen]

Sidnei da Silva wrote:
> Alright, back to you Martijn. :) If you can spark some discussion on
> the zope-dev list I can eventually follow up and merge into trunk.
> Sounds reasonable?

+1 on bringing FiveException to the Zope 2 core. Just note that I've 
looked at this before and found it's hairy. Very hairy. There's a 
standard zpublisher_exception_hook that handles exceptions in a very 
very funky way (and I believe it ends up evaluating 
standard_error_message after various indirections).

FiveException simply replaces that exception handling function by 
hooking in its own. This function is probably too simple for BBB. The 
Right Way(tm) would probably to document (read: test!) the current 
behaviour, refactor it to use Five making sure the old behaviour isn't 
affected (tests still pass).

This might take longer than you expect; depending, of course, on the 
level of BBB you want to retain. There might loads of useless junk in 
there that can just be thrown out because nobody uses it or because it's 
broken.


-- 
http://worldcookery.com -- Professional Zope documentation and training