[z3-five] five:localsite zcml conflicts w/ Five 1.4

[Rob Miller]

Philipp von Weitershausen wrote:
> Rob Miller wrote:
>> Rocky Burt wrote:
>>> On Mon, 2006-27-11 at 21:35 -0800, Rob Miller wrote:
>>>> i'm using the Five 1.4 branch w/ Zope 2.9 branch, and am having problems b/c 
>>>> multiple products want the same classes to be declared as possible local 
>>>> sites.  using the <five:localsite> tag in multiple places for the same class 
>>>> will cause a ZCML conflict error.  even using overrides.zcml just buys you one 
>>>> more location you can declare it.
>>>>
>>>> is there a safe way to do this with ZCML?  the only way i can think of to work 
>>>> around this for now is to put some code in my package initialization routine 
>>>> that will inspect the classes and then call zcml.load_string with the 
>>>> five:localsite tag if necessary.  is there no better way?
>>> This sounds like a bug to me.  five:localsite should react like
>>> five:traverseable, that is it shouldn't have any discriminator and if
>>> you try running it more than once on the same class, the additional
>>> calls should simply have no effect.
>> okay, considering it to be a bug, i've committed a fix on the 1.4 branch (r71325).
> 
> Thanks.
> 
>>> Of course with Zope 2.10 I believe we won't have this problem since all
>>> ObjectManager's are IPossibleSite's to begin with.
>> does that mean i don't need to fix it in 1.5?
> 
> No, please do fix it there. Five.site exists in 1.5 and the trunk. Hence 
> both branches need to be updated as well.
> 
>> also, my products require 1.4, but should i backport this to 1.3?
> 
> Yes please.

okay, the change is now in Five 1.3, 1.4, 1.5, and trunk.

-r