[z3-five] pythonproducts monkey patches

[yuppie]

Hi Rocky!


Rocky Burt wrote:
> Thanks for pointing this out.  I've just committed a fix for this that I
> believe addresses your concerns.
> 
> r69226:
> "Made the pythonproducts monkey patching more robust by checking to
> ensure patches aren't reapplied and cleaning up after itself."

Great! The fix looks good and works for me.

Just one remark: The alphabetical order hack was just meant as an easy 
way to demonstrate that the tests did depend on a specific order. I 
don't think it is a good idea to use this for testing. Just duplicating 
the line

       >>> pythonproducts.setupPythonProducts(app)

has the same effect and is a much more explicit way to test this. And 
the cleanup can be tested at the end of the test as e.g. done in 
test_registerclass.py.


BTW: I'm afraid there is an other issue with pythonproducts. Today I saw 
the same traceback as reported here:
http://article.gmane.org/gmane.comp.web.zope.plone.user/55325
The problem went away after restarting Zope and I can't tell you how to 
reproduce this but it smells like a pythonproducts bug.


Cheers,

	Yuppie