[z3-five] pythonproducts monkey patches

[Rocky Burt]

On Wed, 2006-19-07 at 14:57 +0200, yuppie wrote:
> I'm not sure which collector to use for Five issues so I decided to 
> report this to the list:
> 
> The monkey patching code used in Five 1.4 is not very robust. If 
> setupPythonProducts is called twice _originalGetPath is set twice - the 
> second time with the patched getPath. This leads to an infinite 
> recursion because the patched getPath calls _originalGetPath.
> 
> The unit tests actually depend on the fact that test_externalmethods is 
> usually run before test_registerPackage. If you change their order 
> (AFAICS they are run in alphabetical order) you can see the problem.
> 
> I stumbled over this issue because I did run the Five tests together 
> with tests that initialize Five.

Thanks for pointing this out.  I've just committed a fix for this that I
believe addresses your concerns.

r69226:
"Made the pythonproducts monkey patching more robust by checking to
ensure patches aren't reapplied and cleaning up after itself."


Regards,
Rocky


-- 
Rocky Burt
ServerZen Software -- http://www.serverzen.com
News About The Server (blog) -- http://www.serverzen.net

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : http://codespeak.net/pipermail/z3-five/attachments/20060720/c14ada5b/attachment.pgp