[z3-five] pythonproducts monkey patches

Rocky Burt rocky at serverzen.com
Thu Jul 20 01:25:11 CEST 2006


On Thu, 2006-20-07 at 01:07 +0200, Philipp von Weitershausen wrote:
> We accept patches :). Seriously, we do, though this is Rocky's code so I
> hope he'll have something to say about this.

+1

> > If 
> > setupPythonProducts is called twice _originalGetPath is set twice - the 
> > second time with the patched getPath. This leads to an infinite 
> > recursion because the patched getPath calls _originalGetPath.

Right, good catch.


> The monkey patches, when tested, should clean up after themselves. ALL
> code that operates on global registries or does monkey patching should
> clean up after itself. If pythonproducts doesn't do that, it's a bug.

I believe it probably doesn't.


- Rocky

-- 
Rocky Burt
ServerZen Software -- http://www.serverzen.com
News About The Server (blog) -- http://www.serverzen.net

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : http://codespeak.net/pipermail/z3-five/attachments/20060719/f07ab6b2/attachment.pgp 


More information about the z3-five mailing list