[z3-five] Re: Reminder: feature freeze November 1.

[Tres Seaver]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

yuppie wrote:
> Hi Philipp!
> 
> 
> Philipp von Weitershausen wrote:
> 
>> Jim Fulton wrote:
>>
>>>> Great. Note though that the current trunk represents Five 1.2, not yet
>>>> 1.3. So, only Zope 2.7 BBB code can be removed for now	
>>>> (bbb/transaction.py, bbb/z3bridge.py, HTTPRequest monkey patches in
>>>> monkey.py).
>>>>
>>>> At a later time, when the trunk represents only Five 1.3, we can get
>>>> rid
>>>> of the duplicated interfaces in Five.bbb as well.
>>>
>>>
>>> Perhaps you should create a branch that you can make look however you
>>> want
>>> it to look, if that makes things easier.  You only have a week and a
>>> half
>>> left.
>>
>>
>> That branch you're talking about really is the zope31 branch now and
>> later the trunk, once Five 1.2 is branched off and the zope31 branch is
>> operational and has been merged. As you point out, this needs to happen
>> soon. A requirement for it to happen is that Lennart merges his work on
>> local site managers and Yuppie has taken care of the BBB code. Maybe
>> they can get done with this and create the Five-1.2 branch over the
>> weekend? (CCing Lennart and Yuppie so they hopefully can respond with a
>> positive answer).
> 
> 
> No problem. But what is the story behind this forms test?
> 
> <quote>
> otherwise we will fail to access it (N.B: this test will fail on Zope
> 2.8.1,
> which incorrectly ignored its 'handle_errors' argument):
> 
>   >>> print http(r"""
>   ... GET /test_folder_1_/ftf/+/protectedaddform.html HTTP/1.1
>   ... """, handle_errors=False)
>   HTTP/1.1 401 Unauthorized
>   ...
> </quote>
> 
> This fails with 2.8.2 as well. Where is it fixed?

The 'handle_errors=False' means that it should cause a traceback,
because the publisher is no longer catching the exception.  Martijn
Pieters proposed a patch for that (but the path to fhe file seems wrong):

- --- lib/python/Products/Five/tests/forms.txt    (revision 38617)
+++ lib/python/Products/Five/tests/forms.txt    (working copy)
@@ -36,8 +36,9 @@
   ... GET /test_folder_1_/ftf/+/protectedaddform.html HTTP/1.1
   ... Authorization: Basic viewer:secret
   ... """, handle_errors=False)
- -  HTTP/1.1 401 Unauthorized
+  Traceback (most recent call last):
   ...
+  Unauthorized: ...


I will check that patch in.

Tres.
- --
===================================================================
Tres Seaver          +1 202-558-7113          tseaver at palladion.com
Palladion Software   "Excellence by Design"    http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDWAem+gerLs4ltQ4RArIaAJ0UWP0FWyELnCECXEh5zWy9FaCD2gCfYPFc
qJH9eOaMcIFX5gC/ZJdQUBE=
=CkJh
-----END PGP SIGNATURE-----