[z3-five] Re: kupu doesn't install on Plone 2.1 (CMF 1.5 / Zope 2.8)

[yuppie]

Hi Christian!


Christian Heimes wrote:
> I have tested kupu 1.2.1 under Plone 2.1 (svn co 
> https://svn.plone.org/svn/plone/bundles/2.1-CMF1.5/). It doesn't install
> 
> error msg:
[...]
> line 513, in createDirectoryView
>     raise ValueError('Not a registered directory: %s' % minimal_fp)
> ValueError: Not a registered directory: 
> /opt/zope/instances/plone21z28cmf15/Products/kupu/common
> 
> 
> I did some debugging. CMFCore.DirectoryView._dirreg is CMF's directory 
> registry. Kupu is registered but as all other products it is registered 
> with an relativ path to Products/ and n
> 
>  >>> DirectoryView._dirreg._directories.keys()
> ['CMFDefault/skins/control', 'CMFPlone/skins/plone_3rdParty/jscalendar', 
> 'CMFPlone/skins/plone_scripts', 
> 'CMFPlone/skins/plone_3rdParty/CMFTopic', 
> 'kupu/plone/kupu_plone_layer/plonekupuimages', ... ]
> 
> After setting kupu_package_dir = 'kupu' in kupu/Extensions/Install.py I 
> was able to install kupu again.

The canonical way would be to use addDirectoryViews() instead of 
createDirectoryView(), but that doesn't work here because the 
directories are not in their own 'skins' directory.

So we have to stick to createDirectoryView, and since CMF 1.5 has lost 
the code that tries to convert wrong paths your fix is necessary.

I checked it in to 1.2 branch and trunk.


Cheers,

	Yuppie