[z3-five] Re: implementing IBrowserRequest not enough?

[Martijn Faassen]

Philipp von Weitershausen wrote:
[snip]
> No, you're actually right. The ++skin++ traversal adapter in X3.0 
> actually does:
> 
> class skin(view):
> 
>     def traverse(self, name, ignored):
>         self.request.shiftNameToApplication()
>         self.request.setPresentationSkin(name)
> 
>         return self.context
> 
> So that's not a bad monkey then.

I don't tend to add monkey patches for no reason..

Anyway, I know that on the Zope 3 trunk the whole story concerning skins 
has been modified, but right now Five aims to support released versions 
of Zope 3, so the trunk is out of scope until we know when a release 
will happen (unless someone is interested in doing this kind of work on 
a long-running branch).

I agree with Philipp's comment that we should keep monkey patches to a 
minimum. I only monkeyed in the bare minimum to bootstrap Zope 3. I 
actually think the approach of minimizing monkey patching and not trying 
to implement the full Zope 3 interfaces helped Five.

The temptation is to try to change Zope 2 itself, and while on the long 
term with sufficient resources this is a viable strategy, in practice 
Zope 2.9 has been vaporware for about a year now (Zope 2.8 was to be 
released more than a year ago and Zope 2.9 development was to start then).

Eventually with our Five experience I hope we can determine what changes 
we *really* need in Zope 2.9 and this could help avoid it moving into 
less productive directions.

Regards,

Martijn