[z3-five] Re: New style classes in browser:page

[Philipp von Weitershausen]

Martijn Faassen wrote:

> Andy Adiwidjaja wrote:
> 
>> Something we spoke about last week: When importing
>> zope.app.form.browser, an exception occurs as a configured page in the
>> configure.zcml uses a new-style class which cannot function in Z2.
>>
>> Philikon suggested that the browser:page should just ignore such
>> classes for now. Its just two lines (see attachments).
>>
>> If nobody objects, I would like to check-in these lines, the change has
>> no effects on running Five code and would enable the FiveFormDemo.
> 
> What does this checkin do? It looks like it is skipping doing some work 
> that otherwise would be done.. Anyway, if Philikon is okay with it I'm 
> okay with it too, but I haven't got the time to review it in detail now 
> (about to go on vacation in a few days). Let's check it into the trunk.

I'm ok with it under the following premasis:

- a comment is inserted to explain *why* we skip new-style classes

- a test is provided that tests this behaviour thoroughly.

Five has to deal with many incompatabilities and does semi-hackish 
things already, but at least we have code comments and tests that 
together document Five's behaviour quite well, IMO. I'd like to keep it 
that way.

Philipp