[z3-checkins] r52148 - z3/deliverance/branches/urienv/deliverance

tseaver at codespeak.net tseaver at codespeak.net
Tue Mar 4 16:54:10 CET 2008


Author: tseaver
Date: Tue Mar  4 16:54:09 2008
New Revision: 52148

Modified:
   z3/deliverance/branches/urienv/deliverance/utils.py
Log:
- Break out 'resolve_callable' as a separate utility.

- Make 'resolve_dotted_or_egg' public, non-camelCased.

- Add 'bool_from_string' utility for parsing config values.



Modified: z3/deliverance/branches/urienv/deliverance/utils.py
==============================================================================
--- z3/deliverance/branches/urienv/deliverance/utils.py	(original)
+++ z3/deliverance/branches/urienv/deliverance/utils.py	Tue Mar  4 16:54:09 2008
@@ -560,12 +560,19 @@
     environ[_SERIALIZER_KEY] = dotted_or_egg
 
 def get_serializer(environ, default=None):
-    dotted_or_egg = environ.get(_SERIALIZER_KEY, default)
+    return resolve_callable(environ.get(_SERIALIZER_KEY, default))
+
+def resolve_callable(dotted_or_egg):
     if isinstance(dotted_or_egg, basestring):
-        return _resolveDottedOrEgg(dotted_or_egg)
+        return resolve_dotted_or_egg(dotted_or_egg)
     return dotted_or_egg
 
-def _resolveDottedOrEgg(dotted_or_egg):
+def resolve_dotted_or_egg(dotted_or_egg):
     from pkg_resources import EntryPoint
     return EntryPoint.parse('x=%s' % dotted_or_egg).load(False)
 
+def bool_from_string(value):
+    if isinstance(value, basestring):
+        if value.lower() in ('false', 'no'):
+            return False
+    return bool(value)


More information about the z3-checkins mailing list