[z3-checkins] r18712 - in z3/sqlos/branch/andres-sqlobject0.7: . interfaces

[jinty at codespeak.net]

Author: jinty
Date: Mon Oct 17 12:09:49 2005
New Revision: 18712

Modified:
   z3/sqlos/branch/andres-sqlobject0.7/interfaces/__init__.py
   z3/sqlos/branch/andres-sqlobject0.7/metaconfigure.py
Log:
Remove the addColumnsFromDatabase method from the IWriteSQLObjectClass as it
moveto sqlmeta in sqlobject 0.7.

Hmmm these interfaces from SQLObject are proving to be a maintainence issue.

Why are they here I wonder?


Modified: z3/sqlos/branch/andres-sqlobject0.7/interfaces/__init__.py
==============================================================================
--- z3/sqlos/branch/andres-sqlobject0.7/interfaces/__init__.py	(original)
+++ z3/sqlos/branch/andres-sqlobject0.7/interfaces/__init__.py	Mon Oct 17 12:09:49 2005
@@ -193,10 +193,12 @@
         setter methods on the class.
         """
 
-    def addColumnsFromDatabase():
-        """ Add to the class the columns that are defined on the
-        database but not already present.
-        """
+    # XXX this moved to sqlmeta in sqlobject 0.7, should we define another
+    # interface?
+    #def addColumnsFromDatabase():
+    #    """ Add to the class the columns that are defined on the
+    #    database but not already present.
+    #    """
 
     def delColumn(column, changeSchema=False):
         """ Delete the given column from the class. 'column' may be

Modified: z3/sqlos/branch/andres-sqlobject0.7/metaconfigure.py
==============================================================================
--- z3/sqlos/branch/andres-sqlobject0.7/metaconfigure.py	(original)
+++ z3/sqlos/branch/andres-sqlobject0.7/metaconfigure.py	Mon Oct 17 12:09:49 2005
@@ -47,10 +47,7 @@
             permission=add_perm, name=id)
 
     if not IISQLObject.providedBy(component):
-        #Im sure that commenting Out that one, is not the correct
-        #sollution, but it doesnt work otherwise and it doesnt brake any
-        #test. Andres 2005-10-17
-        #if verifyClass(IISQLObject, component, tentative=1):
+        if verifyClass(IISQLObject, component, tentative=1):
             directlyProvides(component, IISQLObject)
 
     # XXX We are really creating a proxy for the *class* here.