[z3-checkins] r18247 - z3/sqlos/branch/jinty-3.0-fix_the_tests

jinty at codespeak.net jinty at codespeak.net
Fri Oct 7 09:34:33 CEST 2005


Author: jinty
Date: Fri Oct  7 09:34:31 2005
New Revision: 18247

Modified:
   z3/sqlos/branch/jinty-3.0-fix_the_tests/_sqlos.py
Log:
Comment out test breaking code that unregisters the object from the data manager when the dirty bit is not set.(125)

Modified: z3/sqlos/branch/jinty-3.0-fix_the_tests/_sqlos.py
==============================================================================
--- z3/sqlos/branch/jinty-3.0-fix_the_tests/_sqlos.py	(original)
+++ z3/sqlos/branch/jinty-3.0-fix_the_tests/_sqlos.py	Fri Oct  7 09:34:31 2005
@@ -29,11 +29,13 @@
     def _set_dirty(self, value):
         if value:
             self._connection._dm.register(self)
-        else:
-            # XXX: 'objects' shouldn't really be fiddled directly like this.
-            # Probably there should be an unregister function.
-            #   - Andrew Bennetts, 2005-01-05
-            self._connection._dm.objects.discard(self)
+        # This breaks the transaction functional tests and seems to be an 
+        # optimization only. So I've commented it out. - jinty 2005-10-5
+        #else:
+        #    # XXX: 'objects' shouldn't really be fiddled directly like this.
+        #    # Probably there should be an unregister function.
+        #    #   - Andrew Bennetts, 2005-01-05
+        #    self._connection._dm.objects.discard(self)
         self._dirty = value
 
     def _get_dirty(self):


More information about the z3-checkins mailing list