[wwwsearch-commits] r51912 - wwwsearch/mechanize/trunk/mechanize

[jjlee at codespeak.net]

Author: jjlee
Date: Thu Feb 28 01:31:47 2008
New Revision: 51912

Modified:
   wwwsearch/mechanize/trunk/mechanize/_firefox3cookiejar.py
Log:
Note a couple of issues with Firefox 3 cookie jar implementation

Modified: wwwsearch/mechanize/trunk/mechanize/_firefox3cookiejar.py
==============================================================================
--- wwwsearch/mechanize/trunk/mechanize/_firefox3cookiejar.py	(original)
+++ wwwsearch/mechanize/trunk/mechanize/_firefox3cookiejar.py	Thu Feb 28 01:31:47 2008
@@ -47,6 +47,8 @@
         not already exist.
         """
 
+        # XXX handle DatabaseError exceptions
+
         def __init__(self, filename, autoconnect=True, policy=None):
             CookieJar.__init__(self, policy)
             if filename is not None and not isstringlike(filename):
@@ -189,6 +191,9 @@
                 return
 
             def set_cookie(cur):
+                # XXX
+                # is this RFC 2965-correct?
+                # could this do an UPDATE instead?
                 row = self._row_from_cookie(cookie, cur)
                 name, unused, domain, path = row[1:5]
                 cur.execute("""\