[pypy-dev] oops, thought that chekcings automatically forwarded replied to pypy-dev

[Laura Creighton]

See my questions about hpk's checkin

laura

------- Forwarded Message

In a message of Sat, 07 May 2005 21:36:18 +0200, hpk at codespeak.net writes:
>Author: hpk
>Date: Sat May  7 21:36:17 2005
>New Revision: 12054
>
>Modified:
>   py/dist/py/test/collect.py
>Log:
>don't iterate over empty names 
>
>
>Modified: py/dist/py/test/collect.py
>=========================================================================
>=====
>--- py/dist/py/test/collect.py	(original)
>+++ py/dist/py/test/collect.py	Sat May  7 21:36:17 2005
>@@ -48,7 +48,7 @@
>         Directory = py.test.Config.getvalue('Directory', pkgpath)
>         current = Directory(pkgpath) 
>         #print "pkgpath", pkgpath
>-        names = fspath.relto(pkgpath).split(fspath.sep)
>+        names = filter(None, fspath.relto(pkgpath).split(fspath.sep))
>         for name in names: 
>             current = current.join(name) 
>             assert current, "joining %r resulted in None!" % (names,)
>_______________________________________________
>py-svn mailing list
>py-svn at codespeak.net
>http://codespeak.net/mailman/listinfo/py-svn

This seems to fail the 'straightforwardness test'  ....
any real reason we need filter there, or am i just lost?

Laura

------- End of Forwarded Message