[py-dev] Svn auth update
Guido Wesdorp
johnny at johnnydebris.net
Thu Feb 14 09:01:38 CET 2008
holger krekel wrote:
> great! I am still not sure if passing auth to the constructor makes sense, though.
>
>
Hm, well, I'm not sure either... It does make the API nicer to use imo,
though...
> I've reviewed and made 51470|1|2 commits accordingly - please check.
>
I checked as the checkin messages came in... :) Looking good, thanks!
> I'd just put it to the SvnAuth class - and modify the docstring
> to say that it encapsulates svn authentication aspects.
>
>
Okay.
> Could you maybe write a large functional test that creates a
> repo, does checkouts and uses all the wc methods with auth?
>
>
Hm, yes, I'll try that...
Thanks for the refactoring and feedback!
Cheers,
Guido
More information about the py-dev
mailing list