[lxml-dev] [Lxml-checkins] r60038 - lxml/trunk - make static build the default

[Stefan Behnel]

Hi Ian,

ianb wrote:
> Modified: lxml/trunk/setupinfo.py
> ==============================================================================
> --- lxml/trunk/setupinfo.py	(original)
> +++ lxml/trunk/setupinfo.py	Thu Nov 20 20:25:47 2008
> @@ -317,7 +317,7 @@
>  OPTION_STATIC = has_option('static')
>  OPTION_DEBUG_GCC = has_option('debug-gcc')
>  OPTION_AUTO_RPATH = has_option('auto-rpath')
> -OPTION_BUILD_LIBXML2XSLT = has_option('static-deps')
> +OPTION_BUILD_LIBXML2XSLT = has_option('static-deps', 'true')
>  if OPTION_BUILD_LIBXML2XSLT:
>      OPTION_STATIC = True
>  OPTION_LIBXML2_VERSION = option_value('libxml2-version')

I'm not sure this should become the default. A dynamic build is generally
the right thing and works very well on most platforms, except for Windows
and MacOS-X.

I wouldn't mind defaulting it to 'true' explicitly on those two platforms,
though. MacOS-X packagers can just pass the respective env var to disable it.

Stefan