[lxml-dev] annotate, pyannotate, xsiannotate

[jholg at gmx.de]

Hi Stefan,

> > - fixes a bug in DataElement that did not set py:pytype correctly when
> invoked with unicode string args and adds some tests for this.
> 
> You should just commit this kind of fixes instead of sending them to the
> list.

Ok.
 
> > I renamed _get_pytypename() to _pytypename() (internal) and
> __get_pytypename() to pytypename() (public), so DataElement() now uses _pytypename()
> rather than _typename().
> 
> Any reason there *is* a pytypename() function? It doesn't seem to be used.

I figured it's nice to have it usable from outside objectify if you need to use explicit pytype names, so you don't have to reimplement the str/unicode distinction everywhere.

> > Btw I'm getting core dumps in the schematron tests:
> > 
> >  685/802 ( 85.4%): test_schematron_invalid_schema_empty
> (...hematron.ETreeSchematronTestCase)Segmentation Fault (core dumped)
> > 
> > #0  0xff0b3218 in strlen () from /usr/lib/libc.so.1
> > #1  0xff106530 in _doprnt () from /usr/lib/libc.so.1
> > #2  0xff108730 in vsnprintf () from /usr/lib/libc.so.1
> > #3  0xfe2b7874 in __xmlRaiseError () from /apps/prod/lib/libxml2.so.2
> > #4  0xfe45fd5c in xmlSchematronPErr () from /apps/prod/lib/libxml2.so.2
> > #5  0xfe462d24 in xmlSchematronParse () from /apps/prod/lib/libxml2.so.2
> > #6  0xfe60f080 in __pyx_f_5etree_10Schematron___init__
> (__pyx_v_self=0x829a10, 
> >     __pyx_args=0x8872c8, __pyx_kwds=0x109b04) at src/lxml/etree.c:4131
> > #7  0x58504 in type_call (type=0xfe665988, args=0x829d30, kwds=0x89d4b0)
> >     at Objects/typeobject.c:443
> > #8  0x260c4 in PyObject_Call (func=0x829a10, arg=0x829d30, kw=0x89d4b0)
> >     at Objects/abstract.c:1802
> 
> I don't get those, with none of the supported libxml2 versions. What's the
> one
> you use? Have you seen those with the trunk before or is it just now?

No, I've not seen such problems on the trunk before. I had to upgrade to latest cython to build this time.

This is the setup:

TESTED VERSION: 2.0.alpha2-46719
    Python:            (2, 4, 4, 'final', 0)
    lxml.etree:        (2, 0, -198, 46719)
    libxml used:       (2, 6, 27)
    libxml compiled:   (2, 6, 27)
    libxslt used:      (1, 1, 20)
    libxslt compiled:  (1, 1, 20)

Holger


-- 
Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! 
Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer