[Lxml-checkins] r48170 - in lxml/trunk: . src/lxml/tests

scoder at codespeak.net scoder at codespeak.net
Mon Oct 29 20:01:56 CET 2007


Author: scoder
Date: Mon Oct 29 20:01:50 2007
New Revision: 48170

Modified:
   lxml/trunk/src/lxml/tests/common_imports.py
   lxml/trunk/src/lxml/tests/test_classlookup.py
   lxml/trunk/src/lxml/tests/test_elementtree.py
   lxml/trunk/src/lxml/tests/test_htmlparser.py
   lxml/trunk/src/lxml/tests/test_io.py
   lxml/trunk/src/lxml/tests/test_nsclasses.py
   lxml/trunk/src/lxml/tests/test_objectify.py
   lxml/trunk/src/lxml/tests/test_pyclasslookup.py
   lxml/trunk/test.py
Log:
move gc.collect() into tearDown() methods in tests to run it after each test

Modified: lxml/trunk/src/lxml/tests/common_imports.py
==============================================================================
--- lxml/trunk/src/lxml/tests/common_imports.py	(original)
+++ lxml/trunk/src/lxml/tests/common_imports.py	Mon Oct 29 20:01:50 2007
@@ -1,7 +1,7 @@
 import unittest
 import os.path
 from StringIO import StringIO
-import re
+import re, gc
 
 from lxml import etree
 
@@ -40,6 +40,12 @@
         return seq
 
 class HelperTestCase(unittest.TestCase):
+    def setUp(self):
+        gc.collect()
+
+    def tearDown(self):
+        gc.collect()
+
     def parse(self, text):
         f = StringIO(text)
         return etree.parse(f)

Modified: lxml/trunk/src/lxml/tests/test_classlookup.py
==============================================================================
--- lxml/trunk/src/lxml/tests/test_classlookup.py	(original)
+++ lxml/trunk/src/lxml/tests/test_classlookup.py	Mon Oct 29 20:01:50 2007
@@ -26,6 +26,7 @@
 
     def tearDown(self):
         etree.setElementClassLookup()
+        super(ClassLookupTestCase, self).tearDown()
 
     def test_namespace_lookup(self):
         class TestElement(etree.ElementBase):

Modified: lxml/trunk/src/lxml/tests/test_elementtree.py
==============================================================================
--- lxml/trunk/src/lxml/tests/test_elementtree.py	(original)
+++ lxml/trunk/src/lxml/tests/test_elementtree.py	Mon Oct 29 20:01:50 2007
@@ -9,7 +9,7 @@
 """
 
 import unittest, doctest
-import os, re, shutil, tempfile, copy, operator
+import os, re, shutil, tempfile, copy, operator, gc
 
 from common_imports import StringIO, etree, ElementTree, cElementTree
 from common_imports import fileInTestDir, canonicalize
@@ -24,8 +24,10 @@
     
     def setUp(self):
         self._temp_dir = tempfile.mkdtemp()
+        gc.collect()
         
     def tearDown(self):
+        gc.collect()
         shutil.rmtree(self._temp_dir)
 
     def getTestFilePath(self, name):

Modified: lxml/trunk/src/lxml/tests/test_htmlparser.py
==============================================================================
--- lxml/trunk/src/lxml/tests/test_htmlparser.py	(original)
+++ lxml/trunk/src/lxml/tests/test_htmlparser.py	Mon Oct 29 20:01:50 2007
@@ -10,7 +10,7 @@
 from common_imports import StringIO, etree, fileInTestDir
 from common_imports import SillyFileLike, HelperTestCase
 
-class HtmlParserTestCaseBase(HelperTestCase):
+class HtmlParserTestCase(HelperTestCase):
     """HTML parser test cases
     """
     etree = etree
@@ -25,6 +25,7 @@
     uhtml_str = u"<html><head><title>test á\uF8D2</title></head><body><h1>page á\uF8D2 title</h1></body></html>"
 
     def tearDown(self):
+        super(HtmlParserTestCase, self).tearDown()
         self.etree.setDefaultParser()
 
     def test_module_HTML(self):
@@ -276,7 +277,7 @@
 
 def test_suite():
     suite = unittest.TestSuite()
-    suite.addTests([unittest.makeSuite(HtmlParserTestCaseBase)])
+    suite.addTests([unittest.makeSuite(HtmlParserTestCase)])
     return suite
 
 if __name__ == '__main__':

Modified: lxml/trunk/src/lxml/tests/test_io.py
==============================================================================
--- lxml/trunk/src/lxml/tests/test_io.py	(original)
+++ lxml/trunk/src/lxml/tests/test_io.py	Mon Oct 29 20:01:50 2007
@@ -5,7 +5,7 @@
 """
 
 import unittest
-import tempfile, gzip, os
+import tempfile, gzip, os, gc
 
 from common_imports import etree, ElementTree, fileInTestDir
 from common_imports import SillyFileLike, LargeFileLike
@@ -18,10 +18,14 @@
     def setUp(self):
         """Setting up a minimal tree
         """
+        gc.collect()
         self.root = self.etree.Element('a')
         self.root_str = self.etree.tostring(self.root)
         self.tree = self.etree.ElementTree(self.root)
 
+    def tearDown(self):
+        gc.collect()
+
     def test_write_filename(self):
         # (c)ElementTree  supports filename strings as write argument
         

Modified: lxml/trunk/src/lxml/tests/test_nsclasses.py
==============================================================================
--- lxml/trunk/src/lxml/tests/test_nsclasses.py	(original)
+++ lxml/trunk/src/lxml/tests/test_nsclasses.py	Mon Oct 29 20:01:50 2007
@@ -21,6 +21,7 @@
             return u'bluff'
 
     def setUp(self):
+        super(ETreeNamespaceClassesTestCase, self).setUp()
         lookup = etree.ElementNamespaceClassLookup()
         self.Namespace = lookup.get_namespace
         parser = etree.XMLParser()
@@ -30,6 +31,7 @@
     def tearDown(self):
         etree.setDefaultParser()
         del self.Namespace
+        super(ETreeNamespaceClassesTestCase, self).tearDown()
 
     def test_registry(self):
         ns = self.Namespace(u'ns01')

Modified: lxml/trunk/src/lxml/tests/test_objectify.py
==============================================================================
--- lxml/trunk/src/lxml/tests/test_objectify.py	(original)
+++ lxml/trunk/src/lxml/tests/test_objectify.py	Mon Oct 29 20:01:50 2007
@@ -72,6 +72,7 @@
         return self.etree.XML(xml, self.parser)
 
     def setUp(self):
+        super(ObjectifyTestCase, self).setUp()
         self.parser = self.etree.XMLParser(remove_blank_text=True)
         self.lookup = etree.ElementNamespaceClassLookup(
             objectify.ObjectifyElementClassLookup() )
@@ -87,6 +88,7 @@
         objectify.setPytypeAttributeTag()
         del self.lookup
         del self.parser
+        super(ObjectifyTestCase, self).tearDown()
 
     def test_element_nsmap_default(self):
         elt = objectify.Element("test")

Modified: lxml/trunk/src/lxml/tests/test_pyclasslookup.py
==============================================================================
--- lxml/trunk/src/lxml/tests/test_pyclasslookup.py	(original)
+++ lxml/trunk/src/lxml/tests/test_pyclasslookup.py	Mon Oct 29 20:01:50 2007
@@ -33,6 +33,7 @@
 
     def tearDown(self):
         self.parser.setElementClassLookup(None)
+        super(PyClassLookupTestCase, self).tearDown()
 
     def _setClassLookup(self, lookup_function):
         class Lookup(PythonElementClassLookup):

Modified: lxml/trunk/test.py
==============================================================================
--- lxml/trunk/test.py	(original)
+++ lxml/trunk/test.py	Mon Oct 29 20:01:50 2007
@@ -63,8 +63,6 @@
 # and cleaner though, at the expense of more limited functionality.
 #
 
-import gc
-
 import re
 import os
 import sys
@@ -418,7 +416,6 @@
         test(result)
         stopTime = time.time()
         timeTaken = float(stopTime - startTime)
-        gc.collect()
         result.printErrors()
         run = result.testsRun
         if not self.cfg.quiet:


More information about the lxml-checkins mailing list