From aaltepet at altepeter.net  Mon May 11 18:02:14 2009
From: aaltepet at altepeter.net (Andy Altepeter)
Date: Mon, 11 May 2009 11:02:14 -0500
Subject: [kupu-dev] kupu updatestate patch
Message-ID: <200905111102.14605.aaltepet@altepeter.net>

Greetings,

I'm a Silva developer, working to push Silva's kupu implementation to the next 
level.  I've identified a bug in kupueditor.js which causes clicks in the 
content to trigger two state updated.  There updatestate handler is being 
called twice, because it is registered for both mouseup and click.

This causes a few problems.  One of them is mostly visual: screen flickers can 
happen, if the state of the tools changes.  The second one is that if 
updatestate triggers any AJAX requests, they happen twice.

I've attached a patch for this, and would like to see it put in the trunk.  
However, silva has it's own branch of kupu, for reasons that aren't quite 
clear to me, and this will also need to be applied there as well.

Please advise on how to proceed with this patch.

Cheers,
Andy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kupu_double-event_fix.diff
Type: text/x-diff
Size: 594 bytes
Desc: not available
Url : http://codespeak.net/pipermail/kupu-dev/attachments/20090511/e3abc137/attachment.bin 

From me at rpatterson.net  Sat May 30 21:05:43 2009
From: me at rpatterson.net (Ross Patterson)
Date: Sat, 30 May 2009 12:05:43 -0700
Subject: [kupu-dev] Products.kupu = 1.4.13 breaks inline KSS editing
Message-ID: <87y6seif7c.fsf@transitory.lefae.org>

Just wanted to draw your attention to the following Plone bug:

https://dev.plone.org/old/plone/ticket/9239#comment:4 writes:

> #9239: Inline editing doesn't work
> ----------------------------------+-----------------------------------------
>  Reporter:  dannyb                |        Owner:  duncan
>      Type:  Bug                   |       Status:  new   
>  Priority:  blocker               |    Milestone:  3.3   
> Component:  Visual Editor (Kupu)  |   Resolution:        
>  Keywords:                        |  
> ----------------------------------+-----------------------------------------
> Changes (by rossp):
>
>  * cc: rossp (added)
>   * owner:  ree => duncan
>   * component:  KSS (Ajax) => Visual Editor (Kupu)
>
>
> Comment:
>
>  I reverted "Products.kupu = 1.4.12.1" in versions.cfg and inline
>  kupu editing works again.  I didn't see anything obvious in the
>  Products.kupu changelog from 1.4.12.1 to 1.4.13 and I know very little
>  about kupu so I'm afraid this is all I can do ATM.

Thanks!
Ross