[kupu-dev] Proposed patch: click *and* mouseup event triggering?

[eric casteleijn]

[Reported by Andy Altepeter, who's not on this list.]

In kupu/common/kupueditor.js we have:

         if (event.type == 'click' || event.type=='mouseup' ||
                 (event.type == 'keyup' &&
                     interesting_codes.contains(event.keyCode)))

which (in some cases/browsers?) means that the event handler is 
triggered twice, once for the mouseup, and once for the entire click 
event. Changing this to just:

         if (event.type == 'click' ||

Seems to fix this, and have no adverse effects. Is there a reason both 
are checked, or should I commit this patch?

-- 
- eric casteleijn
http://infrae.com