[kupu-dev] what's up with the new "lightbox" hook in the captioning transform?

[Duncan Booth]

"Jon Stahl" <jon at onenw.org> wrote:

> 
> If this is intended as a hook for lightbox, why not say so?  ;-)   And
> why not include the lightbox js, css & supporting graphics with kupu?  
> 
> As it is right now, if one naively turns on image captioning, images
> suddently become clickable, which our users found unexpected and
> confusing.  It felt like a bug to them. :-(
> 
> Secondly, is it wise to pack lightboxing into the captioning 
transform?
> Shouldn't lightboxing be selectable separately from captioning, and
> perhaps implemented through a separate transform?  IOW, not everyone
> would want both captioning and lightboxing, why not make them
> independently selectable?
> 
> Is there some other intent here that I'm missing?
> 
> 
There are two parts to this: the simple one is that if you insert an 
image which is reduced in size then it becomes a clickable link to the 
fullsize image. I thought this was mentioned in CHANGES.txt (1.4rc2 was 
when the captioning changes went in) but I guess I forgot to mention it 
explicitly.

The other one is the lightbox support: the intention here was not to 
force any particular lightbox implementations on a site, nor even to 
force any lightbox implementation. Danny asked me to put this feature in 
and I reckoned it would be harmless for those sites without the lightbox 
js. I certainly don't want to propose shipping Plone with mootools 
included: that is one bit of javascript I'm rapidly coming to dislike.

I think that (at least in principle) you are correct that there should 
be more options to configure the transform. So captioning, link to 
fullsize image, and lightboxing could all be separate (though I think 
the lightbox stuff needs the backlink so maybe each option implies the 
earlier ones). The template is going to be more complex though, and I've 
got a problem with unit tests at the moment (unit tests for captioning 
are broken since I added the template, and I haven't figured out how to 
fix them properly).

The other thing is that, whether the transform is left as-is or 
improved, the documentation needs improving.

If you'd like, create an issue for this so that I don't forget to come 
back to it.