[kupu-dev] Avoid filtering of HTML-comments

Duncan Booth duncan.booth at suttoncourtenay.org.uk
Mon Nov 12 17:09:45 CET 2007


Jon Stahl <jon at onenw.org> wrote:

> I think Sean's expectation is actually pretty reasonable.  WYSIWYG 
> editors like Dreamweaver and FrontPage leave comments unmolested when 
> you're editing graphically. 
> 
> If it's not difficult to support, I'd be +1.   Even though I agree that 
> using comments for revision-management is asking for trouble.

The patch I posted earlier in this thread is all that is needed, but the 
behaviour isn't quite perfect.

The worst problem is that a comment at the start turns off kupu. If I'd 
realised anyone would want to have comments at the same time as wysiwyg 
editing I could have insisted on a specific format of comment, but I can't 
break behaviour on a minor release. I guess I could add another config 
option to specify a substring which has to occur in the leading comment to 
suppress kupu (defaulting to blank): that would preserve behaviour and 
still allow anyone who really wants comments to keep them.

There also seems to be a problem that comments are being moved out of 
paragraphs, and in IE sometimes disappear altogether. I'll have to 
investigate whether that is something I'm doing or a feature provided by 
the browsers.



More information about the kupu-dev mailing list