[kupu-checkins] r54791 - in kupu/trunk/kupu: doc plone

[duncan at codespeak.net]

Author: duncan
Date: Fri May 16 16:55:50 2008
New Revision: 54791

Modified:
   kupu/trunk/kupu/doc/CHANGES.txt
   kupu/trunk/kupu/plone/plonedrawers.py
Log:
Fix plone ticket 8129, error on plonedrawers.py when installing

Modified: kupu/trunk/kupu/doc/CHANGES.txt
==============================================================================
--- kupu/trunk/kupu/doc/CHANGES.txt	(original)
+++ kupu/trunk/kupu/doc/CHANGES.txt	Fri May 16 16:55:50 2008
@@ -9,6 +9,7 @@
     * 7958 Kupu: Insert image: KeyError: 'info' (Error 503 loading kupucollection.xml?resource_type=mediaobject)
     * 7990 Internal link drawer broken for editors
     * 8003 Fixed Kupu translation msgids containing html.
+    * 8129 "TypeError: string indices must be integers" error on plonedrawers.py when installing
 
 - 1.4.9
 

Modified: kupu/trunk/kupu/plone/plonedrawers.py
==============================================================================
--- kupu/trunk/kupu/plone/plonedrawers.py	(original)
+++ kupu/trunk/kupu/plone/plonedrawers.py	Fri May 16 16:55:50 2008
@@ -491,9 +491,12 @@
                 preview = None
                 previewsize = (0,0)
                 for k in sizes:
-                    if previewsize < sizes[k] <= (128,128):
-                        preview = k
-                        previewsize = sizes[k]
+                    try:
+                        if previewsize < sizes[k] <= (128,128):
+                            preview = k
+                            previewsize = sizes[k]
+                    except TypeError: # Fails on Plone 2.1
+                        return field.getName()
                 if not preview:
                     smallest = min(sizes.values())
                     for k in sizes: