[kupu-checkins] r43558 - in kupu/trunk/kupu: common plone/kupu_plone_layer

[duncan at codespeak.net]

Author: duncan
Date: Tue May 22 11:49:54 2007
New Revision: 43558

Modified:
   kupu/trunk/kupu/common/kupucontentfilters.js
   kupu/trunk/kupu/plone/kupu_plone_layer/kupuplone.css.dtml
Log:
embed tag also needs to be forced visible in Firefox.
Attribute filtering for embed tag ('*' attributes) was broken on IE as it added a load of unwanted attributes.

Modified: kupu/trunk/kupu/common/kupucontentfilters.js
==============================================================================
--- kupu/trunk/kupu/common/kupucontentfilters.js	(original)
+++ kupu/trunk/kupu/common/kupucontentfilters.js	Tue May 22 11:49:54 2007
@@ -482,11 +482,12 @@
             var bad = filter.badTagAttributes[nodeName];
             for (var i=0; i < htmlnode.attributes.length; i++) {
                 var attr = htmlnode.attributes[i];
-                if (bad && bad.contains(attr.name)) {
+                var name = attr.name;
+                if (bad && bad.contains(name)) {
                     continue;
                 };
-                if (attr.value !== null && attr.value !== undefined) {
-                    xhtmlnode.setAttribute(attr.name, attr.value);
+                if (attr.specified) {
+                    xhtmlnode.setAttribute(name, attr.value);
                 };
             };
         };

Modified: kupu/trunk/kupu/plone/kupu_plone_layer/kupuplone.css.dtml
==============================================================================
--- kupu/trunk/kupu/plone/kupu_plone_layer/kupuplone.css.dtml	(original)
+++ kupu/trunk/kupu/plone/kupu_plone_layer/kupuplone.css.dtml	Tue May 22 11:49:54 2007
@@ -288,10 +288,10 @@
 }
 /* Firefox makes Flash objects completely invisible.
 We need to force it to display something otherwise you cannot edit existing Flash. */
-.kupu-html object.image-inline {
+.kupu-html object, .kupu-html embed {
    display: block;
    background-image: url(plonekupuimages/flash-placeholder.png);
-   border: 2px green solid;
+   border: 1px black solid;
 }
 /* </dtml-let></dtml-with> */