[kupu-checkins] r42388 - in kupu/trunk/kupu/plone: . kupu_plone_layer kupu_references

limi at codespeak.net limi at codespeak.net
Sat Apr 28 12:29:22 CEST 2007


Author: limi
Date: Sat Apr 28 12:29:22 2007
New Revision: 42388

Modified:
   kupu/trunk/kupu/plone/body.kupu
   kupu/trunk/kupu/plone/kupu_config.pt
   kupu/trunk/kupu/plone/kupu_plone_layer/kupu_wysiwyg_support.html
   kupu/trunk/kupu/plone/kupu_plone_layer/kupuplone.css.dtml
   kupu/trunk/kupu/plone/kupu_references/referencebrowser.pt
   kupu/trunk/kupu/plone/wysiwyg_support.kupu
   kupu/trunk/kupu/plone/zmi_toolbar.pt
Log:
Death to tabindexes!

Modified: kupu/trunk/kupu/plone/body.kupu
==============================================================================
--- kupu/trunk/kupu/plone/body.kupu	(original)
+++ kupu/trunk/kupu/plone/body.kupu	Sat Apr 28 12:29:22 2007
@@ -15,9 +15,8 @@
         tal:define="base python:here.kupu_library_tool.getBaseUrl(here, True);
                     base kupu_base_override|base;"
         tal:attributes="src string:${base}/emptypage;
-                        tabindex tabindex/next|nothing;
-			id string:kupu-editor-iframe-${fname};
-			name string:kupu-editor-iframe-${fname};"
+                        id string:kupu-editor-iframe-${fname};
+                        name string:kupu-editor-iframe-${fname};"
         >
     </iframe>
      <input type="hidden" name="text_format:default" value="text/html"
@@ -28,7 +27,6 @@
      />
 <tal:test condition="fieldName|nothing">
     <textarea cols="80" rows="25"
-        tabindex=""
         class="kupu-editor-textarea"
         name="description"
         tal:condition="fieldName|nothing"
@@ -37,13 +35,11 @@
         tal:attributes="name inputname;
                         onfocus onfocus|nothing;
                         onblur onblur|nothing;
-                        tabindex tabindex|nothing;
                         rows rows|default;
                         cols cols|default;">
     </textarea>
 </tal:test>
     <textarea cols="80" rows="25"
-        tabindex=""
         class="kupu-editor-textarea"
         name="description"
         id="kupu-editor-textarea"
@@ -59,7 +55,6 @@
         tal:attributes="name inputname;
                         onfocus onfocus|nothing;
                         onblur onblur|nothing;
-                        tabindex tabindex|nothing;
                         rows rows|default;
                         cols cols|default;">
     </textarea>

Modified: kupu/trunk/kupu/plone/kupu_config.pt
==============================================================================
--- kupu/trunk/kupu/plone/kupu_config.pt	(original)
+++ kupu/trunk/kupu/plone/kupu_config.pt	Sat Apr 28 12:29:22 2007
@@ -285,12 +285,10 @@
 </fieldset>
 
 <input class="context"
-        tabindex=""
         type="submit"
         name="configure_kupu:method"
         value="Save"
         i18n:attributes="value"
-        tal:attributes="tabindex tabindex|nothing;"
         />
 </form>
     </div>

Modified: kupu/trunk/kupu/plone/kupu_plone_layer/kupu_wysiwyg_support.html
==============================================================================
--- kupu/trunk/kupu/plone/kupu_plone_layer/kupu_wysiwyg_support.html	(original)
+++ kupu/trunk/kupu/plone/kupu_plone_layer/kupu_wysiwyg_support.html	Sat Apr 28 12:29:22 2007
@@ -436,18 +436,70 @@
     </table>
   <script type="text/javascript">var focuscount = 0;</script>
     <div>
-    <iframe class="kupu-editor-iframe" frameborder="0" src="emptypage" onfocus="this.contentWindow.focus();" tal:define="base python:here.kupu_library_tool.getBaseUrl(here, True);                     base kupu_base_override|base;" tal:attributes="src string:${base}/emptypage;                         tabindex tabindex/next|nothing;    id string:kupu-editor-iframe-${fname};    name string:kupu-editor-iframe-${fname};">
+    <iframe class="kupu-editor-iframe" 
+            frameborder="0" 
+            src="emptypage" 
+            onfocus="this.contentWindow.focus();" 
+            tal:define="base python:here.kupu_library_tool.getBaseUrl(here, True);
+                        base kupu_base_override|base;" 
+            tal:attributes="src string:${base}/emptypage;
+                            id string:kupu-editor-iframe-${fname};
+                            name string:kupu-editor-iframe-${fname};">
     </iframe>
-     <input type="hidden" name="text_format:default" value="text/html" tal:define="fieldName fieldName|inputname|nothing;                 val python:fieldName and 'text/html' or 'html';                 fieldName python:test(fieldName, fieldName+'_', '') + 'text_format:default';" tal:attributes="name fieldName;value val;"/>
+     <input type="hidden" 
+            name="text_format:default" 
+            value="text/html" 
+            tal:define="fieldName fieldName|inputname|nothing;
+                        val python:fieldName and 'text/html' or 'html';
+                        fieldName python:test(fieldName, fieldName+'_', '') + 'text_format:default';" 
+            tal:attributes="name fieldName;value val;" 
+            />
 <tal:test condition="fieldName|nothing">
-    <textarea cols="80" rows="25" tabindex="" class="kupu-editor-textarea" name="description" tal:condition="fieldName|nothing" tal:define="global kupu_content python:here.convertContentForKupu(fieldName, inputvalue);" tal:content="kupu_content" tal:attributes="name inputname;                         onfocus onfocus|nothing;                         onblur onblur|nothing;                         tabindex tabindex|nothing;                         rows rows|default;                         cols cols|default;">
+    <textarea cols="80" 
+              rows="25" 
+              class="kupu-editor-textarea" 
+              name="description" 
+              tal:condition="fieldName|nothing" 
+              tal:define="global kupu_content python:here.convertContentForKupu(fieldName, inputvalue);"
+              tal:content="kupu_content"
+              tal:attributes="name inputname;
+                              onfocus onfocus|nothing;
+                              onblur onblur|nothing;
+                              rows rows|default;
+                              cols cols|default;">
     </textarea>
 </tal:test>
-    <textarea cols="80" rows="25" tabindex="" class="kupu-editor-textarea" name="description" id="kupu-editor-textarea" tal:define="pss modules/Products/PythonScripts/standard;                 text_format text_format | python: getattr(here,'text_format','html');                 is_stx python:text_format=='structured-text';                 is_ptx python:text_format=='plain';" tal:condition="not:fieldName|nothing" tal:content="python:(is_stx and pss.structured_text(inputvalue))                                     or (is_ptx and pss.newline_to_br(inputvalue))                                     or inputvalue" tal:attributes="name inputname;                         onfocus onfocus|nothing;                         onblur onblur|nothing;                         tabindex tabindex|nothing;                         rows rows|default;                         cols cols|default;">
+    <textarea cols="80" 
+              rows="25" 
+              class="kupu-editor-textarea" 
+              name="description" 
+              id="kupu-editor-textarea" 
+              tal:define="pss modules/Products/PythonScripts/standard;
+                          text_format text_format | python: getattr(here,'text_format','html');
+                          is_stx python:text_format=='structured-text';
+                          is_ptx python:text_format=='plain';"
+              tal:condition="not:fieldName|nothing" 
+              tal:content="python:(is_stx and pss.structured_text(inputvalue))
+                                           or (is_ptx and pss.newline_to_br(inputvalue))
+                                           or inputvalue" 
+              tal:attributes="name inputname;
+                                   onfocus onfocus|nothing;
+                                   onblur onblur|nothing;
+                                   rows rows|default;
+                                   cols cols|default;">
     </textarea>
     </div>
   
-    <div class="kupuoverride" tal:condition="python:exists('kupu_content') and len(kupu_content)==0" tal:define="floated widget/allow_file_upload | python:1;" tal:attributes="style python:test(floated, 'float:left;;', '');"><span class="discreet"><a class="forcekupu" href="#" i18n:translate="suppress-kupu" tal:attributes="href string:${request/URL0}?kupu.suppress=${fieldName};" title="reload current page without kupu">
+    <div class="kupuoverride" 
+         tal:condition="python:exists('kupu_content') and len(kupu_content)==0" 
+         tal:define="floated widget/allow_file_upload | python:1;" 
+         tal:attributes="style python:test(floated, 'float:left;;', '');">
+         <span class="discreet">
+             <a class="forcekupu" 
+                href="#" 
+                i18n:translate="suppress-kupu" 
+                tal:attributes="href string:${request/URL0}?kupu.suppress=${fieldName};" 
+                title="Reload current page without visual editor">
          Edit without visual editor
       </a></span>
     </div>
@@ -466,7 +518,16 @@
     <link href="kupudrawerstyles.css" rel="stylesheet" type="text/css" tal:attributes="href string:${portal_url}/kupudrawerstyles.css"/>
    </tal:test>
   
-    <textarea cols="80" rows="25" tabindex="" name="fieldName" tal:content="inputvalue" tal:attributes="name fieldName|inputname;                         id fieldName|inputname;                         onfocus onfocus|nothing;                         onblur onblur|nothing;                         tabindex tabindex|nothing;                         rows rows|default;                         cols cols|default;">
+    <textarea cols="80" 
+              rows="25" 
+              name="fieldName" 
+              tal:content="inputvalue" 
+              tal:attributes="name fieldName|inputname;
+                              id fieldName|inputname;
+                              onfocus onfocus|nothing;
+                              onblur onblur|nothing;
+                              rows rows|default;
+                              cols cols|default;">
     </textarea>
   
     <tal:archetypes tal:condition="fieldName|nothing">
@@ -501,13 +562,31 @@
        Text and type the document as you usually do.
      </div>
 
-     <input class="noborder" type="radio" name="text_format" value="structured-text" tabindex="" id="cb_structuredtext" tal:attributes="checked python:test(text_format=='structured-text', 1, None);                             tabindex tabindex;"/>
+     <input class="noborder" 
+            type="radio" 
+            name="text_format" 
+            value="structured-text" 
+            id="cb_structuredtext" 
+            tal:attributes="checked python:test(text_format=='structured-text', 1, None);"
+            />
      <label for="cb_structuredtext" i18n:translate="structured_text">Structured Text</label> <br/>
 
-     <input class="noborder" type="radio" name="text_format" value="html" tabindex="" id="cb_html" tal:attributes="checked python:test(text_format=='html', 1, None);                             tabindex tabindex;"/>
+     <input class="noborder" 
+            type="radio" 
+            name="text_format" 
+            value="html" 
+            id="cb_html" 
+            tal:attributes="checked python:test(text_format=='html', 1, None);"
+            />
      <label for="cb_html" i18n:translate="html">HTML</label> <br/>
 
-     <input class="noborder" type="radio" name="text_format" value="plain" tabindex="" id="cb_plain" tal:attributes="checked python:test(text_format=='plain', 1, None);                             tabindex tabindex;"/>
+     <input class="noborder" 
+            type="radio" 
+            name="text_format" 
+            value="plain" 
+            id="cb_plain" 
+            tal:attributes="checked python:test(text_format=='plain', 1, None);"
+            />
      <label for="cb_plain" i18n:translate="plain_text">Plain Text</label>
     </tal:nonat>
   </tal:noeditor>

Modified: kupu/trunk/kupu/plone/kupu_plone_layer/kupuplone.css.dtml
==============================================================================
--- kupu/trunk/kupu/plone/kupu_plone_layer/kupuplone.css.dtml	(original)
+++ kupu/trunk/kupu/plone/kupu_plone_layer/kupuplone.css.dtml	Sat Apr 28 12:29:22 2007
@@ -72,6 +72,11 @@
 
 /* plone customizations regarding color and borders etc */
 
+/* hide the Plone table of contents if it is visible (inline edit) */
+dl.toc {
+    display: none;
+}
+
 .kupu-tb {
   background-color:&dtml-contentViewBackgroundColor;;
   padding-bottom:0px; margin:0;

Modified: kupu/trunk/kupu/plone/kupu_references/referencebrowser.pt
==============================================================================
--- kupu/trunk/kupu/plone/kupu_references/referencebrowser.pt	(original)
+++ kupu/trunk/kupu/plone/kupu_references/referencebrowser.pt	Sat Apr 28 12:29:22 2007
@@ -180,7 +180,6 @@
                                 value="" 
                                 id="" 
                                 tal:attributes="value obj/title_or_id;
-                                                      tabindex tabindex/next;
                                                       size python:test(widget.size=='', 30, widget.size);
                                                       id string:${fieldName}_label" readonly="readonly" />
                   </tal:block>
@@ -204,11 +203,9 @@
                      tal:define="targets python:[(here.reference_catalog.lookupObject(u),u) for u in uids if u]">
                 <select
                   multiple="multiple"
-                  tabindex=""
                   tal:attributes="name string:${fieldName}:list;
                                         id string:${fieldName};
-                                        size python:test(widget.size=='', 8, widget.size);
-                                        tabindex tabindex/next;">
+                                        size python:test(widget.size=='', 8, widget.size);">
                     <tal:block tal:repeat="set targets">
                         <option value=""
                                      selected="selected"

Modified: kupu/trunk/kupu/plone/wysiwyg_support.kupu
==============================================================================
--- kupu/trunk/kupu/plone/wysiwyg_support.kupu	(original)
+++ kupu/trunk/kupu/plone/wysiwyg_support.kupu	Sat Apr 28 12:29:22 2007
@@ -38,14 +38,12 @@
     <textarea
         cols="80"
         rows="25"
-        tabindex=""
         name="fieldName"
         tal:content="inputvalue"
         tal:attributes="name fieldName|inputname;
                         id fieldName|inputname;
                         onfocus onfocus|nothing;
                         onblur onblur|nothing;
-                        tabindex tabindex|nothing;
                         rows rows|default;
                         cols cols|default;">
     </textarea>
@@ -85,10 +83,8 @@
             type="radio"
             name="text_format"
             value="structured-text"
-            tabindex=""
             id="cb_structuredtext"
-            tal:attributes="checked python:test(text_format=='structured-text', 1, None);
-                            tabindex tabindex;"
+            tal:attributes="checked python:test(text_format=='structured-text', 1, None);"
             />
      <label for="cb_structuredtext" i18n:translate="structured_text">Structured Text</label> <br />
 
@@ -96,10 +92,8 @@
             type="radio"
             name="text_format"
             value="html"
-            tabindex=""
             id="cb_html"
-            tal:attributes="checked python:test(text_format=='html', 1, None);
-                            tabindex tabindex;"
+            tal:attributes="checked python:test(text_format=='html', 1, None);"
             />
      <label for="cb_html" i18n:translate="html">HTML</label> <br />
 
@@ -107,10 +101,8 @@
             type="radio"
             name="text_format"
             value="plain"
-            tabindex=""
             id="cb_plain"
-            tal:attributes="checked python:test(text_format=='plain', 1, None);
-                            tabindex tabindex;"
+            tal:attributes="checked python:test(text_format=='plain', 1, None);"
             />
      <label for="cb_plain" i18n:translate="plain_text">Plain Text</label>
     </tal:nonat>

Modified: kupu/trunk/kupu/plone/zmi_toolbar.pt
==============================================================================
--- kupu/trunk/kupu/plone/zmi_toolbar.pt	(original)
+++ kupu/trunk/kupu/plone/zmi_toolbar.pt	Sat Apr 28 12:29:22 2007
@@ -88,12 +88,10 @@
         </fieldset>
 
         <input class="context"
-               tabindex=""
                type="submit"
                name="set_toolbar_filters:method"
                value="Save"
                i18n:attributes="value"
-               tal:attributes="tabindex tabindex|nothing;"
                />
       </form>
     </div>


More information about the kupu-checkins mailing list