[KSS-checkins] r55477 - in kukit/kss.core/branch/1.4: docs kss/core/pluginregistry/browser

[reebalazs at codespeak.net]

Author: reebalazs
Date: Mon Jun  2 08:25:04 2008
New Revision: 55477

Modified:
   kukit/kss.core/branch/1.4/docs/HISTORY.txt
   kukit/kss.core/branch/1.4/docs/NEWS.txt
   kukit/kss.core/branch/1.4/kss/core/pluginregistry/browser/develview.py
Log:
Add @@kss_devel_mode/needs_old_cssquery, to enable a workaround
for Safari 3.1 to work.

Modified: kukit/kss.core/branch/1.4/docs/HISTORY.txt
==============================================================================
--- kukit/kss.core/branch/1.4/docs/HISTORY.txt	(original)
+++ kukit/kss.core/branch/1.4/docs/HISTORY.txt	Mon Jun  2 08:25:04 2008
@@ -6,6 +6,10 @@
 
     - ...
    
+   - Add @@kss_devel_mode/needs_old_cssquery, to enable a workaround
+     for Safari 3.1 to work.
+     [ree]
+
    - Fix a typo that caused an exception instead of
      logging an error message, this happened when
      an action was regitered twice with the same name.

Modified: kukit/kss.core/branch/1.4/docs/NEWS.txt
==============================================================================
--- kukit/kss.core/branch/1.4/docs/NEWS.txt	(original)
+++ kukit/kss.core/branch/1.4/docs/NEWS.txt	Mon Jun  2 08:25:04 2008
@@ -1,4 +1,33 @@
 
+Known problems
+--------------
+
+Safari 3.1 fails to run with KSS. The problem is with base2,
+that fails selecting any selector that contains capital letters.
+
+Example for header of browser version that experiences the problem::
+
+    User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_2; en-us) AppleWebKit/525.13 (KHTML, like Gecko) Version/3.1 Safari/525.13
+
+
+Old cssQuery.js works for this browser, so a workaround is to ensure
+that Safari 3.1 gets the cssQuery.js resource and not the base2.
+
+For example, in ResourceRegistries, the following changes are needed:
+
+Resource: cssQuery.js
+
+- Enable
+- Change condition to: here/@@kss_devel_mode/needs_old_cssquery
+
+Resource: ++resource++base2-dom-fp.js
+
+- Change condition to: not: here/@@kss_devel_mode/needs_old_cssquery
+
+This enables the correct behaviour, since KSS always uses the
+library it founds (in the priority of base2 and the old cssquery).
+
+
 Deprecated in kss 1.4
 ---------------------
 

Modified: kukit/kss.core/branch/1.4/kss/core/pluginregistry/browser/develview.py
==============================================================================
--- kukit/kss.core/branch/1.4/kss/core/pluginregistry/browser/develview.py	(original)
+++ kukit/kss.core/branch/1.4/kss/core/pluginregistry/browser/develview.py	Mon Jun  2 08:25:04 2008
@@ -84,6 +84,19 @@
         self.request.response.expireCookie(COOKIE_DEVELMODE, path='/')
 
     # --
+    # Methods for detecting some browser versions
+    # --
+
+    def needs_old_cssquery(self):
+        user_agent = self.request.get_header('User-Agent', '')
+        safari_3_1 = 'Version/3.1' in user_agent and 'Safari' in user_agent
+        # on Safari 3_1 the current base2 is broken, this check makes
+        # it possible to serve the old cssquery instead of base2
+        # on this version.
+        # """User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_2; en-us) AppleWebKit/525.13 (KHTML, like Gecko) Version/3.1 Safari/525.13"""
+        return safari_3_1
+
+    # --
     # Methods for handling loglevel
     # --