From reebalazs at codespeak.net  Mon Jan  1 11:17:02 2007
From: reebalazs at codespeak.net (reebalazs at codespeak.net)
Date: Mon,  1 Jan 2007 11:17:02 +0100 (CET)
Subject: [KSS-checkins] r36083 - kukit/kukit.js/trunk/kukit
Message-ID: <20070101101702.456A910083@code0.codespeak.net>

Author: reebalazs
Date: Mon Jan  1 11:16:58 2007
New Revision: 36083

Modified:
   kukit/kukit.js/trunk/kukit/requestmanager.js
   kukit/kukit.js/trunk/kukit/utils.js
Log:
Put in a few ; as preparation for full compression in the future

Modified: kukit/kukit.js/trunk/kukit/requestmanager.js
==============================================================================
--- kukit/kukit.js/trunk/kukit/requestmanager.js	(original)
+++ kukit/kukit.js/trunk/kukit/requestmanager.js	Mon Jan  1 11:16:58 2007
@@ -79,7 +79,7 @@
 */
 
 kukit.rm.TimerQueue = function(callback) {
-    this.callback = callback
+    this.callback = callback;
     this.queue = new kukit.ut.SortedQueue(this._sentSort);
     this.nr = 0;
 };
@@ -202,7 +202,7 @@
 kukit.rm.RequestManager.prototype.pushWaitingRequest = function(item, now) {
     this.waitingQueue.push(item);
     // Set the timeout
-    this.checkTimeout(now)
+    this.checkTimeout(now);
 };
 
 kukit.rm.RequestManager.prototype.popWaitingRequest = function() {
@@ -225,7 +225,7 @@
     // Set the spinner state
     this.setSpinnerState(true);
     // Set the timeout
-    this.checkTimeout(now)
+    this.checkTimeout(now);
     // Wrap up the callback func. It will be called
     // with the item as first parameter.
     var self = this;

Modified: kukit/kukit.js/trunk/kukit/utils.js
==============================================================================
--- kukit/kukit.js/trunk/kukit/utils.js	(original)
+++ kukit/kukit.js/trunk/kukit/utils.js	Mon Jan  1 11:16:58 2007
@@ -115,7 +115,7 @@
                 return this.name + ': ' + this.message;
             }
         }
-        return err
+        return err;
     }
     exc.prototype.__init__ = function(name, message) {
         var kw = {};
@@ -123,7 +123,7 @@
         kw.message = message;
         return kw;
     }
-    return exc
+    return exc;
 };
 
 
@@ -171,9 +171,13 @@
 };
 
 kukit.ut.SortedQueue.prototype.comparefunc = function(a, b) {
-    if (a < b) return -1;
-    else if (a > b) return +1;
-    else return 0;
+    if (a < b) {
+        return -1;
+    } else if (a > b) {
+        return +1;
+    } else {
+        return 0;
+    }
 };
 
 kukit.ut.SortedQueue.prototype.reset = function() {
@@ -273,7 +277,7 @@
     var self = this;
     var func = function() {
         self.timeout();
-    }
+    };
     this.timer = setTimeout(func, this.delay);
 };
 
@@ -315,11 +319,11 @@
         var self = this;
         var func = function() {
             self.timeout();
-        }
+        };
         this.timer = setTimeout(func, ts - now);
     } else {
         // if in the past, run immediately
-        this.func()
+        this.func();
     }
 };
 
@@ -380,7 +384,7 @@
             kukit.log('Starting ' + item.remark);
             var ts_start = (new Date()).valueOf();
             try {
-                item.func()
+                item.func();
             } catch(e) {
                 this.lock = false;
                 throw(e);

From reebalazs at codespeak.net  Mon Jan  1 14:09:13 2007
From: reebalazs at codespeak.net (reebalazs at codespeak.net)
Date: Mon,  1 Jan 2007 14:09:13 +0100 (CET)
Subject: [KSS-checkins] r36089 - kukit/kukit.js/trunk/kukit
Message-ID: <20070101130913.C181D1007F@code0.codespeak.net>

Author: reebalazs
Date: Mon Jan  1 14:09:06 2007
New Revision: 36089

Modified:
   kukit/kukit.js/trunk/kukit/commandreg.js
   kukit/kukit.js/trunk/kukit/dom.js
   kukit/kukit.js/trunk/kukit/eventreg.js
   kukit/kukit.js/trunk/kukit/kssparser.js
   kukit/kukit.js/trunk/kukit/kukit.js
   kukit/kukit.js/trunk/kukit/plugin.js
   kukit/kukit.js/trunk/kukit/requestmanager.js
   kukit/kukit.js/trunk/kukit/resourcedata.js
   kukit/kukit.js/trunk/kukit/tokenizer.js
   kukit/kukit.js/trunk/kukit/utils.js
Log:
make changes to enable full compression.

Most of this will not be necessary with the enhanced parser though.

workarounds:
- missing semicolons
- don't use _SARISSA...
- /* */ in strings escaped

Modified: kukit/kukit.js/trunk/kukit/commandreg.js
==============================================================================
--- kukit/kukit.js/trunk/kukit/commandreg.js	(original)
+++ kukit/kukit.js/trunk/kukit/commandreg.js	Mon Jan  1 14:09:06 2007
@@ -48,7 +48,7 @@
     // register a given action as a command, using the given vactor
     var f = kukit.ar.actionRegistry.get(srcname);
     factory(name, f);
-}
+};
 
 kukit.cr.CommandRegistry.prototype.register = function(name, klass) {
     if (this.content[name]) {
@@ -81,7 +81,7 @@
     command.parms = parms;
     command.transport = transport;
     return command;
-}
+};
 
 kukit.cr._Command_execute = function(oper) {
     var newoper = oper.clone({

Modified: kukit/kukit.js/trunk/kukit/dom.js
==============================================================================
--- kukit/kukit.js/trunk/kukit/dom.js	(original)
+++ kukit/kukit.js/trunk/kukit/dom.js	Mon Jan  1 14:09:06 2007
@@ -38,13 +38,13 @@
         toNode = toNode.nextSibling;
     }
     return toNode;
-}
+};
 
 kukit.dom.insertBefore = function(nodeFrom, parentNode, nodeTo) {
     var ownerDoc = nodeTo.nodeType == Node.DOCUMENT_NODE ? nodeTo : nodeTo.ownerDocument;
     var nodes = nodeFrom.childNodes;
     var result = new Array();
-    if(ownerDoc.importNode && (!_SARISSA_IS_IE)) {
+    if(ownerDoc.importNode && (!kukit.HAVE_IE)) {
         for(var i=0;i < nodes.length;i++) {
             result[i] = parentNode.insertBefore(ownerDoc.importNode(nodes[i], true), nodeTo);
         }
@@ -59,7 +59,7 @@
 kukit.dom.appendChildren = function(nodes, toNode) {
     var ownerDoc = toNode.nodeType == Node.DOCUMENT_NODE ? toNode : toNode.ownerDocument;
     var result = new Array();
-    if(ownerDoc.importNode && (!_SARISSA_IS_IE)) {
+    if(ownerDoc.importNode && (!kukit.HAVE_IE)) {
         for(var i=0;i < nodes.length;i++) {
             result[i] = toNode.appendChild(ownerDoc.importNode(nodes[i], true));
         }
@@ -302,7 +302,7 @@
     //this.counter.timeout();
     // XXX can't execute immediately, it fails on IE.
     this.counter.start();
-}
+};
 
 // From http://xkr.us/articles/dom/iframe-document/
 // Note it's not necessary for the iframe to have the name
@@ -314,7 +314,7 @@
         doc = doc.document;
     }
     return doc
-}
+};
 
 kukit.dom.EmbeddedContentLoadedScheduler.prototype.check = function() {
     // quit if the init function has already been called

Modified: kukit/kukit.js/trunk/kukit/eventreg.js
==============================================================================
--- kukit/kukit.js/trunk/kukit/eventreg.js	(original)
+++ kukit/kukit.js/trunk/kukit/eventreg.js	Mon Jan  1 14:09:06 2007
@@ -120,7 +120,7 @@
         throw 'In EventRegistry.register namespace cannot contain -';
     }
     return namespace + '-' + eventname;
-}
+};
 
 kukit.er.EventRegistry.prototype.exists = function(namespace, eventname) {
     var key = this._getKey(namespace, eventname);
@@ -165,7 +165,7 @@
         oper.binderinstance = this;
         method.call(this, name, oper);
     }
-}
+};
 
 /* This can be called on the event and will execute the
 *  desired event action. Parameters will be these + those
@@ -219,7 +219,7 @@
         special += 1;
     }
     kukit.logDebug('Event "' + name + '" executed on ' + executed + ' nodes, ' + special + ' special kss targets.');
-}
+};
 
 kukit.er.EventBinder_triggerevent = function(name, oper) {
     // Private. Called from __trigger_event__ or from main event execution.
@@ -232,7 +232,7 @@
         // In case there is no event rule, just call the default event action.
         // This is programmatic calling.
         var namespace = this.__event_namespace__;
-        kukit.logDebug('Calling implicit event "' + name + '" on namespace "' + namespace + '"')
+        kukit.logDebug('Calling implicit event "' + name + '" on namespace "' + namespace + '"');
         this._EventBinder_calldefault(namespace, name, oper);
     }
 };

Modified: kukit/kukit.js/trunk/kukit/kssparser.js
==============================================================================
--- kukit/kukit.js/trunk/kukit/kssparser.js	(original)
+++ kukit/kukit.js/trunk/kukit/kssparser.js	Mon Jan  1 14:09:06 2007
@@ -25,8 +25,8 @@
 
 /* Tokens */
 
-kukit.kssp.commentbegin = kukit.tk.mkToken('commentbegin', "/*");
-kukit.kssp.commentend = kukit.tk.mkToken('commentend', "*/");
+kukit.kssp.commentbegin = kukit.tk.mkToken('commentbegin', "\/\*");
+kukit.kssp.commentend = kukit.tk.mkToken('commentend', "\*\/");
 kukit.kssp.openbrace = kukit.tk.mkToken('openbrace', "{");
 kukit.kssp.closebrace = kukit.tk.mkToken('closebrace', "}");
 kukit.kssp.openbracket = kukit.tk.mkToken('openbracket', "[");
@@ -44,7 +44,7 @@
 /* Parsers */
 
 kukit.kssp.document = kukit.tk.mkParser('document', {
-    "/*": 'new kukit.kssp.comment(this.src, kukit.kssp.commentbegin)',
+    "\/\*": 'new kukit.kssp.comment(this.src, kukit.kssp.commentbegin)',
     "{": 'new kukit.kssp.block(this.src, kukit.kssp.openbrace)'
     });
 kukit.kssp.document.prototype.process = function() {
@@ -78,7 +78,7 @@
 
 // it's not 100% good, but will do
 kukit.kssp.comment = kukit.tk.mkParser('comment', {
-    "*/": 'this.emitAndReturn(new kukit.kssp.commentend(this.src))'
+    "\*\/": 'this.emitAndReturn(new kukit.kssp.commentend(this.src))'
     });
 kukit.kssp.comment.prototype.process = function() {
     this.result = [];
@@ -210,7 +210,7 @@
     ",": 'this.emitAndReturn()',
     "'": 'new kukit.kssp.string(this.src, kukit.kssp.quote)',
     '"': 'new kukit.kssp.string2(this.src, kukit.kssp.dquote)',
-    "/*": 'new kukit.kssp.comment(this.src, kukit.kssp.commentbegin)',
+    "\/\*": 'new kukit.kssp.comment(this.src, kukit.kssp.commentbegin)',
     "(": 'new kukit.kssp.methodargs(this.src, kukit.kssp.openparent)'
     });
 kukit.kssp.propvalue.prototype.process = function() {
@@ -264,7 +264,7 @@
 kukit.kssp.propvalue.prototype.produceTxt = function(txt) {
     // txt parms are returned embedded
     this.value = new kukit.rd.KssTextValue(txt);
-}
+};
 
 // propvalue in method cannot contain method-style vars.
 kukit.kssp.propvalue_in_method = kukit.tk.mkParser('propvalue', {
@@ -275,7 +275,7 @@
     ",": 'this.emitAndReturn()',
     "'": 'new kukit.kssp.string(this.src, kukit.kssp.quote)',
     '"': 'new kukit.kssp.string2(this.src, kukit.kssp.dquote)',
-    "/*": 'new kukit.kssp.comment(this.src, kukit.kssp.commentbegin)'  //,
+    "\/\*": 'new kukit.kssp.comment(this.src, kukit.kssp.commentbegin)'  //,
     });
 kukit.kssp.propvalue_in_method.prototype.multiword_allowed = false;
 kukit.kssp.propvalue_in_method.prototype.process = kukit.kssp.propvalue.prototype.process;
@@ -291,7 +291,7 @@
     "\t": 'this.emitAndReturn()',
     "\n": 'this.emitAndReturn()',
     "\r": 'this.emitAndReturn()',
-    "/*": 'this.emitAndReturn()',
+    "\/\*": 'this.emitAndReturn()',
     ":": 'this.emitAndReturn()',
     "(": 'this.emitAndReturn(new kukit.kssp.methodargs(this.src, kukit.kssp.openparent))'
     });
@@ -301,7 +301,7 @@
 kukit.kssp.propvalue_in_pseudo.prototype.produceTxt = function(txt) {
     // txt parms are returned embedded
     this.value = new kukit.rd.KssPseudoValue(txt, []);
-}
+};
 
 kukit.kssp.string = kukit.tk.mkParser('string', {
     "'": 'this.emitAndReturn(new kukit.kssp.quote(this.src))',
@@ -345,7 +345,7 @@
     '"': 'new kukit.kssp.string2(this.src, kukit.kssp.dquote)',
     ",": 'new kukit.kssp.comma(this.src)',
     ")": 'this.emitAndReturn(new kukit.kssp.closeparent(this.src))',
-    "/*": 'new kukit.kssp.comment(this.src, kukit.kssp.commentbegin)'
+    "\/\*": 'new kukit.kssp.comment(this.src, kukit.kssp.commentbegin)'
     });
 kukit.kssp.methodargs.prototype.process = function() {
     this.args = [];
@@ -381,7 +381,7 @@
 kukit.kssp.kssselector = kukit.tk.mkParser('kssselector', {
     ":": '[new kukit.kssp.colon(this.src), new kukit.kssp.propvalue_in_pseudo(this.src)]',
     "{": 'this.emitAndReturn()',
-    "/*": 'new kukit.kssp.comment(this.src, kukit.kssp.commentbegin)'
+    "\/\*": 'new kukit.kssp.comment(this.src, kukit.kssp.commentbegin)'
     });
 kukit.kssp.kssselector.prototype.process = function() {
     var name;

Modified: kukit/kukit.js/trunk/kukit/kukit.js
==============================================================================
--- kukit/kukit.js/trunk/kukit/kukit.js	(original)
+++ kukit/kukit.js/trunk/kukit/kukit.js	Mon Jan  1 14:09:06 2007
@@ -271,10 +271,9 @@
 };
 
 kukit.notifyServer_done = function(domDoc, oper) {
-    if (domDoc.readyState == 4)
-    {
+    if (domDoc.readyState == 4) {
         // notify the queue that we are done
-        var success = oper.queueItem.receivedResult()
+        var success = oper.queueItem.receivedResult();
         // We only process if the response has not been timed
         // out by the queue in the meantime.
         if (success) {

Modified: kukit/kukit.js/trunk/kukit/plugin.js
==============================================================================
--- kukit/kukit.js/trunk/kukit/plugin.js	(original)
+++ kukit/kukit.js/trunk/kukit/plugin.js	Mon Jan  1 14:09:06 2007
@@ -255,7 +255,7 @@
         // We want the event execute once the iframe is loaded.
         var f = function() {
             kukit.bindScheduler.addPost(func_to_bind, 'Execute load event for iframe ' + oper.node.name);
-        }
+        };
         new kukit.dom.EmbeddedContentLoadedScheduler(oper.node.id, f);
 
     } else {
@@ -275,7 +275,7 @@
     var self = this;
     var timeoutSetState = function(spinnerevent) {
        self.timeoutSetState(spinnerevent);
-    }
+    };
     this.scheduler = new kukit.ut.Scheduler(timeoutSetState);
 };
 

Modified: kukit/kukit.js/trunk/kukit/requestmanager.js
==============================================================================
--- kukit/kukit.js/trunk/kukit/requestmanager.js	(original)
+++ kukit/kukit.js/trunk/kukit/requestmanager.js	Mon Jan  1 14:09:06 2007
@@ -89,7 +89,7 @@
     if (a.expire < b.expire) return -1;
     else if (a.expire > b.expire) return +1;
     else return 0;
-}
+};
 
 kukit.rm.TimerQueue.prototype.push = function(item) {
     // push a given slot
@@ -148,7 +148,7 @@
     var self = this;
     var timeoutItem = function(item) {
        self.timeoutItem(item);
-    }
+    };
     this.timerQueue = new kukit.rm.TimerQueue(timeoutItem);
     if (typeof(name) == 'undefined') {
         name = null;
@@ -165,7 +165,7 @@
     // sets the timeout scheduler
     var checkTimeout = function() {
        self.checkTimeout();
-    }
+    };
     if (typeof(schedulerClass) == 'undefined') {
         schedulerClass = kukit.ut.Scheduler;
     }
@@ -231,7 +231,7 @@
     var self = this;
     var func = function(item, now) {
         return self.receiveItem(item, now);
-    }
+    };
     item.setReceivedCallback(func);
     // Call the function
     item.sendHook(item);

Modified: kukit/kukit.js/trunk/kukit/resourcedata.js
==============================================================================
--- kukit/kukit.js/trunk/kukit/resourcedata.js	(original)
+++ kukit/kukit.js/trunk/kukit/resourcedata.js	Mon Jan  1 14:09:06 2007
@@ -350,7 +350,7 @@
 */
 
 kukit.rd.EventRule.prototype.bind = function(node) {
-    var oper = new kukit.op.Oper()
+    var oper = new kukit.op.Oper();
     oper.node = node;
     oper.binderinstance = this.getBinderInstance();
     oper.eventrule = this;
@@ -371,7 +371,7 @@
         newoper.binderinstance._EventBinder_triggerevent(name, newoper);
     };
     // do the binding    
-    var bindoper = new kukit.op.Oper()
+    var bindoper = new kukit.op.Oper();
     bindoper.node = node;
     bindoper.binderinstance = oper.binderinstance;
     bindoper.eventrule = this;
@@ -538,7 +538,7 @@
     this.error = null;
     this.parms = {};
     this.type = null;
-}
+};
 
 kukit.rd.Action.prototype.setName = function(name) {
     if (this.name != null && this.name != name) {

Modified: kukit/kukit.js/trunk/kukit/tokenizer.js
==============================================================================
--- kukit/kukit.js/trunk/kukit/tokenizer.js	(original)
+++ kukit/kukit.js/trunk/kukit/tokenizer.js	Mon Jan  1 14:09:06 2007
@@ -28,7 +28,7 @@
     var kw = this.__superinit__(name, message);
     kw.errpos = errpos;
     kw.message = kw.message + ' at position ' + errpos;
-    return kw
+    return kw;
 };
 
 /* Class methods of tokens and parsers */
@@ -195,7 +195,7 @@
         }
         this.endpos = src.pos;
         this.src = null;
-    }
+    };
     f.prototype = new kukit.tk._TokenBase;
     f.prototype.symbol = symbol;
     f.prototype.txt = txt;
@@ -222,7 +222,7 @@
         // post processing
         this.process();
         this.src = null;
-    }
+    };
     f.prototype = new kukit.tk._ParserBase;
     f.prototype.symbol = symbol;
     return f;

Modified: kukit/kukit.js/trunk/kukit/utils.js
==============================================================================
--- kukit/kukit.js/trunk/kukit/utils.js	(original)
+++ kukit/kukit.js/trunk/kukit/utils.js	Mon Jan  1 14:09:06 2007
@@ -29,6 +29,9 @@
 // Browser identification. We need this one only atm.
 try {
     kukit.HAVE_SAFARI = navigator.vendor && navigator.vendor.indexOf('Apple') != -1;
+    // this one is taken from sarissa. Howewer we can't reuse it since it starts with _.
+    kukit.HAVE_IE = document.all && window.ActiveXObject && navigator.userAgent.toLowerCase().indexOf("msie") > -1  && navigator.userAgent.toLowerCase().indexOf("opera") == -1;
+
 } catch (e) {}
 
 /* check whether the logging stuff of Firebug is available */
@@ -116,13 +119,13 @@
             }
         }
         return err;
-    }
+    };
     exc.prototype.__init__ = function(name, message) {
         var kw = {};
         kw.name = name;
         kw.message = message;
         return kw;
-    }
+    };
     return exc;
 };
 

From reebalazs at codespeak.net  Mon Jan  1 23:40:08 2007
From: reebalazs at codespeak.net (reebalazs at codespeak.net)
Date: Mon,  1 Jan 2007 23:40:08 +0100 (CET)
Subject: [KSS-checkins] r36099 - kukit/kukit.js/trunk/kukit
Message-ID: <20070101224008.43B8F10071@code0.codespeak.net>

Author: reebalazs
Date: Mon Jan  1 23:40:04 2007
New Revision: 36099

Modified:
   kukit/kukit.js/trunk/kukit/utils.js
Log:
Again, use HAVE_IE as provided by Sarissa.

Modified: kukit/kukit.js/trunk/kukit/utils.js
==============================================================================
--- kukit/kukit.js/trunk/kukit/utils.js	(original)
+++ kukit/kukit.js/trunk/kukit/utils.js	Mon Jan  1 23:40:04 2007
@@ -29,9 +29,7 @@
 // Browser identification. We need this one only atm.
 try {
     kukit.HAVE_SAFARI = navigator.vendor && navigator.vendor.indexOf('Apple') != -1;
-    // this one is taken from sarissa. Howewer we can't reuse it since it starts with _.
-    kukit.HAVE_IE = document.all && window.ActiveXObject && navigator.userAgent.toLowerCase().indexOf("msie") > -1  && navigator.userAgent.toLowerCase().indexOf("opera") == -1;
-
+    kukit.HAVE_IE =  eval("_SARISSA_IS_IE");
 } catch (e) {}
 
 /* check whether the logging stuff of Firebug is available */

From reebalazs at codespeak.net  Thu Jan  4 14:50:47 2007
From: reebalazs at codespeak.net (reebalazs at codespeak.net)
Date: Thu,  4 Jan 2007 14:50:47 +0100 (CET)
Subject: [KSS-checkins] r36148 - kukit/kukit.js/branch/ree-events-cleanup
Message-ID: <20070104135047.E308E10070@code0.codespeak.net>

Author: reebalazs
Date: Thu Jan  4 14:50:42 2007
New Revision: 36148

Added:
   kukit/kukit.js/branch/ree-events-cleanup/
      - copied from r36147, kukit/kukit.js/trunk/
Log:
Branch off

From reebalazs at codespeak.net  Thu Jan  4 17:36:07 2007
From: reebalazs at codespeak.net (reebalazs at codespeak.net)
Date: Thu,  4 Jan 2007 17:36:07 +0100 (CET)
Subject: [KSS-checkins] r36152 - kukit/kss.core/branch/ree-events-cleanup
Message-ID: <20070104163607.D709910074@code0.codespeak.net>

Author: reebalazs
Date: Thu Jan  4 17:36:03 2007
New Revision: 36152

Added:
   kukit/kss.core/branch/ree-events-cleanup/
      - copied from r36151, kukit/kss.core/trunk/
Log:
Branch off

From reebalazs at codespeak.net  Thu Jan  4 17:37:17 2007
From: reebalazs at codespeak.net (reebalazs at codespeak.net)
Date: Thu,  4 Jan 2007 17:37:17 +0100 (CET)
Subject: [KSS-checkins] r36153 - kukit/kss.core/branch/ree-events-cleanup
Message-ID: <20070104163717.232D010074@code0.codespeak.net>

Author: reebalazs
Date: Thu Jan  4 17:37:12 2007
New Revision: 36153

Modified:
   kukit/kss.core/branch/ree-events-cleanup/   (props changed)
   kukit/kss.core/branch/ree-events-cleanup/EXTERNALS.TXT
Log:
Branch off

Modified: kukit/kss.core/branch/ree-events-cleanup/EXTERNALS.TXT
==============================================================================
--- kukit/kss.core/branch/ree-events-cleanup/EXTERNALS.TXT	(original)
+++ kukit/kss.core/branch/ree-events-cleanup/EXTERNALS.TXT	Thu Jan  4 17:37:12 2007
@@ -5,4 +5,4 @@
 # You can update your working dir by: 
 #     svn propset svn:externals -F EXTERNALS.TXT .
 #
-kukit http://codespeak.net/svn/kukit/kukit.js/trunk
+kukit http://codespeak.net/svn/kukit/kukit.js/branch/ree-events-cleanup

From reebalazs at codespeak.net  Thu Jan  4 17:38:49 2007
From: reebalazs at codespeak.net (reebalazs at codespeak.net)
Date: Thu,  4 Jan 2007 17:38:49 +0100 (CET)
Subject: [KSS-checkins] r36154 - kukit/kss.demo/branch/ree-event-cleanup
Message-ID: <20070104163849.D9CFD10074@code0.codespeak.net>

Author: reebalazs
Date: Thu Jan  4 17:38:44 2007
New Revision: 36154

Added:
   kukit/kss.demo/branch/ree-event-cleanup/
      - copied from r36153, kukit/kss.demo/trunk/
Log:
Branch off

From reebalazs at codespeak.net  Fri Jan  5 10:12:14 2007
From: reebalazs at codespeak.net (reebalazs at codespeak.net)
Date: Fri,  5 Jan 2007 10:12:14 +0100 (CET)
Subject: [KSS-checkins] r36160 -
	kukit/kukit.js/branch/ree-events-cleanup/kukit
Message-ID: <20070105091214.2F1C610071@code0.codespeak.net>

Author: reebalazs
Date: Fri Jan  5 10:12:10 2007
New Revision: 36160

Modified:
   kukit/kukit.js/branch/ree-events-cleanup/kukit/eventreg.js
   kukit/kukit.js/branch/ree-events-cleanup/kukit/oper.js
   kukit/kukit.js/branch/ree-events-cleanup/kukit/plugin.js
   kukit/kukit.js/branch/ree-events-cleanup/kukit/resourcedata.js
Log:
Clean up programmatic event triggering.

Method for event continuation is provided, this atm supports both
existing usecases (annoyclicker + livesearch)

Modified: kukit/kukit.js/branch/ree-events-cleanup/kukit/eventreg.js
==============================================================================
--- kukit/kukit.js/branch/ree-events-cleanup/kukit/eventreg.js	(original)
+++ kukit/kukit.js/branch/ree-events-cleanup/kukit/eventreg.js	Fri Jan  5 10:12:10 2007
@@ -152,95 +152,162 @@
 *
 */
 
-kukit.er.EventBinder_calldefault = function(namespace, name, oper) {
-    // private method for calling just a default method.
-    // params should be alredy prepared.
-    var methodname = kukit.er.eventRegistry.get(namespace, name).defaultactionmethodname;
-    if (methodname) {
-        var method = this[methodname];
-        if (! method) {
-            throw 'Could not bind event name "' + name + '" on namespace "' + namespace + '", because the method "' + methodname + '" does not exist.';
-            }
-        // call it
-        oper.binderinstance = this;
-        method.call(this, name, oper);
-    }
-};
-
-/* This can be called on the event and will execute the
-*  desired event action. Parameters will be these + those
-*  defined in the rule.
+/* Provide callins on the state instance that execute a given
+*  continuation event.
+*  Parameters will be the ones specified in the call + 
+*  those defined in the rule will be added too. (Parameters can
+*  be accessed with the "pass" kss parameter provider.)
+*
+* Call examples: 
+*
+* trigger an event bound to a given state instance, same node
+*
+*     binderinstance.__continue_event__('doit', oper.node, {'extravalue': '5'});
+*
+*   with kss rule:
+*
+*     node.selector:doit {
+*         action-client: log;
+*         log-message: pass(extravalue);
+*     }
+*
+*  or
+*
+*     behaviour.selector:doit {
+*         action-client: log;
+*         log-message: pass(extravalue);
+*     }
+*
+* trigger an event bound to a given state instance, and the document
+* (different from current scope)
+*
+*     binderinstance.__continue_event__('doit', null, {'extravalue': '5'});
+*
+*   with kss rule:
+*
+*     document:doit {
+*         action-client: log;
+*         log-message: pass(extravalue);
+*     }
+*
+*  or
+*
+*     behaviour.selector:doit {
+*         action-client: log;
+*         log-message: pass(extravalue);
+*     }
+*
+* trigger an event on all the nodes + document bound to a given state instance
+*
+*     binderinstance.__continue_event_allnodes__('doit', {'extravalue': '5'});
 *
-* Call example: binderinstance.__trigger_event__('doit', {'extravalue': '5'}, node);
+*   with kss rule:
+*
+*     node.selector:doit {
+*         action-client: log;
+*         log-message: pass(extravalue);
+*     }
+*
+* p.s. oper is not required to make it easy to adapt existing code
+* so we create a new oper below
 */
 
-kukit.er.EventBinder__trigger_event__ = function(name, parms, node) {
-    // Called programmatically
+kukit.er.EventBinder__continue_event__ = function(name, node, parms) {
+    // Trigger a continuation event bound to a given state instance, given node
+    // (or on document, if node = null)
     //
-    // XXX uhh this must go away. An implicit kss rule is only to be executed
-    // if no other nodes execute.
-    var executed = 0;
-    var special = 0;
-    // document rules. Execute them with node = null
-    eventrule =  kukit.rd.methodTable.getMergedRule('document', name, this);
-    if (eventrule != null) {
-        var oper = new kukit.op.Oper();
+    var eventrule;
+    var oper = new kukit.op.Oper();
+    if (node) {
+        eventrule = oper.getBindingForNode(this, name, node);
+    } else {
+        eventrule =  kukit.rd.methodTable.getMergedRule('document', name, this);
+    }
+    // Look up the behaviour rule, if any.
+    var behav_eventrule =  kukit.rd.methodTable.getMergedRule('behaviour', name, this);
+    if (behav_eventrule) {
+        if (! eventrule) {
+            // There was no node matching for the rule, use behaviour rule
+            // this allows to set up parametrized actions in general.
+            eventrule = behav_eventrule;
+        } else {
+            kukit.logDebug('Behaviour rule for continuation event "' + name + '" will be ignored, because we found an explicit rule.');
+        }
+    }
+    // (if eventrule is null here, we can yet have the default method, so go on.)
+    oper.eventrule = eventrule;
+    oper.node = node;
+    if (typeof(parms) != 'undefined') {
         oper.parms = parms;
-        oper.eventrule = eventrule;
-        // node is null.
-        this._EventBinder_triggerevent(name, oper);
-        special += 1;
+    } else {
+        oper.parms = {};
     }
+    this._EventBinder_triggerevent(name, oper);
+    kukit.logDebug('Continuation event "' + name + '" executed on same node.');
+};
+
+kukit.er.EventBinder__continue_event_allnodes__ = function(name, parms) {
+    // Trigger an event bound to a given state instance, on all nodes.
+    // (or on document, if node = null)
+    // if no other nodes execute.
+    var executed = 0;
     // Normal rules. If any of those match, execute them too
     // each on the node that it selects - not on the original node.
-    var opers = kukit.er.binderInstanceRegistry.getBinding(this, name);
+    var oper = new kukit.op.Oper();
+    var opers = oper.getBinding(this, name);
     for (var i=0; i<opers.length; i++) {
         var oper = opers[i];
-        var newoper = new kukit.op.Oper();
-        newoper.parms = parms;
-        newoper.node = oper.node;
-        newoper.eventrule = oper.eventrule;
+        var newoper = oper.clone();
+        if (typeof(parms) != 'undefined') {
+            newoper.parms = parms;
+        } else {
+            newoper.parms = {};
+        }
         this._EventBinder_triggerevent(name, newoper);
         executed += 1;
     }
-    // look up the behaviour event rule. This may fail (eventrule = null)
-    // but yet we want to execute a default action in this case.
-    var eventrule =  kukit.rd.methodTable.getMergedRule('behaviour', name, this);
-    // XXX uhh this must go away. If we have no eventrule, we must remember
-    // it and execute but only if otherwise not bound (this is an implicit
-    if (eventrule != null || executed + special == 0) {
-        // behaviour method is executed on the old node
-        // XXX bad, very bad
-        var oper = new kukit.op.Oper();
-        oper.parms = parms;
-        oper.node = node;
-        oper.eventrule = eventrule;
-        this._EventBinder_triggerevent(name, oper);
-        special += 1;
-    }
-    kukit.logDebug('Event "' + name + '" executed on ' + executed + ' nodes, ' + special + ' special kss targets.');
+    kukit.logDebug('Event "' + name + '" executed on ' + executed + ' nodes.');
 };
 
 kukit.er.EventBinder_triggerevent = function(name, oper) {
-    // Private. Called from __trigger_event__ or from main event execution.
+    // Private. Called from __continue_event__ or from main event execution.
+    oper.binderinstance = this;
     if (oper.eventrule) {
         // Call the actions, if we had an event rule.
         // This includes calling the default action.
-        oper.binderinstance = this;
         oper.eventrule.actions.execute(oper);
     } else {
         // In case there is no event rule, just call the default event action.
-        // This is programmatic calling.
         var namespace = this.__event_namespace__;
         kukit.logDebug('Calling implicit event "' + name + '" on namespace "' + namespace + '"');
-        this._EventBinder_calldefault(namespace, name, oper);
+        var success = oper.executeDefaultAction(name, true);
+        if (! success) {
+            // instead of the standard message give more specific reason:
+            // either way we should have executed something...
+            throw 'Could not trigger event name "' + name + '" on namespace "' + namespace + '", because there is neither an explicit kss rule, nor a default method';
+        }
     }
 };
 
+/* (default) method call handling */
+
+kukit.er.EventBinder_callmethod = function(namespace, name, oper, methodname) {
+    // hidden method for calling just a method and checking that is exists.
+    // (called from oper)
+    var method = this[methodname];
+    if (! method) {
+        throw 'Could not trigger event name "' + name + '" on namespace "' + namespace + '", because the method "' + methodname + '" does not exist.';
+    }
+    // call it
+    oper.binderinstance = this;
+    method.call(this, name, oper);
+};
+
 kukit.er.decorateEventBinderClass = function(cls) {
-    cls.prototype.__trigger_event__ = kukit.er.EventBinder__trigger_event__;
+    cls.prototype.__continue_event__ = kukit.er.EventBinder__continue_event__;
+    cls.prototype.__continue_event_allnodes__ = kukit.er.EventBinder__continue_event_allnodes__;
     cls.prototype._EventBinder_triggerevent = kukit.er.EventBinder_triggerevent;
-    cls.prototype._EventBinder_calldefault = kukit.er.EventBinder_calldefault;
+    cls.prototype._EventBinder_callmethod = kukit.er.EventBinder_callmethod;
 };
 
 /* Event instance registry 
@@ -264,7 +331,7 @@
         binderinstance.__binder_id__ = id;
         binderinstance.__binder_classname__ = classname;
         binderinstance.__event_namespace__ = namespace;
-        binderinstance.__event_rules__ = [];
+        binderinstance.__bound_rules__ = [];
     } else if (binderinstance.__binder_classname__ != classname) {
         // just paranoia
         throw 'Conflicting class for event id "' + id + '", "' + binderinstance.__binder_classname__
@@ -273,28 +340,6 @@
     return binderinstance;
 };
 
-kukit.er.BinderInstanceRegistry.prototype.markBinding = function (oper) {
-    // Marks that the instance was bound to this rule
-    var name = oper.eventrule.kss_selector.name;
-    rules_already_bound = oper.binderinstance.__event_rules__[name];
-    if (typeof(rules_already_bound) == 'undefined') {
-        // Create an empty list.
-        rules_already_bound = oper.binderinstance.__event_rules__[name] = [];
-    }
-    rules_already_bound.push(oper);
-};
-
-kukit.er.BinderInstanceRegistry.prototype.getBinding = function (binderinstance, name) {
-    // Get the eventrule, node items that bind to the instance with an event name
-    var opers = binderinstance.__event_rules__[name];
-    if (typeof(opers) == 'undefined') {
-        // Create an empty list.
-        opers = binderinstance.__event_rules__[name] = [];
-    }
-    // Return it
-    return opers;
-};
-
 kukit.er.BinderInstanceRegistry.prototype.getBinderById = function (id) {
     // Get an event.
     var binderinstance = this.content[id];

Modified: kukit/kukit.js/branch/ree-events-cleanup/kukit/oper.js
==============================================================================
--- kukit/kukit.js/branch/ree-events-cleanup/kukit/oper.js	(original)
+++ kukit/kukit.js/branch/ree-events-cleanup/kukit/oper.js	Fri Jan  5 10:12:10 2007
@@ -112,12 +112,73 @@
     func(this);
 };
 
+kukit.op.Oper.prototype.executeDefaultAction = function(name, optional) {
+    var namespace = this.binderinstance.__event_namespace__;
+    var methodname = kukit.er.eventRegistry.get(namespace, name).defaultactionmethodname;
+    var success = false;
+    if (! methodname) {
+        if (! optional) {
+            throw 'Could not trigger event name "' + name + '" on namespace "' + namespace + '", because this event has no default method.';
+        }
+    } else {
+        this.binderinstance._EventBinder_callmethod(namespace, name, this, methodname);
+        success = true;
+    }
+    return success;
+};
+
 kukit.op.Oper.prototype.executeServerAction = function(name) {
     var action = kukit.calculateAbsoluteURL(name);
     // oper will be accessible to some commands that execute in return
     kukit.notifyServer(action, this.parms, this);
 };
 
+/* Instance-binding registry */
+
+kukit.op.Oper.prototype.markBinding = function () {
+    // Marks that the instance was bound to this rule
+    var name = this.eventrule.kss_selector.name;
+    var nodehash = kukit.rd.hashnode(this.node);
+    rules_per_name = this.binderinstance.__bound_rules__[name];
+    if (typeof(rules_per_name) == 'undefined') {
+        // Create an empty list.
+        rules_per_name = this.binderinstance.__bound_rules__[name] = {};
+    } else if (typeof(rules_per_name[nodehash]) != 'undefined') {
+        throw 'Mismatch in bind registry, ' + name + ' already bound to node.'; 
+    }
+    rules_per_name[nodehash] = this;
+};
+
+kukit.op.Oper.prototype.getBindingForNode = function (binderinstance, name, node) {
+    // Get the oper that is bound to a given event to a node in this instance
+    // returns null, if there is no such oper.
+    var rules_per_name = binderinstance.__bound_rules__[name];
+    if (typeof(rules_per_name) == 'undefined') {
+        return null;
+    }
+    var nodehash = kukit.rd.hashnode(this.node);
+    var oper = rules_per_name[nodehash];
+    if (typeof(oper) == 'undefined') {
+        return null;
+    }
+    // Return it
+    return oper;
+};
+
+kukit.op.Oper.prototype.getBinding = function (binderinstance, name) {
+    // Get the opers bound to a given event (to any node) in this instance
+    var opers = [];
+    var rules_per_name = binderinstance.__bound_rules__[name];
+    if (typeof(rules_per_name) != 'undefined') {
+        // take the values as a list
+        for (var nodehash in rules_per_name) {
+            opers.push(rules_per_name[nodehash]);
+        }
+    }
+    // Return it
+    return opers;
+};
+
 /* Utility for parameter checking */
 
 kukit.op.Oper.prototype.completeParms = function(mandatory, defaults, errname, allow_excess) {

Modified: kukit/kukit.js/branch/ree-events-cleanup/kukit/plugin.js
==============================================================================
--- kukit/kukit.js/branch/ree-events-cleanup/kukit/plugin.js	(original)
+++ kukit/kukit.js/branch/ree-events-cleanup/kukit/plugin.js	Fri Jan  5 10:12:10 2007
@@ -554,34 +554,29 @@
 });
 kukit.cr.commandRegistry.registerFromAction('setStateVar', kukit.cr.makeGlobalCommand);
 
-kukit.ar.actionRegistry.register('triggerEvent', function(oper) {
+kukit.ar.actionRegistry.register('continueEvent', function(oper) {
+    // Trigger continuation event. Event will be triggered on the same node or
+    // on all the nodes bound for the current event state.
     // allows excess parms in the following check.
-    oper.completeParms(['name'], {'id': null, 'namespace': null}, 'triggerEvent action', true);
+    oper.completeParms(['name'], {'allnodes': 'false'}, 'continueEvent action', true);
+    oper.evalBool('allnodes', 'continueEvent');
     var parms = oper.parms;
     var binderinstance = oper.binderinstance;
-    if (parms.id) {
-        // by id
-        binderinstance = kukit.er.binderInstanceRegistry.getBinderById(parms.id);
-        // if namespace is defined too, let's check it!
-        if (parms.namespace != null && parms.namespace != binderinstance.__event_namespace__) {
-            throw 'Id and namespace are conflicting in triggerEvent action, rule=#' + oper.eventrule.getNr() + ', node=' + oper.node.nodeName; 
-        }
-    } else {
-        if (binderinstance == null) {
-            // singleton by class
-            binderinstance = kukit.er.binderInstanceRegistry.getSingletonBinderByName(parms.namespace, parms.name);
-        }
-    }
+    var allnodes = parms.allnodes;
     // marshall it, the rest of the parms will be passed
     var actionparms = {};
     for (var key in parms) {
-        if (key != 'name' && key != 'id' && key != 'namespace') {
+        if (key != 'name' && key != 'allnodes') {
             actionparms[key] = parms[key];
         }
     }
-    binderinstance.__trigger_event__(parms.name, actionparms, oper.node);
+    if (parms.allnodes) {
+        binderinstance.__continue_event_allnodes__(parms.name, actionparms);
+    } else {
+        binderinstance.__continue_event__(parms.name, oper.node, actionparms);
+    }
 });
-kukit.cr.commandRegistry.registerFromAction('triggerEvent', kukit.cr.makeGlobalCommand);
+kukit.cr.commandRegistry.registerFromAction('continueEvent', kukit.cr.makeGlobalCommand);
 
 kukit.ar.actionRegistry.register('executeCommand', function(oper) {
     // Allows executing a local action on a different selection.

Modified: kukit/kukit.js/branch/ree-events-cleanup/kukit/resourcedata.js
==============================================================================
--- kukit/kukit.js/branch/ree-events-cleanup/kukit/resourcedata.js	(original)
+++ kukit/kukit.js/branch/ree-events-cleanup/kukit/resourcedata.js	Fri Jan  5 10:12:10 2007
@@ -383,7 +383,7 @@
         throw new kukit.rd.EventBindError('Error during binding, reason: [' + e + ']', name, namespace);
     }
     // mark on the instance as bound
-    kukit.er.binderInstanceRegistry.markBinding(oper);
+    oper.markBinding();
 };
 
 
@@ -490,9 +490,9 @@
     // parameters so it was actually not entered as an action object
     // otherwise, it would have been executed from action.execute already
     if (typeof(this.content['default']) == 'undefined') {
-        var namespace = oper.eventrule.kss_selector.namespace;
+        // this is conditional: if there is no default method, it's skipped.
         var name = oper.eventrule.kss_selector.name;
-        oper.binderinstance._EventBinder_calldefault(namespace, name, oper);
+        oper.executeDefaultAction(name, true);
     }
 };
 
@@ -618,9 +618,8 @@
     switch (this.type) {
         case 'D': {
             // Default action.
-            var namespace = oper.eventrule.kss_selector.namespace;
             var name = oper.eventrule.kss_selector.name;
-            oper.binderinstance._EventBinder_calldefault(namespace, name, oper);
+            oper.executeDefaultAction(name);
         } break;
         case 'S': {
             // Server action.

From reebalazs at codespeak.net  Fri Jan  5 10:12:22 2007
From: reebalazs at codespeak.net (reebalazs at codespeak.net)
Date: Fri,  5 Jan 2007 10:12:22 +0100 (CET)
Subject: [KSS-checkins] r36161 -
	kukit/kss.core/branch/ree-events-cleanup/plugins/core
Message-ID: <20070105091222.D62E810072@code0.codespeak.net>

Author: reebalazs
Date: Fri Jan  5 10:12:19 2007
New Revision: 36161

Modified:
   kukit/kss.core/branch/ree-events-cleanup/plugins/core/commands.py
   kukit/kss.core/branch/ree-events-cleanup/plugins/core/configure.zcml
Log:
Clean up programmatic event triggering.

Method for event continuation is provided, this atm supports both
existing usecases (annoyclicker + livesearch)

Modified: kukit/kss.core/branch/ree-events-cleanup/plugins/core/commands.py
==============================================================================
--- kukit/kss.core/branch/ree-events-cleanup/plugins/core/commands.py	(original)
+++ kukit/kss.core/branch/ree-events-cleanup/plugins/core/commands.py	Fri Jan  5 10:12:19 2007
@@ -107,9 +107,9 @@
         command.addParam('varname', varname)
         command.addParam('value', value)
 
-    def triggerEvent(self, name, **kw):
+    def continueEvent(self, name, **kw):
         """ see interfaces.py """
-        command = self.commands.addCommand('triggerEvent')
+        command = self.commands.addCommand('continueEvent')
         command.addParam('name', name)
         for key, value in kw.iteritems():
             command.addParam(key, value)

Modified: kukit/kss.core/branch/ree-events-cleanup/plugins/core/configure.zcml
==============================================================================
--- kukit/kss.core/branch/ree-events-cleanup/plugins/core/configure.zcml	(original)
+++ kukit/kss.core/branch/ree-events-cleanup/plugins/core/configure.zcml	Fri Jan  5 10:12:19 2007
@@ -252,10 +252,10 @@
         />
 
     <kss:registerAction
-        name="triggerEvent"
+        name="continueEvent"
         command_factory="global"
         params_mandatory="name"
-        params_optional="id namespace"
+        params_optional="allnodes"
         />
 
     <kss:registerAction

From reebalazs at codespeak.net  Fri Jan  5 10:12:57 2007
From: reebalazs at codespeak.net (reebalazs at codespeak.net)
Date: Fri,  5 Jan 2007 10:12:57 +0100 (CET)
Subject: [KSS-checkins] r36162 -
	kukit/kss.demo/branch/ree-event-cleanup/browser
Message-ID: <20070105091257.35A6910071@code0.codespeak.net>

Author: reebalazs
Date: Fri Jan  5 10:12:55 2007
New Revision: 36162

Modified:
   kukit/kss.demo/branch/ree-event-cleanup/browser/more_selectors.js
Log:
Adjust to new event continuation code

Modified: kukit/kss.demo/branch/ree-event-cleanup/browser/more_selectors.js
==============================================================================
--- kukit/kss.demo/branch/ree-event-cleanup/browser/more_selectors.js	(original)
+++ kukit/kss.demo/branch/ree-event-cleanup/browser/more_selectors.js	Fri Jan  5 10:12:55 2007
@@ -25,9 +25,9 @@
     if (this.count == 0) {
         // Continue with the real action.
         this.count = this.countsomuch;
-        this.__trigger_event__('doit', {}, oper.node);
+        this.__continue_event__('doit', oper.node, {});
     } else {
-        this.__trigger_event__('annoy', {}, oper.node);
+        this.__continue_event__('annoy', oper.node, {});
     }
 };
 

From gotcha at codespeak.net  Fri Jan  5 14:09:57 2007
From: gotcha at codespeak.net (gotcha at codespeak.net)
Date: Fri,  5 Jan 2007 14:09:57 +0100 (CET)
Subject: [KSS-checkins] r36163 - kukit/kukit.js/branch/gotcha-late-binding
Message-ID: <20070105130957.2653410076@code0.codespeak.net>

Author: gotcha
Date: Fri Jan  5 14:09:52 2007
New Revision: 36163

Added:
   kukit/kukit.js/branch/gotcha-late-binding/
      - copied from r36162, kukit/kukit.js/trunk/
Log:
branch for experiments with late binding


From gotcha at codespeak.net  Fri Jan  5 14:12:37 2007
From: gotcha at codespeak.net (gotcha at codespeak.net)
Date: Fri,  5 Jan 2007 14:12:37 +0100 (CET)
Subject: [KSS-checkins] r36164 -
	kukit/kukit.js/branch/gotcha-late-binding/kukit
Message-ID: <20070105131237.CA62110076@code0.codespeak.net>

Author: gotcha
Date: Fri Jan  5 14:12:29 2007
New Revision: 36164

Modified:
   kukit/kukit.js/branch/gotcha-late-binding/kukit/actionreg.js
   kukit/kukit.js/branch/gotcha-late-binding/kukit/eventreg.js
   kukit/kukit.js/branch/gotcha-late-binding/kukit/kukit.js
   kukit/kukit.js/branch/gotcha-late-binding/kukit/plugin.js
   kukit/kukit.js/branch/gotcha-late-binding/kukit/utils.js
Log:
late binding code, improved logging

Modified: kukit/kukit.js/branch/gotcha-late-binding/kukit/actionreg.js
==============================================================================
--- kukit/kukit.js/branch/gotcha-late-binding/kukit/actionreg.js	(original)
+++ kukit/kukit.js/branch/gotcha-late-binding/kukit/actionreg.js	Fri Jan  5 14:12:29 2007
@@ -38,11 +38,11 @@
 
 kukit.ar.ActionRegistry.prototype.register = function(name, func) {
     if (typeof(func) == 'undefined') {
-        throw 'Func is mandatory.';
+        throw 'func argument is mandatory when registering an action (ActionRegistry.register).';
     }
     if (this.content[name]) {
         // Do not allow redefinition
-        kukit.logError('Error : redefinition attempt of action ' + name);
+        kukit.logError('Error : action "' + name + '" already registered.');
         return;
         }
     this.content[name] = func;
@@ -56,7 +56,7 @@
 kukit.ar.ActionRegistry.prototype.get = function(name) {
     var func = this.content[name];
     if (! func) {
-        // not found
+        //not found
         throw 'Error : undefined local action "' + name + '"';
         //kukit.logError('Error : undefined action ' + name);
         }

Modified: kukit/kukit.js/branch/gotcha-late-binding/kukit/eventreg.js
==============================================================================
--- kukit/kukit.js/branch/gotcha-late-binding/kukit/eventreg.js	(original)
+++ kukit/kukit.js/branch/gotcha-late-binding/kukit/eventreg.js	Fri Jan  5 14:12:29 2007
@@ -51,11 +51,11 @@
 
 kukit.er.EventRegistry.prototype.registerBinder = function(classname, func) {
     if (typeof(func) == 'undefined') {
-        throw 'Func is mandatory.';
+        throw 'func argument is mandatory when registering an event binder (EventRegistry.registerBinder).';
     }
     if (this.classes[classname]) {
         // Do not allow redefinition
-        kukit.logError('Error : redefinition attempt of event class ' + classname);
+        kukit.logError('Error : event class "' + classname + '" already registered.');
         return;
     
     }
@@ -83,7 +83,7 @@
 kukit.er.EventRegistry.prototype.register = function(namespace, eventname, klass,
         bindmethodname, defaultactionmethodname) {
     if (typeof(defaultactionmethodname) == 'undefined') {
-        throw 'EventRegistry.register misses some parameters';
+        throw 'some arguments are not passed when calling EventRegistry.register';
     }
     // Find out the class name. (Not specified now.)
     var classname = klass.prototype.__classname__;
@@ -95,7 +95,7 @@
         klass.prototype.__classname__ = classname;
     }
     if (!eventname) {
-        throw 'In EventRegistry.register eventname must be non-empty';
+        throw 'eventname argument cannot be empty when registering an event (EventRegistry.register)';
     }
     var key = this._getKey(namespace, eventname);
     var entry = this.content[key];
@@ -221,6 +221,46 @@
     kukit.logDebug('Event "' + name + '" executed on ' + executed + ' nodes, ' + special + ' special kss targets.');
 };
 
+
+kukit.er.EventBinder_makeFuncToBind = function(name, node) {
+   var executor = new kukit.er.Executor(this, name, node);
+   return function() {
+       executor.executeActions()
+   }
+};
+
+kukit.er.Executor = function(binderinstance, name, node) {
+    this.binderinstance = binderinstance;
+    this.name = name;
+    this.node = node;
+    this.bound = null;
+}
+
+kukit.er.Executor.prototype.executeActions = function() {
+    if (! this.bound) {
+        kukit.log('Attempt of late binding for event ' + this.name + ', node ' + this.node.nodeName);
+        if (kukit.hasFirebug) {
+            kukit.log(this.node);
+        }
+        var opers = kukit.er.binderInstanceRegistry.getBinding(this.binderinstance, this.name);
+        for (var i=0; i<opers.length; i++) {
+            var oper = opers[i];
+            if (oper.node == this.node) {
+                this.bound = function() {
+                    this.binderinstance._EventBinder_triggerevent(this.name, oper);
+                    };
+                kukit.log('node bound');
+                break;
+            }
+        }
+        if (! this.bound) {
+            kukit.logWarning('no node bound');
+            this.bound = function() {};
+        }
+    }
+    this.bound();
+}        
+
 kukit.er.EventBinder_triggerevent = function(name, oper) {
     // Private. Called from __trigger_event__ or from main event execution.
     if (oper.eventrule) {
@@ -241,6 +281,7 @@
     cls.prototype.__trigger_event__ = kukit.er.EventBinder__trigger_event__;
     cls.prototype._EventBinder_triggerevent = kukit.er.EventBinder_triggerevent;
     cls.prototype._EventBinder_calldefault = kukit.er.EventBinder_calldefault;
+    cls.prototype.__make_func_to_bind__ = kukit.er.EventBinder_makeFuncToBind;
 };
 
 /* Event instance registry 

Modified: kukit/kukit.js/branch/gotcha-late-binding/kukit/kukit.js
==============================================================================
--- kukit/kukit.js/branch/gotcha-late-binding/kukit/kukit.js	(original)
+++ kukit/kukit.js/branch/gotcha-late-binding/kukit/kukit.js	Fri Jan  5 14:12:29 2007
@@ -91,7 +91,7 @@
     window.kukitRulesInitialized = true;
     // load the rulesheets
     var rulelinks = kukit.getRuleSheetLinks();
-    kukit.log("Nr of Rule Sheet Links: "+rulelinks.length);
+    kukit.log("Count of KSS links: " + rulelinks.length);
     for (var i=0; i<rulelinks.length; i++) {
         var rulelink = rulelinks[i];
         var ruleProcessorClass = kukit.ruleProcessorClasses[rulelink.res_type];
@@ -101,15 +101,15 @@
             var ts_start = (new Date()).valueOf();
             ruleprocessor.load();
             var ts_loaded = (new Date()).valueOf();
-            // Parsing error is also logged.
             try {
                 ruleprocessor.parse();
             } catch(e) {
+                // ParsingError are logged.
                 if (e.name == 'ParsingError') {
-                    // Log the message
                     var msg = 'Error parsing ' + rulelink.res_type + ' at ' + rulelink.href + ' : ' + e.toString();
+                    // Log the message
                     kukit.logFatal(msg);
-                    // just throw it too...
+                    // and throw it...
                     throw msg;
                 } else {
                     throw e;
@@ -122,15 +122,15 @@
             kukit.logError("Ignoring rulesheet " + rulelink.href + ' of type ' + rulelink.res_type);
         }
     }
-    // Event setup errors are also logged.
     try {
         kukit.setupEvents();
     } catch(e) {
+        // Event setup errors are logged.
         if (e.name == 'RuleMergeError' || e.name == 'EventBindError') {
-            // Log the message
             var msg = 'Error setting up events: ' + e.toString();
+            // Log the message
             kukit.logFatal(msg);
-            // just throw it too...
+            // and throw it...
             throw msg;
         } else {
             throw e;

Modified: kukit/kukit.js/branch/gotcha-late-binding/kukit/plugin.js
==============================================================================
--- kukit/kukit.js/branch/gotcha-late-binding/kukit/plugin.js	(original)
+++ kukit/kukit.js/branch/gotcha-late-binding/kukit/plugin.js	Fri Jan  5 14:12:29 2007
@@ -325,31 +325,34 @@
 kukit.cr.commandRegistry.registerFromAction('error', kukit.cr.makeGlobalCommand);
 
 kukit.ar.actionRegistry.register("logDebug", function (oper) {
-    oper.completeParms([], {'message': 'Logging from Event'}, 'logDebug action');
+    oper.completeParms([], {'message': 'LogDebug action'}, 'logDebug action');
     var node = oper.node;
     var nodeName = '<DOCUMENT>';
     if (node != null) {
         nodeName = node.nodeName;
     }
-    kukit.logDebug(oper.parms.message + ', rule=#' + oper.eventrule.getNr() + ', node=' + nodeName); 
+    kukit.log(oper.parms.message + ', event=' + oper.eventrule.kss_selector.name + ', rule=#' + oper.eventrule.getNr() + ', node=' + nodeName); 
+    if (kukit.hasFirebug) {
+        kukit.log(oper.node);
+        }
     }
 );
 kukit.cr.commandRegistry.registerFromAction('logDebug', kukit.cr.makeGlobalCommand);
 
 kukit.ar.actionRegistry.register("log", function (oper) {
-    oper.completeParms([], {'message': 'Logging from Event'}, 'log action');
+    oper.completeParms([], {'message': 'Log action'}, 'log action');
     var node = oper.node;
     var nodeName = '<DOCUMENT>';
     if (node != null) {
         nodeName = node.nodeName;
     }
-    kukit.log(oper.parms.message + ', rule=#' + oper.eventrule.getNr() + ', node=' + nodeName); 
+    kukit.log(oper.parms.message + ', event=' + oper.eventrule.kss_selector.name + ', rule=#' + oper.eventrule.getNr() + ', node=' + nodeName); 
     }
 );
 kukit.cr.commandRegistry.registerFromAction('log', kukit.cr.makeGlobalCommand);
 
 kukit.ar.actionRegistry.register("alert", function (oper) {
-    oper.completeParms([], {'message': 'Logging from Event'}, 'alert action');
+    oper.completeParms([], {'message': 'Alert action'}, 'alert action');
     var node = oper.node;
     var nodeName = '<DOCUMENT>';
     if (node != null) {

Modified: kukit/kukit.js/branch/gotcha-late-binding/kukit/utils.js
==============================================================================
--- kukit/kukit.js/branch/gotcha-late-binding/kukit/utils.js	(original)
+++ kukit/kukit.js/branch/gotcha-late-binding/kukit/utils.js	Fri Jan  5 14:12:29 2007
@@ -335,6 +335,7 @@
         this.setNextWake(ts);
     } else {
         var now = (new Date()).valueOf();
+        // XXX why compute now and not use it ?
     }
 };
 

From gotcha at codespeak.net  Fri Jan  5 14:13:46 2007
From: gotcha at codespeak.net (gotcha at codespeak.net)
Date: Fri,  5 Jan 2007 14:13:46 +0100 (CET)
Subject: [KSS-checkins] r36165 -
	kukit/kss.core/trunk/plugins/effects/3rd_party
Message-ID: <20070105131346.2F11210076@code0.codespeak.net>

Author: gotcha
Date: Fri Jan  5 14:13:43 2007
New Revision: 36165

Modified:
   kukit/kss.core/trunk/plugins/effects/3rd_party/effects.js
   kukit/kss.core/trunk/plugins/effects/3rd_party/prototype.js
Log:
update scriptaculous to latest release

Modified: kukit/kss.core/trunk/plugins/effects/3rd_party/effects.js
==============================================================================
--- kukit/kss.core/trunk/plugins/effects/3rd_party/effects.js	(original)
+++ kukit/kss.core/trunk/plugins/effects/3rd_party/effects.js	Fri Jan  5 14:13:43 2007
@@ -1,10 +1,13 @@
-// Copyright (c) 2005 Thomas Fuchs (http://script.aculo.us, http://mir.aculo.us)
+// script.aculo.us effects.js v1.6.5, Wed Nov 08 14:17:49 CET 2006
+
+// Copyright (c) 2005, 2006 Thomas Fuchs (http://script.aculo.us, http://mir.aculo.us)
 // Contributors:
 //  Justin Palmer (http://encytemedia.com/)
 //  Mark Pilgrim (http://diveintomark.org/)
 //  Martin Bialasinki
 // 
-// See scriptaculous.js for full license.  
+// script.aculo.us is freely distributable under the terms of an MIT-style license.
+// For details, see the script.aculo.us web site: http://script.aculo.us/ 
 
 // converts rgb() and #xxx to #xxxxxx format,  
 // returns self (or first argument) if not convertable  
@@ -41,15 +44,17 @@
 
 Element.setContentZoom = function(element, percent) {
   element = $(element);  
-  Element.setStyle(element, {fontSize: (percent/100) + 'em'});   
+  element.setStyle({fontSize: (percent/100) + 'em'});   
   if(navigator.appVersion.indexOf('AppleWebKit')>0) window.scrollBy(0,0);
+  return element;
 }
 
-Element.getOpacity = function(element){  
+Element.getOpacity = function(element){
+  element = $(element);
   var opacity;
-  if (opacity = Element.getStyle(element, 'opacity'))  
+  if (opacity = element.getStyle('opacity'))  
     return parseFloat(opacity);  
-  if (opacity = (Element.getStyle(element, 'filter') || '').match(/alpha\(opacity=(.*)\)/))  
+  if (opacity = (element.getStyle('filter') || '').match(/alpha\(opacity=(.*)\)/))  
     if(opacity[1]) return parseFloat(opacity[1]) / 100;  
   return 1.0;  
 }
@@ -57,34 +62,26 @@
 Element.setOpacity = function(element, value){  
   element= $(element);  
   if (value == 1){
-    Element.setStyle(element, { opacity: 
+    element.setStyle({ opacity: 
       (/Gecko/.test(navigator.userAgent) && !/Konqueror|Safari|KHTML/.test(navigator.userAgent)) ? 
-      0.999999 : null });
-    if(/MSIE/.test(navigator.userAgent))  
-      Element.setStyle(element, {filter: Element.getStyle(element,'filter').replace(/alpha\([^\)]*\)/gi,'')});  
+      0.999999 : 1.0 });
+    if(/MSIE/.test(navigator.userAgent) && !window.opera)  
+      element.setStyle({filter: Element.getStyle(element,'filter').replace(/alpha\([^\)]*\)/gi,'')});  
   } else {  
     if(value < 0.00001) value = 0;  
-    Element.setStyle(element, {opacity: value});
-    if(/MSIE/.test(navigator.userAgent))  
-     Element.setStyle(element, 
-       { filter: Element.getStyle(element,'filter').replace(/alpha\([^\)]*\)/gi,'') +
-                 'alpha(opacity='+value*100+')' });  
+    element.setStyle({opacity: value});
+    if(/MSIE/.test(navigator.userAgent) && !window.opera)  
+      element.setStyle(
+        { filter: element.getStyle('filter').replace(/alpha\([^\)]*\)/gi,'') +
+            'alpha(opacity='+value*100+')' });  
   }
+  return element;
 }  
  
 Element.getInlineOpacity = function(element){  
   return $(element).style.opacity || '';
 }  
 
-Element.childrenWithClassName = function(element, className, findFirst) {
-  var classNameRegExp = new RegExp("(^|\\s)" + className + "(\\s|$)");
-  var results = $A($(element).getElementsByTagName('*'))[findFirst ? 'detect' : 'select']( function(c) { 
-    return (c.className && c.className.match(classNameRegExp));
-  });
-  if(!results) results = [];
-  return results;
-}
-
 Element.forceRerendering = function(element) {
   try {
     element = $(element);
@@ -104,9 +101,17 @@
 /*--------------------------------------------------------------------------*/
 
 var Effect = {
+  _elementDoesNotExistError: {
+    name: 'ElementDoesNotExistError',
+    message: 'The specified DOM element does not exist, but is required for this effect to operate'
+  },
   tagifyText: function(element) {
+    if(typeof Builder == 'undefined')
+      throw("Effect.tagifyText requires including script.aculo.us' builder.js library");
+      
     var tagifyStyle = 'position:relative';
-    if(/MSIE/.test(navigator.userAgent)) tagifyStyle += ';zoom:1';
+    if(/MSIE/.test(navigator.userAgent) && !window.opera) tagifyStyle += ';zoom:1';
+    
     element = $(element);
     $A(element.childNodes).each( function(child) {
       if(child.nodeType==3) {
@@ -159,33 +164,35 @@
 
 /* ------------- transitions ------------- */
 
-Effect.Transitions = {}
-
-Effect.Transitions.linear = function(pos) {
-  return pos;
-}
-Effect.Transitions.sinoidal = function(pos) {
-  return (-Math.cos(pos*Math.PI)/2) + 0.5;
-}
-Effect.Transitions.reverse  = function(pos) {
-  return 1-pos;
-}
-Effect.Transitions.flicker = function(pos) {
-  return ((-Math.cos(pos*Math.PI)/4) + 0.75) + Math.random()/4;
-}
-Effect.Transitions.wobble = function(pos) {
-  return (-Math.cos(pos*Math.PI*(9*pos))/2) + 0.5;
-}
-Effect.Transitions.pulse = function(pos) {
-  return (Math.floor(pos*10) % 2 == 0 ? 
-    (pos*10-Math.floor(pos*10)) : 1-(pos*10-Math.floor(pos*10)));
-}
-Effect.Transitions.none = function(pos) {
-  return 0;
-}
-Effect.Transitions.full = function(pos) {
-  return 1;
-}
+Effect.Transitions = {
+  linear: Prototype.K,
+  sinoidal: function(pos) {
+    return (-Math.cos(pos*Math.PI)/2) + 0.5;
+  },
+  reverse: function(pos) {
+    return 1-pos;
+  },
+  flicker: function(pos) {
+    return ((-Math.cos(pos*Math.PI)/4) + 0.75) + Math.random()/4;
+  },
+  wobble: function(pos) {
+    return (-Math.cos(pos*Math.PI*(9*pos))/2) + 0.5;
+  },
+  pulse: function(pos, pulses) { 
+    pulses = pulses || 5; 
+    return (
+      Math.round((pos % (1/pulses)) * pulses) == 0 ? 
+            ((pos * pulses * 2) - Math.floor(pos * pulses * 2)) : 
+        1 - ((pos * pulses * 2) - Math.floor(pos * pulses * 2))
+      );
+  },
+  none: function(pos) {
+    return 0;
+  },
+  full: function(pos) {
+    return 1;
+  }
+};
 
 /* ------------- core effects ------------- */
 
@@ -212,6 +219,9 @@
             e.finishOn += effect.finishOn;
           });
         break;
+      case 'with-last':
+        timestamp = this.effects.pluck('startOn').max() || timestamp;
+        break;
       case 'end':
         // start effect after last queued effect has finished
         timestamp = this.effects.pluck('finishOn').max() || timestamp;
@@ -348,12 +358,24 @@
   }
 });
 
+Effect.Event = Class.create();
+Object.extend(Object.extend(Effect.Event.prototype, Effect.Base.prototype), {
+  initialize: function() {
+    var options = Object.extend({
+      duration: 0
+    }, arguments[0] || {});
+    this.start(options);
+  },
+  update: Prototype.emptyFunction
+});
+
 Effect.Opacity = Class.create();
 Object.extend(Object.extend(Effect.Opacity.prototype, Effect.Base.prototype), {
   initialize: function(element) {
     this.element = $(element);
+    if(!this.element) throw(Effect._elementDoesNotExistError);
     // make this work on IE on elements without 'layout'
-    if(/MSIE/.test(navigator.userAgent) && (!this.element.hasLayout))
+    if(/MSIE/.test(navigator.userAgent) && !window.opera && (!this.element.currentStyle.hasLayout))
       this.element.setStyle({zoom: 1});
     var options = Object.extend({
       from: this.element.getOpacity() || 0.0,
@@ -370,6 +392,7 @@
 Object.extend(Object.extend(Effect.Move.prototype, Effect.Base.prototype), {
   initialize: function(element) {
     this.element = $(element);
+    if(!this.element) throw(Effect._elementDoesNotExistError);
     var options = Object.extend({
       x:    0,
       y:    0,
@@ -393,8 +416,8 @@
   },
   update: function(position) {
     this.element.setStyle({
-      left: this.options.x  * position + this.originalLeft + 'px',
-      top:  this.options.y  * position + this.originalTop  + 'px'
+      left: Math.round(this.options.x  * position + this.originalLeft) + 'px',
+      top:  Math.round(this.options.y  * position + this.originalTop)  + 'px'
     });
   }
 });
@@ -408,7 +431,8 @@
 Effect.Scale = Class.create();
 Object.extend(Object.extend(Effect.Scale.prototype, Effect.Base.prototype), {
   initialize: function(element, percent) {
-    this.element = $(element)
+    this.element = $(element);
+    if(!this.element) throw(Effect._elementDoesNotExistError);
     var options = Object.extend({
       scaleX: true,
       scaleY: true,
@@ -433,7 +457,7 @@
     this.originalLeft = this.element.offsetLeft;
     
     var fontSize = this.element.getStyle('font-size') || '100%';
-    ['em','px','%'].each( function(fontSizeType) {
+    ['em','px','%','pt'].each( function(fontSizeType) {
       if(fontSize.indexOf(fontSizeType)>0) {
         this.fontSize     = parseFloat(fontSize);
         this.fontSizeType = fontSizeType;
@@ -458,12 +482,12 @@
     this.setDimensions(this.dims[0] * currentScale, this.dims[1] * currentScale);
   },
   finish: function(position) {
-    if (this.restoreAfterFinish) this.element.setStyle(this.originalStyle);
+    if(this.restoreAfterFinish) this.element.setStyle(this.originalStyle);
   },
   setDimensions: function(height, width) {
     var d = {};
-    if(this.options.scaleX) d.width = width + 'px';
-    if(this.options.scaleY) d.height = height + 'px';
+    if(this.options.scaleX) d.width = Math.round(width) + 'px';
+    if(this.options.scaleY) d.height = Math.round(height) + 'px';
     if(this.options.scaleFromCenter) {
       var topd  = (height - this.dims[0])/2;
       var leftd = (width  - this.dims[1])/2;
@@ -483,6 +507,7 @@
 Object.extend(Object.extend(Effect.Highlight.prototype, Effect.Base.prototype), {
   initialize: function(element) {
     this.element = $(element);
+    if(!this.element) throw(Effect._elementDoesNotExistError);
     var options = Object.extend({ startcolor: '#ffff99' }, arguments[1] || {});
     this.start(options);
   },
@@ -547,8 +572,7 @@
   to:   0.0,
   afterFinishInternal: function(effect) { 
     if(effect.options.to!=0) return;
-    effect.element.hide();
-    effect.element.setStyle({opacity: oldOpacity}); 
+    effect.element.hide().setStyle({opacity: oldOpacity}); 
   }}, arguments[1] || {});
   return new Effect.Opacity(element,options);
 }
@@ -563,25 +587,31 @@
     effect.element.forceRerendering();
   },
   beforeSetup: function(effect) {
-    effect.element.setOpacity(effect.options.from);
-    effect.element.show(); 
+    effect.element.setOpacity(effect.options.from).show(); 
   }}, arguments[1] || {});
   return new Effect.Opacity(element,options);
 }
 
 Effect.Puff = function(element) {
   element = $(element);
-  var oldStyle = { opacity: element.getInlineOpacity(), position: element.getStyle('position') };
+  var oldStyle = { 
+    opacity: element.getInlineOpacity(), 
+    position: element.getStyle('position'),
+    top:  element.style.top,
+    left: element.style.left,
+    width: element.style.width,
+    height: element.style.height
+  };
   return new Effect.Parallel(
    [ new Effect.Scale(element, 200, 
       { sync: true, scaleFromCenter: true, scaleContent: true, restoreAfterFinish: true }), 
      new Effect.Opacity(element, { sync: true, to: 0.0 } ) ], 
      Object.extend({ duration: 1.0, 
       beforeSetupInternal: function(effect) {
-        effect.effects[0].element.setStyle({position: 'absolute'}); },
+        Position.absolutize(effect.effects[0].element)
+      },
       afterFinishInternal: function(effect) {
-         effect.effects[0].element.hide();
-         effect.effects[0].element.setStyle(oldStyle); }
+         effect.effects[0].element.hide().setStyle(oldStyle); }
      }, arguments[1] || {})
    );
 }
@@ -589,13 +619,12 @@
 Effect.BlindUp = function(element) {
   element = $(element);
   element.makeClipping();
-  return new Effect.Scale(element, 0, 
+  return new Effect.Scale(element, 0,
     Object.extend({ scaleContent: false, 
       scaleX: false, 
       restoreAfterFinish: true,
       afterFinishInternal: function(effect) {
-        effect.element.hide();
-        effect.element.undoClipping();
+        effect.element.hide().undoClipping();
       } 
     }, arguments[1] || {})
   );
@@ -604,28 +633,25 @@
 Effect.BlindDown = function(element) {
   element = $(element);
   var elementDimensions = element.getDimensions();
-  return new Effect.Scale(element, 100, 
-    Object.extend({ scaleContent: false, 
-      scaleX: false,
-      scaleFrom: 0,
-      scaleMode: {originalHeight: elementDimensions.height, originalWidth: elementDimensions.width},
-      restoreAfterFinish: true,
-      afterSetup: function(effect) {
-        effect.element.makeClipping();
-        effect.element.setStyle({height: '0px'});
-        effect.element.show(); 
-      },  
-      afterFinishInternal: function(effect) {
-        effect.element.undoClipping();
-      }
-    }, arguments[1] || {})
-  );
+  return new Effect.Scale(element, 100, Object.extend({ 
+    scaleContent: false, 
+    scaleX: false,
+    scaleFrom: 0,
+    scaleMode: {originalHeight: elementDimensions.height, originalWidth: elementDimensions.width},
+    restoreAfterFinish: true,
+    afterSetup: function(effect) {
+      effect.element.makeClipping().setStyle({height: '0px'}).show(); 
+    },  
+    afterFinishInternal: function(effect) {
+      effect.element.undoClipping();
+    }
+  }, arguments[1] || {}));
 }
 
 Effect.SwitchOff = function(element) {
   element = $(element);
   var oldOpacity = element.getInlineOpacity();
-  return new Effect.Appear(element, { 
+  return new Effect.Appear(element, Object.extend({
     duration: 0.4,
     from: 0,
     transition: Effect.Transitions.flicker,
@@ -634,18 +660,14 @@
         duration: 0.3, scaleFromCenter: true,
         scaleX: false, scaleContent: false, restoreAfterFinish: true,
         beforeSetup: function(effect) { 
-          effect.element.makePositioned();
-          effect.element.makeClipping();
+          effect.element.makePositioned().makeClipping();
         },
         afterFinishInternal: function(effect) {
-          effect.element.hide();
-          effect.element.undoClipping();
-          effect.element.undoPositioned();
-          effect.element.setStyle({opacity: oldOpacity});
+          effect.element.hide().undoClipping().undoPositioned().setStyle({opacity: oldOpacity});
         }
       })
     }
-  });
+  }, arguments[1] || {}));
 }
 
 Effect.DropOut = function(element) {
@@ -663,9 +685,7 @@
           effect.effects[0].element.makePositioned(); 
         },
         afterFinishInternal: function(effect) {
-          effect.effects[0].element.hide();
-          effect.effects[0].element.undoPositioned();
-          effect.effects[0].element.setStyle(oldStyle);
+          effect.effects[0].element.hide().undoPositioned().setStyle(oldStyle);
         } 
       }, arguments[1] || {}));
 }
@@ -687,16 +707,14 @@
       { x:  40, y: 0, duration: 0.1,  afterFinishInternal: function(effect) {
     new Effect.Move(effect.element,
       { x: -20, y: 0, duration: 0.05, afterFinishInternal: function(effect) {
-        effect.element.undoPositioned();
-        effect.element.setStyle(oldStyle);
+        effect.element.undoPositioned().setStyle(oldStyle);
   }}) }}) }}) }}) }}) }});
 }
 
 Effect.SlideDown = function(element) {
-  element = $(element);
-  element.cleanWhitespace();
+  element = $(element).cleanWhitespace();
   // SlideDown need to have the content of the element wrapped in a container element with fixed height!
-  var oldInnerBottom = $(element.firstChild).getStyle('bottom');
+  var oldInnerBottom = element.down().getStyle('bottom');
   var elementDimensions = element.getDimensions();
   return new Effect.Scale(element, 100, Object.extend({ 
     scaleContent: false, 
@@ -706,34 +724,24 @@
     restoreAfterFinish: true,
     afterSetup: function(effect) {
       effect.element.makePositioned();
-      effect.element.firstChild.makePositioned();
+      effect.element.down().makePositioned();
       if(window.opera) effect.element.setStyle({top: ''});
-      effect.element.makeClipping();
-      effect.element.setStyle({height: '0px'});
-      effect.element.show(); },
+      effect.element.makeClipping().setStyle({height: '0px'}).show(); 
+    },
     afterUpdateInternal: function(effect) {
-      effect.element.firstChild.setStyle({bottom:
+      effect.element.down().setStyle({bottom:
         (effect.dims[0] - effect.element.clientHeight) + 'px' }); 
     },
     afterFinishInternal: function(effect) {
-      effect.element.undoClipping(); 
-      // IE will crash if child is undoPositioned first
-      if(/MSIE/.test(navigator.userAgent)){
-        effect.element.undoPositioned();
-        effect.element.firstChild.undoPositioned();
-      }else{
-        effect.element.firstChild.undoPositioned();
-        effect.element.undoPositioned();
-      }
-      effect.element.firstChild.setStyle({bottom: oldInnerBottom}); }
+      effect.element.undoClipping().undoPositioned();
+      effect.element.down().undoPositioned().setStyle({bottom: oldInnerBottom}); }
     }, arguments[1] || {})
   );
 }
-  
+
 Effect.SlideUp = function(element) {
-  element = $(element);
-  element.cleanWhitespace();
-  var oldInnerBottom = $(element.firstChild).getStyle('bottom');
+  element = $(element).cleanWhitespace();
+  var oldInnerBottom = element.down().getStyle('bottom');
   return new Effect.Scale(element, window.opera ? 0 : 1,
    Object.extend({ scaleContent: false, 
     scaleX: false, 
@@ -742,32 +750,32 @@
     restoreAfterFinish: true,
     beforeStartInternal: function(effect) {
       effect.element.makePositioned();
-      effect.element.firstChild.makePositioned();
+      effect.element.down().makePositioned();
       if(window.opera) effect.element.setStyle({top: ''});
-      effect.element.makeClipping();
-      effect.element.show(); },  
+      effect.element.makeClipping().show();
+    },  
     afterUpdateInternal: function(effect) {
-      effect.element.firstChild.setStyle({bottom:
-        (effect.dims[0] - effect.element.clientHeight) + 'px' }); },
+      effect.element.down().setStyle({bottom:
+        (effect.dims[0] - effect.element.clientHeight) + 'px' });
+    },
     afterFinishInternal: function(effect) {
-      effect.element.hide();
-      effect.element.undoClipping();
-      effect.element.firstChild.undoPositioned();
-      effect.element.undoPositioned();
-      effect.element.setStyle({bottom: oldInnerBottom}); }
+      effect.element.hide().undoClipping().undoPositioned().setStyle({bottom: oldInnerBottom});
+      effect.element.down().undoPositioned();
+    }
    }, arguments[1] || {})
   );
 }
 
 // Bug in opera makes the TD containing this element expand for a instance after finish 
 Effect.Squish = function(element) {
-  return new Effect.Scale(element, window.opera ? 1 : 0, 
-    { restoreAfterFinish: true,
-      beforeSetup: function(effect) {
-        effect.element.makeClipping(effect.element); },  
-      afterFinishInternal: function(effect) {
-        effect.element.hide(effect.element); 
-        effect.element.undoClipping(effect.element); }
+  return new Effect.Scale(element, window.opera ? 1 : 0, { 
+    restoreAfterFinish: true,
+    beforeSetup: function(effect) {
+      effect.element.makeClipping(); 
+    },  
+    afterFinishInternal: function(effect) {
+      effect.element.hide().undoClipping(); 
+    }
   });
 }
 
@@ -823,9 +831,7 @@
     y: initialMoveY,
     duration: 0.01, 
     beforeSetup: function(effect) {
-      effect.element.hide();
-      effect.element.makeClipping();
-      effect.element.makePositioned();
+      effect.element.hide().makeClipping().makePositioned();
     },
     afterFinishInternal: function(effect) {
       new Effect.Parallel(
@@ -836,13 +842,10 @@
             sync: true, scaleFrom: window.opera ? 1 : 0, transition: options.scaleTransition, restoreAfterFinish: true})
         ], Object.extend({
              beforeSetup: function(effect) {
-               effect.effects[0].element.setStyle({height: '0px'});
-               effect.effects[0].element.show(); 
+               effect.effects[0].element.setStyle({height: '0px'}).show(); 
              },
              afterFinishInternal: function(effect) {
-               effect.effects[0].element.undoClipping();
-               effect.effects[0].element.undoPositioned();
-               effect.effects[0].element.setStyle(oldStyle); 
+               effect.effects[0].element.undoClipping().undoPositioned().setStyle(oldStyle); 
              }
            }, options)
       )
@@ -896,13 +899,10 @@
       new Effect.Move(element, { x: moveX, y: moveY, sync: true, transition: options.moveTransition })
     ], Object.extend({            
          beforeStartInternal: function(effect) {
-           effect.effects[0].element.makePositioned();
-           effect.effects[0].element.makeClipping(); },
+           effect.effects[0].element.makePositioned().makeClipping(); 
+         },
          afterFinishInternal: function(effect) {
-           effect.effects[0].element.hide();
-           effect.effects[0].element.undoClipping();
-           effect.effects[0].element.undoPositioned();
-           effect.effects[0].element.setStyle(oldStyle); }
+           effect.effects[0].element.hide().undoClipping().undoPositioned().setStyle(oldStyle); }
        }, options)
   );
 }
@@ -912,10 +912,10 @@
   var options    = arguments[1] || {};
   var oldOpacity = element.getInlineOpacity();
   var transition = options.transition || Effect.Transitions.sinoidal;
-  var reverser   = function(pos){ return transition(1-Effect.Transitions.pulse(pos)) };
+  var reverser   = function(pos){ return transition(1-Effect.Transitions.pulse(pos, options.pulses)) };
   reverser.bind(transition);
   return new Effect.Opacity(element, 
-    Object.extend(Object.extend({  duration: 3.0, from: 0,
+    Object.extend(Object.extend({  duration: 2.0, from: 0,
       afterFinishInternal: function(effect) { effect.element.setStyle({opacity: oldOpacity}); }
     }, options), {transition: reverser}));
 }
@@ -927,7 +927,7 @@
     left: element.style.left,
     width: element.style.width,
     height: element.style.height };
-  Element.makeClipping(element);
+  element.makeClipping();
   return new Effect.Scale(element, 5, Object.extend({   
     scaleContent: false,
     scaleX: false,
@@ -936,15 +936,13 @@
       scaleContent: false, 
       scaleY: false,
       afterFinishInternal: function(effect) {
-        effect.element.hide();
-        effect.element.undoClipping(); 
-        effect.element.setStyle(oldStyle);
+        effect.element.hide().undoClipping().setStyle(oldStyle);
       } });
   }}, arguments[1] || {}));
 };
 
 ['setOpacity','getOpacity','getInlineOpacity','forceRerendering','setContentZoom',
- 'collectTextNodes','collectTextNodesIgnoreClass','childrenWithClassName'].each( 
+ 'collectTextNodes','collectTextNodesIgnoreClass'].each( 
   function(f) { Element.Methods[f] = Element[f]; }
 );
 

Modified: kukit/kss.core/trunk/plugins/effects/3rd_party/prototype.js
==============================================================================
--- kukit/kss.core/trunk/plugins/effects/3rd_party/prototype.js	(original)
+++ kukit/kss.core/trunk/plugins/effects/3rd_party/prototype.js	Fri Jan  5 14:13:43 2007
@@ -1,4 +1,4 @@
-/*  Prototype JavaScript framework, version 1.5.0_rc0
+/*  Prototype JavaScript framework, version 1.5.0_rc1
  *  (c) 2005 Sam Stephenson <sam at conio.net>
  *
  *  Prototype is freely distributable under the terms of an MIT-style license.
@@ -7,11 +7,14 @@
 /*--------------------------------------------------------------------------*/
 
 var Prototype = {
-  Version: '1.5.0_rc0',
-  ScriptFragment: '(?:<script.*?>)((\n|\r|.)*?)(?:<\/script>)',
+  Version: '1.5.0_rc1',
+  BrowserFeatures: {
+    XPath: !!document.evaluate
+  },
 
+  ScriptFragment: '(?:<script.*?>)((\n|\r|.)*?)(?:<\/script>)',
   emptyFunction: function() {},
-  K: function(x) {return x}
+  K: function(x) { return x }
 }
 
 var Class = {
@@ -31,16 +34,36 @@
   return destination;
 }
 
-Object.inspect = function(object) {
-  try {
-    if (object == undefined) return 'undefined';
-    if (object == null) return 'null';
-    return object.inspect ? object.inspect() : object.toString();
-  } catch (e) {
-    if (e instanceof RangeError) return '...';
-    throw e;
+Object.extend(Object, {
+  inspect: function(object) {
+    try {
+      if (object === undefined) return 'undefined';
+      if (object === null) return 'null';
+      return object.inspect ? object.inspect() : object.toString();
+    } catch (e) {
+      if (e instanceof RangeError) return '...';
+      throw e;
+    }
+  },
+
+  keys: function(object) {
+    var keys = [];
+    for (var property in object)
+      keys.push(property);
+    return keys;
+  },
+
+  values: function(object) {
+    var values = [];
+    for (var property in object)
+      values.push(object[property]);
+    return values;
+  },
+
+  clone: function(object) {
+    return Object.extend({}, object);
   }
-}
+});
 
 Function.prototype.bind = function() {
   var __method = this, args = $A(arguments), object = args.shift();
@@ -50,9 +73,9 @@
 }
 
 Function.prototype.bindAsEventListener = function(object) {
-  var __method = this;
+  var __method = this, args = $A(arguments), object = args.shift();
   return function(event) {
-    return __method.call(object, event || window.event);
+    return __method.apply(object, [( event || window.event)].concat(args).concat($A(arguments)));
   }
 }
 
@@ -102,14 +125,20 @@
   },
 
   registerCallback: function() {
-    setInterval(this.onTimerEvent.bind(this), this.frequency * 1000);
+    this.timer = setInterval(this.onTimerEvent.bind(this), this.frequency * 1000);
+  },
+
+  stop: function() {
+    if (!this.timer) return;
+    clearInterval(this.timer);
+    this.timer = null;
   },
 
   onTimerEvent: function() {
     if (!this.currentlyExecuting) {
       try {
         this.currentlyExecuting = true;
-        this.callback();
+        this.callback(this);
       } finally {
         this.currentlyExecuting = false;
       }
@@ -193,10 +222,13 @@
   },
 
   toQueryParams: function() {
-    var pairs = this.match(/^\??(.*)$/)[1].split('&');
+    var match = this.strip().match(/[^?]*$/)[0];
+    if (!match) return {};
+    var pairs = match.split('&');
     return pairs.inject({}, function(params, pairString) {
-      var pair = pairString.split('=');
-      params[pair[0]] = pair[1];
+      var pair  = pairString.split('=');
+      var value = pair[1] ? decodeURIComponent(pair[1]) : undefined;
+      params[decodeURIComponent(pair[0])] = value;
       return params;
     });
   },
@@ -213,7 +245,7 @@
       ? oStringList[0].charAt(0).toUpperCase() + oStringList[0].substring(1)
       : oStringList[0];
 
-    for (var i = 1, len = oStringList.length; i < len; i++) {
+    for (var i = 1, length = oStringList.length; i < length; i++) {
       var s = oStringList[i];
       camelizedString += s.charAt(0).toUpperCase() + s.substring(1);
     }
@@ -221,8 +253,12 @@
     return camelizedString;
   },
 
-  inspect: function() {
-    return "'" + this.replace(/\\/g, '\\\\').replace(/'/g, '\\\'') + "'";
+  inspect: function(useDoubleQuotes) {
+    var escapedString = this.replace(/\\/g, '\\\\');
+    if (useDoubleQuotes)
+      return '"' + escapedString.replace(/"/g, '\\"') + '"';
+    else
+      return "'" + escapedString.replace(/'/g, '\\\'') + "'";
   }
 });
 
@@ -268,6 +304,14 @@
     } catch (e) {
       if (e != $break) throw e;
     }
+    return this;
+  },
+
+  eachSlice: function(number, iterator) {
+    var index = -number, slices = [], array = this.toArray();
+    while ((index += number) < array.length)
+      slices.push(array.slice(index, index+number));
+    return slices.collect(iterator || Prototype.K);
   },
 
   all: function(iterator) {
@@ -280,7 +324,7 @@
   },
 
   any: function(iterator) {
-    var result = true;
+    var result = false;
     this.each(function(value, index) {
       if (result = !!(iterator || Prototype.K)(value, index))
         throw $break;
@@ -296,7 +340,7 @@
     return results;
   },
 
-  detect: function (iterator) {
+  detect: function(iterator) {
     var result;
     this.each(function(value, index) {
       if (iterator(value, index)) {
@@ -337,6 +381,15 @@
     return found;
   },
 
+  inGroupsOf: function(number, fillWith) {
+    fillWith = fillWith || null;
+    var results = this.eachSlice(number);
+    if (results.length > 0) (number - results.last().length).times(function() {
+      results.last().push(fillWith)
+    });
+    return results;
+  },
+
   inject: function(memo, iterator) {
     this.each(function(value, index) {
       memo = iterator(memo, value, index);
@@ -439,7 +492,7 @@
     return iterable.toArray();
   } else {
     var results = [];
-    for (var i = 0; i < iterable.length; i++)
+    for (var i = 0, length = iterable.length; i < length; i++)
       results.push(iterable[i]);
     return results;
   }
@@ -452,7 +505,7 @@
 
 Object.extend(Array.prototype, {
   _each: function(iterator) {
-    for (var i = 0; i < this.length; i++)
+    for (var i = 0, length = this.length; i < length; i++)
       iterator(this[i]);
   },
 
@@ -490,7 +543,7 @@
   },
 
   indexOf: function(object) {
-    for (var i = 0; i < this.length; i++)
+    for (var i = 0, length = this.length; i < length; i++)
       if (this[i] == object) return i;
     return -1;
   },
@@ -499,10 +552,26 @@
     return (inline !== false ? this : this.toArray())._reverse();
   },
 
+  reduce: function() {
+    return this.length > 1 ? this : this[0];
+  },
+
+  uniq: function() {
+    return this.inject([], function(array, value) {
+      return array.include(value) ? array : array.concat([value]);
+    });
+  },
+
+  clone: function() {
+    return [].concat(this);
+  },
+
   inspect: function() {
     return '[' + this.map(Object.inspect).join(', ') + ']';
   }
 });
+
+Array.prototype.toArray = Array.prototype.clone;
 var Hash = {
   _each: function(iterator) {
     for (var key in this) {
@@ -525,7 +594,7 @@
   },
 
   merge: function(hash) {
-    return $H(hash).inject($H(this), function(mergedHash, pair) {
+    return $H(hash).inject(this, function(mergedHash, pair) {
       mergedHash[pair.key] = pair.value;
       return mergedHash;
     });
@@ -533,6 +602,8 @@
 
   toQueryString: function() {
     return this.map(function(pair) {
+      if (!pair.value && pair.value !== 0) pair[1] = '';
+      if (!pair.key) return;
       return pair.map(encodeURIComponent).join('=');
     }).join('&');
   },
@@ -561,10 +632,10 @@
 
   _each: function(iterator) {
     var value = this.start;
-    do {
+    while (this.include(value)) {
       iterator(value);
       value = value.succ();
-    } while (this.include(value));
+    }
   },
 
   include: function(value) {
@@ -599,18 +670,18 @@
     this.responders._each(iterator);
   },
 
-  register: function(responderToAdd) {
-    if (!this.include(responderToAdd))
-      this.responders.push(responderToAdd);
+  register: function(responder) {
+    if (!this.include(responder))
+      this.responders.push(responder);
   },
 
-  unregister: function(responderToRemove) {
-    this.responders = this.responders.without(responderToRemove);
+  unregister: function(responder) {
+    this.responders = this.responders.without(responder);
   },
 
   dispatch: function(callback, request, transport, json) {
     this.each(function(responder) {
-      if (responder[callback] && typeof responder[callback] == 'function') {
+      if (typeof responder[callback] == 'function') {
         try {
           responder[callback].apply(responder, [request, transport, json]);
         } catch (e) {}
@@ -625,7 +696,6 @@
   onCreate: function() {
     Ajax.activeRequestCount++;
   },
-
   onComplete: function() {
     Ajax.activeRequestCount--;
   }
@@ -638,19 +708,14 @@
       method:       'post',
       asynchronous: true,
       contentType:  'application/x-www-form-urlencoded',
+      encoding:     'UTF-8',
       parameters:   ''
     }
     Object.extend(this.options, options || {});
-  },
-
-  responseIsSuccess: function() {
-    return this.transport.status == undefined
-        || this.transport.status == 0
-        || (this.transport.status >= 200 && this.transport.status < 300);
-  },
 
-  responseIsFailure: function() {
-    return !this.responseIsSuccess();
+    this.options.method = this.options.method.toLowerCase();
+    this.options.parameters = $H(typeof this.options.parameters == 'string' ?
+      this.options.parameters.toQueryParams() : this.options.parameters);
   }
 }
 
@@ -666,111 +731,145 @@
   },
 
   request: function(url) {
-    var parameters = this.options.parameters || '';
-    if (parameters.length > 0) parameters += '&_=';
+    var params = this.options.parameters;
+    if (params.any()) params['_'] = '';
 
-    try {
-      this.url = url;
-      if (this.options.method == 'get' && parameters.length > 0)
-        this.url += (this.url.match(/\?/) ? '&' : '?') + parameters;
+    if (!['get', 'post'].include(this.options.method)) {
+      // simulate other verbs over post
+      params['_method'] = this.options.method;
+      this.options.method = 'post';
+    }
 
+    this.url = url;
+
+    // when GET, append parameters to URL
+    if (this.options.method == 'get' && params.any())
+      this.url += (this.url.indexOf('?') >= 0 ? '&' : '?') +
+        params.toQueryString();
+
+    try {
       Ajax.Responders.dispatch('onCreate', this, this.transport);
 
-      this.transport.open(this.options.method, this.url,
-        this.options.asynchronous);
+      this.transport.open(this.options.method.toUpperCase(), this.url,
+        this.options.asynchronous, this.options.username,
+        this.options.password);
 
-      if (this.options.asynchronous) {
-        this.transport.onreadystatechange = this.onStateChange.bind(this);
-        setTimeout((function() {this.respondToReadyState(1)}).bind(this), 10);
-      }
+      if (this.options.asynchronous)
+        setTimeout(function() { this.respondToReadyState(1) }.bind(this), 10);
 
+      this.transport.onreadystatechange = this.onStateChange.bind(this);
       this.setRequestHeaders();
 
-      var body = this.options.postBody ? this.options.postBody : parameters;
-      this.transport.send(this.options.method == 'post' ? body : null);
+      var body = this.options.method == 'post' ?
+        (this.options.postBody || params.toQueryString()) : null;
 
-    } catch (e) {
+      this.transport.send(body);
+
+      /* Force Firefox to handle ready state 4 for synchronous requests */
+      if (!this.options.asynchronous && this.transport.overrideMimeType)
+        this.onStateChange();
+    }
+    catch (e) {
       this.dispatchException(e);
     }
   },
 
+  onStateChange: function() {
+    var readyState = this.transport.readyState;
+    if (readyState > 1)
+      this.respondToReadyState(this.transport.readyState);
+  },
+
   setRequestHeaders: function() {
-    var requestHeaders =
-      ['X-Requested-With', 'XMLHttpRequest',
-       'X-Prototype-Version', Prototype.Version,
-       'Accept', 'text/javascript, text/html, application/xml, text/xml, */*'];
+    var headers = {
+      'X-Requested-With': 'XMLHttpRequest',
+      'X-Prototype-Version': Prototype.Version,
+      'Accept': 'text/javascript, text/html, application/xml, text/xml, */*'
+    };
 
     if (this.options.method == 'post') {
-      requestHeaders.push('Content-type', this.options.contentType);
+      headers['Content-type'] = this.options.contentType +
+        (this.options.encoding ? '; charset=' + this.options.encoding : '');
 
-      /* Force "Connection: close" for Mozilla browsers to work around
-       * a bug where XMLHttpReqeuest sends an incorrect Content-length
-       * header. See Mozilla Bugzilla #246651.
+      /* Force "Connection: close" for older Mozilla browsers to work
+       * around a bug where XMLHttpRequest sends an incorrect
+       * Content-length header. See Mozilla Bugzilla #246651.
        */
-      if (this.transport.overrideMimeType)
-        requestHeaders.push('Connection', 'close');
+      if (this.transport.overrideMimeType &&
+          (navigator.userAgent.match(/Gecko\/(\d{4})/) || [0,2005])[1] < 2005)
+            headers['Connection'] = 'close';
     }
 
-    if (this.options.requestHeaders)
-      requestHeaders.push.apply(requestHeaders, this.options.requestHeaders);
-
-    for (var i = 0; i < requestHeaders.length; i += 2)
-      this.transport.setRequestHeader(requestHeaders[i], requestHeaders[i+1]);
-  },
-
-  onStateChange: function() {
-    var readyState = this.transport.readyState;
-    if (readyState != 1)
-      this.respondToReadyState(this.transport.readyState);
-  },
+    // user-defined headers
+    if (typeof this.options.requestHeaders == 'object') {
+      var extras = this.options.requestHeaders;
 
-  header: function(name) {
-    try {
-      return this.transport.getResponseHeader(name);
-    } catch (e) {}
-  },
+      if (typeof extras.push == 'function')
+        for (var i = 0; i < extras.length; i += 2)
+          headers[extras[i]] = extras[i+1];
+      else
+        $H(extras).each(function(pair) { headers[pair.key] = pair.value });
+    }
 
-  evalJSON: function() {
-    try {
-      return eval('(' + this.header('X-JSON') + ')');
-    } catch (e) {}
+    for (var name in headers)
+      this.transport.setRequestHeader(name, headers[name]);
   },
 
-  evalResponse: function() {
-    try {
-      return eval(this.transport.responseText);
-    } catch (e) {
-      this.dispatchException(e);
-    }
+  success: function() {
+    return !this.transport.status
+        || (this.transport.status >= 200 && this.transport.status < 300);
   },
 
   respondToReadyState: function(readyState) {
-    var event = Ajax.Request.Events[readyState];
+    var state = Ajax.Request.Events[readyState];
     var transport = this.transport, json = this.evalJSON();
 
-    if (event == 'Complete') {
+    if (state == 'Complete') {
       try {
         (this.options['on' + this.transport.status]
-         || this.options['on' + (this.responseIsSuccess() ? 'Success' : 'Failure')]
+         || this.options['on' + (this.success() ? 'Success' : 'Failure')]
          || Prototype.emptyFunction)(transport, json);
       } catch (e) {
         this.dispatchException(e);
       }
-
-      if ((this.header('Content-type') || '').match(/^text\/javascript/i))
-        this.evalResponse();
     }
 
     try {
-      (this.options['on' + event] || Prototype.emptyFunction)(transport, json);
-      Ajax.Responders.dispatch('on' + event, this, transport, json);
+      (this.options['on' + state] || Prototype.emptyFunction)(transport, json);
+      Ajax.Responders.dispatch('on' + state, this, transport, json);
     } catch (e) {
       this.dispatchException(e);
     }
 
-    /* Avoid memory leak in MSIE: clean up the oncomplete event handler */
-    if (event == 'Complete')
+    if (state == 'Complete') {
+      if ((this.getHeader('Content-type') || '').strip().
+        match(/^(text|application)\/(x-)?(java|ecma)script(;.*)?$/i))
+          this.evalResponse();
+
+      // avoid memory leak in MSIE: clean up
       this.transport.onreadystatechange = Prototype.emptyFunction;
+    }
+  },
+
+  getHeader: function(name) {
+    try {
+      return this.transport.getResponseHeader(name);
+    } catch (e) { return null }
+  },
+
+  evalJSON: function() {
+    try {
+      var json = this.getHeader('X-JSON');
+      return json ? eval('(' + json + ')') : null;
+    } catch (e) { return null }
+  },
+
+  evalResponse: function() {
+    try {
+      return eval(this.transport.responseText);
+    } catch (e) {
+      this.dispatchException(e);
+    }
   },
 
   dispatchException: function(exception) {
@@ -783,41 +882,37 @@
 
 Object.extend(Object.extend(Ajax.Updater.prototype, Ajax.Request.prototype), {
   initialize: function(container, url, options) {
-    this.containers = {
-      success: container.success ? $(container.success) : $(container),
-      failure: container.failure ? $(container.failure) :
-        (container.success ? null : $(container))
+    this.container = {
+      success: (container.success || container),
+      failure: (container.failure || (container.success ? null : container))
     }
 
     this.transport = Ajax.getTransport();
     this.setOptions(options);
 
     var onComplete = this.options.onComplete || Prototype.emptyFunction;
-    this.options.onComplete = (function(transport, object) {
+    this.options.onComplete = (function(transport, param) {
       this.updateContent();
-      onComplete(transport, object);
+      onComplete(transport, param);
     }).bind(this);
 
     this.request(url);
   },
 
   updateContent: function() {
-    var receiver = this.responseIsSuccess() ?
-      this.containers.success : this.containers.failure;
+    var receiver = this.container[this.success() ? 'success' : 'failure'];
     var response = this.transport.responseText;
 
-    if (!this.options.evalScripts)
-      response = response.stripScripts();
+    if (!this.options.evalScripts) response = response.stripScripts();
 
-    if (receiver) {
-      if (this.options.insertion) {
+    if (receiver = $(receiver)) {
+      if (this.options.insertion)
         new this.options.insertion(receiver, response);
-      } else {
-        Element.update(receiver, response);
-      }
+      else
+        receiver.update(response);
     }
 
-    if (this.responseIsSuccess()) {
+    if (this.success()) {
       if (this.onComplete)
         setTimeout(this.onComplete.bind(this), 10);
     }
@@ -846,7 +941,7 @@
   },
 
   stop: function() {
-    this.updater.onComplete = undefined;
+    this.updater.options.onComplete = undefined;
     clearTimeout(this.timer);
     (this.onComplete || Prototype.emptyFunction).apply(this, arguments);
   },
@@ -866,24 +961,42 @@
     this.updater = new Ajax.Updater(this.container, this.url, this.options);
   }
 });
-function $() {
-  var results = [], element;
-  for (var i = 0; i < arguments.length; i++) {
-    element = arguments[i];
-    if (typeof element == 'string')
-      element = document.getElementById(element);
-    results.push(Element.extend(element));
+function $(element) {
+  if (arguments.length > 1) {
+    for (var i = 0, elements = [], length = arguments.length; i < length; i++)
+      elements.push($(arguments[i]));
+    return elements;
+  }
+  if (typeof element == 'string')
+    element = document.getElementById(element);
+  return Element.extend(element);
+}
+
+if (Prototype.BrowserFeatures.XPath) {
+  document._getElementsByXPath = function(expression, parentElement) {
+    var results = [];
+    var query = document.evaluate(expression, $(parentElement) || document,
+      null, XPathResult.ORDERED_NODE_SNAPSHOT_TYPE, null);
+    for (var i = 0, len = query.snapshotLength; i < len; i++)
+      results.push(query.snapshotItem(i));
+    return results;
   }
-  return results.length < 2 ? results[0] : results;
 }
 
 document.getElementsByClassName = function(className, parentElement) {
-  var children = ($(parentElement) || document.body).getElementsByTagName('*');
-  return $A(children).inject([], function(elements, child) {
-    if (child.className.match(new RegExp("(^|\\s)" + className + "(\\s|$)")))
-      elements.push(Element.extend(child));
+  if (Prototype.BrowserFeatures.XPath) {
+    var q = ".//*[contains(concat(' ', @class, ' '), ' " + className + " ')]";
+    return document._getElementsByXPath(q, parentElement);
+  } else {
+    var children = ($(parentElement) || document.body).getElementsByTagName('*');
+    var elements = [], child;
+    for (var i = 0, length = children.length; i < length; i++) {
+      child = children[i];
+      if (Element.hasClassName(child, className))
+        elements.push(Element.extend(child));
+    }
     return elements;
-  });
+  }
 }
 
 /*--------------------------------------------------------------------------*/
@@ -893,15 +1006,28 @@
 
 Element.extend = function(element) {
   if (!element) return;
-  if (_nativeExtensions) return element;
+  if (_nativeExtensions || element.nodeType == 3) return element;
 
   if (!element._extended && element.tagName && element != window) {
-    var methods = Element.Methods, cache = Element.extend.cache;
-    for (property in methods) {
+    var methods = Object.clone(Element.Methods), cache = Element.extend.cache;
+
+    if (element.tagName == 'FORM')
+      Object.extend(methods, Form.Methods);
+    if (['INPUT', 'TEXTAREA', 'SELECT'].include(element.tagName))
+      Object.extend(methods, Form.Element.Methods);
+
+    for (var property in methods) {
       var value = methods[property];
       if (typeof value == 'function')
         element[property] = cache.findOrStore(value);
     }
+
+    var methods = Object.clone(Element.Methods.Simulated), cache = Element.extend.cache;
+    for (var property in methods) {
+      var value = methods[property];
+      if ('function' == typeof value && !(property in element))
+        element[property] = cache.findOrStore(value);
+    }
   }
 
   element._extended = true;
@@ -921,35 +1047,33 @@
     return $(element).style.display != 'none';
   },
 
-  toggle: function() {
-    for (var i = 0; i < arguments.length; i++) {
-      var element = $(arguments[i]);
-      Element[Element.visible(element) ? 'hide' : 'show'](element);
-    }
+  toggle: function(element) {
+    element = $(element);
+    Element[Element.visible(element) ? 'hide' : 'show'](element);
+    return element;
   },
 
-  hide: function() {
-    for (var i = 0; i < arguments.length; i++) {
-      var element = $(arguments[i]);
-      element.style.display = 'none';
-    }
+  hide: function(element) {
+    $(element).style.display = 'none';
+    return element;
   },
 
-  show: function() {
-    for (var i = 0; i < arguments.length; i++) {
-      var element = $(arguments[i]);
-      element.style.display = '';
-    }
+  show: function(element) {
+    $(element).style.display = '';
+    return element;
   },
 
   remove: function(element) {
     element = $(element);
     element.parentNode.removeChild(element);
+    return element;
   },
 
   update: function(element, html) {
+    html = typeof html == 'undefined' ? '' : html.toString();
     $(element).innerHTML = html.stripScripts();
     setTimeout(function() {html.evalScripts()}, 10);
+    return element;
   },
 
   replace: function(element, html) {
@@ -963,6 +1087,82 @@
         range.createContextualFragment(html.stripScripts()), element);
     }
     setTimeout(function() {html.evalScripts()}, 10);
+    return element;
+  },
+
+  inspect: function(element) {
+    element = $(element);
+    var result = '<' + element.tagName.toLowerCase();
+    $H({'id': 'id', 'className': 'class'}).each(function(pair) {
+      var property = pair.first(), attribute = pair.last();
+      var value = (element[property] || '').toString();
+      if (value) result += ' ' + attribute + '=' + value.inspect(true);
+    });
+    return result + '>';
+  },
+
+  recursivelyCollect: function(element, property) {
+    element = $(element);
+    var elements = [];
+    while (element = element[property])
+      if (element.nodeType == 1)
+        elements.push(Element.extend(element));
+    return elements;
+  },
+
+  ancestors: function(element) {
+    return $(element).recursivelyCollect('parentNode');
+  },
+
+  descendants: function(element) {
+    element = $(element);
+    return $A(element.getElementsByTagName('*'));
+  },
+
+  previousSiblings: function(element) {
+    return $(element).recursivelyCollect('previousSibling');
+  },
+
+  nextSiblings: function(element) {
+    return $(element).recursivelyCollect('nextSibling');
+  },
+
+  siblings: function(element) {
+    element = $(element);
+    return element.previousSiblings().reverse().concat(element.nextSiblings());
+  },
+
+  match: function(element, selector) {
+    element = $(element);
+    if (typeof selector == 'string')
+      selector = new Selector(selector);
+    return selector.match(element);
+  },
+
+  up: function(element, expression, index) {
+    return Selector.findElement($(element).ancestors(), expression, index);
+  },
+
+  down: function(element, expression, index) {
+    return Selector.findElement($(element).descendants(), expression, index);
+  },
+
+  previous: function(element, expression, index) {
+    return Selector.findElement($(element).previousSiblings(), expression, index);
+  },
+
+  next: function(element, expression, index) {
+    return Selector.findElement($(element).nextSiblings(), expression, index);
+  },
+
+  getElementsBySelector: function() {
+    var args = $A(arguments), element = $(args.shift());
+    return Selector.findChildElements(element, args);
+  },
+
+  getElementsByClassName: function(element, className) {
+    element = $(element);
+    return document.getElementsByClassName(className, element);
   },
 
   getHeight: function(element) {
@@ -976,27 +1176,47 @@
 
   hasClassName: function(element, className) {
     if (!(element = $(element))) return;
-    return Element.classNames(element).include(className);
+    var elementClassName = element.className;
+    if (elementClassName.length == 0) return false;
+    if (elementClassName == className ||
+        elementClassName.match(new RegExp("(^|\\s)" + className + "(\\s|$)")))
+      return true;
+    return false;
   },
 
   addClassName: function(element, className) {
     if (!(element = $(element))) return;
-    return Element.classNames(element).add(className);
+    Element.classNames(element).add(className);
+    return element;
   },
 
   removeClassName: function(element, className) {
     if (!(element = $(element))) return;
-    return Element.classNames(element).remove(className);
+    Element.classNames(element).remove(className);
+    return element;
+  },
+
+  observe: function() {
+    Event.observe.apply(Event, arguments);
+    return $A(arguments).first();
+  },
+
+  stopObserving: function() {
+    Event.stopObserving.apply(Event, arguments);
+    return $A(arguments).first();
   },
 
   // removes whitespace-only text node children
   cleanWhitespace: function(element) {
     element = $(element);
-    for (var i = 0; i < element.childNodes.length; i++) {
-      var node = element.childNodes[i];
+    var node = element.firstChild;
+    while (node) {
+      var nextNode = node.nextSibling;
       if (node.nodeType == 3 && !/\S/.test(node.nodeValue))
-        Element.remove(node);
+        element.removeChild(node);
+      node = nextNode;
     }
+    return element;
   },
 
   empty: function(element) {
@@ -1015,6 +1235,7 @@
     var x = element.x ? element.x : element.offsetLeft,
         y = element.y ? element.y : element.offsetTop;
     window.scrollTo(x, y);
+    return element;
   },
 
   getStyle: function(element, style) {
@@ -1039,6 +1260,7 @@
     element = $(element);
     for (var name in style)
       element.style[name.camelize()] = style[name];
+    return element;
   },
 
   getDimensions: function(element) {
@@ -1075,6 +1297,7 @@
         element.style.left = 0;
       }
     }
+    return element;
   },
 
   undoPositioned: function(element) {
@@ -1087,21 +1310,67 @@
         element.style.bottom =
         element.style.right = '';
     }
+    return element;
   },
 
   makeClipping: function(element) {
     element = $(element);
-    if (element._overflow) return;
-    element._overflow = element.style.overflow;
+    if (element._overflow) return element;
+    element._overflow = element.style.overflow || 'auto';
     if ((Element.getStyle(element, 'overflow') || 'visible') != 'hidden')
       element.style.overflow = 'hidden';
+    return element;
   },
 
   undoClipping: function(element) {
     element = $(element);
-    if (element._overflow) return;
-    element.style.overflow = element._overflow;
-    element._overflow = undefined;
+    if (!element._overflow) return element;
+    element.style.overflow = element._overflow == 'auto' ? '' : element._overflow;
+    element._overflow = null;
+    return element;
+  }
+}
+
+Element.Methods.Simulated = {
+  hasAttribute: function(element, attribute) {
+    return $(element).getAttributeNode(attribute).specified;
+  }
+}
+
+// IE is missing .innerHTML support for TABLE-related elements
+if(document.all){
+  Element.Methods.update = function(element, html) {
+    element = $(element);
+    html = typeof html == 'undefined' ? '' : html.toString();
+    var tagName = element.tagName.toUpperCase();
+    if (['THEAD','TBODY','TR','TD'].indexOf(tagName) > -1) {
+      var div = document.createElement('div');
+      switch (tagName) {
+        case 'THEAD':
+        case 'TBODY':
+          div.innerHTML = '<table><tbody>' +  html.stripScripts() + '</tbody></table>';
+          depth = 2;
+          break;
+        case 'TR':
+          div.innerHTML = '<table><tbody><tr>' +  html.stripScripts() + '</tr></tbody></table>';
+          depth = 3;
+          break;
+        case 'TD':
+          div.innerHTML = '<table><tbody><tr><td>' +  html.stripScripts() + '</td></tr></tbody></table>';
+          depth = 4;
+      }
+      $A(element.childNodes).each(function(node){
+        element.removeChild(node)
+      });
+      depth.times(function(){ div = div.firstChild });
+
+      $A(div.childNodes).each(
+        function(node){ element.appendChild(node) });
+    } else {
+      element.innerHTML = html.stripScripts();
+    }
+    setTimeout(function() {html.evalScripts()}, 10);
+    return element;
   }
 }
 
@@ -1109,27 +1378,38 @@
 
 var _nativeExtensions = false;
 
-if(!HTMLElement && /Konqueror|Safari|KHTML/.test(navigator.userAgent)) {
-  var HTMLElement = {}
-  HTMLElement.prototype = document.createElement('div').__proto__;
-}
+if(/Konqueror|Safari|KHTML/.test(navigator.userAgent))
+  ['', 'Form', 'Input', 'TextArea', 'Select'].each(function(tag) {
+    var className = 'HTML' + tag + 'Element';
+    if(window[className]) return;
+    var klass = window[className] = {};
+    klass.prototype = document.createElement(tag ? tag.toLowerCase() : 'div').__proto__;
+  });
 
 Element.addMethods = function(methods) {
   Object.extend(Element.Methods, methods || {});
 
-  if(typeof HTMLElement != 'undefined') {
-    var methods = Element.Methods, cache = Element.extend.cache;
-    for (property in methods) {
+  function copy(methods, destination, onlyIfAbsent) {
+    onlyIfAbsent = onlyIfAbsent || false;
+    var cache = Element.extend.cache;
+    for (var property in methods) {
       var value = methods[property];
-      if (typeof value == 'function')
-        HTMLElement.prototype[property] = cache.findOrStore(value);
+      if (!onlyIfAbsent || !(property in destination))
+        destination[property] = cache.findOrStore(value);
     }
+  }
+
+  if (typeof HTMLElement != 'undefined') {
+    copy(Element.Methods, HTMLElement.prototype);
+    copy(Element.Methods.Simulated, HTMLElement.prototype, true);
+    copy(Form.Methods, HTMLFormElement.prototype);
+    [HTMLInputElement, HTMLTextAreaElement, HTMLSelectElement].each(function(klass) {
+      copy(Form.Element.Methods, klass.prototype);
+    });
     _nativeExtensions = true;
   }
 }
 
-Element.addMethods();
-
 var Toggle = new Object();
 Toggle.display = Element.toggle;
 
@@ -1248,18 +1528,16 @@
 
   add: function(classNameToAdd) {
     if (this.include(classNameToAdd)) return;
-    this.set(this.toArray().concat(classNameToAdd).join(' '));
+    this.set($A(this).concat(classNameToAdd).join(' '));
   },
 
   remove: function(classNameToRemove) {
     if (!this.include(classNameToRemove)) return;
-    this.set(this.select(function(className) {
-      return className != classNameToRemove;
-    }).join(' '));
+    this.set($A(this).without(classNameToRemove).join(' '));
   },
 
   toString: function() {
-    return this.toArray().join(' ');
+    return $A(this).join(' ');
   }
 }
 
@@ -1354,7 +1632,7 @@
     scope = (scope || document).getElementsByTagName(this.params.tagName || '*');
 
     var results = [];
-    for (var i = 0; i < scope.length; i++)
+    for (var i = 0, length = scope.length; i < length; i++)
       if (this.match(element = scope[i]))
         results.push(Element.extend(element));
 
@@ -1366,68 +1644,60 @@
   }
 }
 
+Object.extend(Selector, {
+  matchElements: function(elements, expression) {
+    var selector = new Selector(expression);
+    return elements.select(selector.match.bind(selector)).collect(Element.extend);
+  },
+
+  findElement: function(elements, expression, index) {
+    if (typeof expression == 'number') index = expression, expression = false;
+    return Selector.matchElements(elements, expression || '*')[index || 0];
+  },
+
+  findChildElements: function(element, expressions) {
+    return expressions.map(function(expression) {
+      return expression.strip().split(/\s+/).inject([null], function(results, expr) {
+        var selector = new Selector(expr);
+        return results.inject([], function(elements, result) {
+          return elements.concat(selector.findElements(result || element));
+        });
+      });
+    }).flatten();
+  }
+});
+
 function $$() {
-  return $A(arguments).map(function(expression) {
-    return expression.strip().split(/\s+/).inject([null], function(results, expr) {
-      var selector = new Selector(expr);
-      return results.map(selector.findElements.bind(selector)).flatten();
-    });
-  }).flatten();
+  return Selector.findChildElements(document, $A(arguments));
 }
-var Field = {
-  clear: function() {
-    for (var i = 0; i < arguments.length; i++)
-      $(arguments[i]).value = '';
-  },
-
-  focus: function(element) {
-    $(element).focus();
-  },
-
-  present: function() {
-    for (var i = 0; i < arguments.length; i++)
-      if ($(arguments[i]).value == '') return false;
-    return true;
-  },
-
-  select: function(element) {
-    $(element).select();
+var Form = {
+  reset: function(form) {
+    $(form).reset();
+    return form;
   },
 
-  activate: function(element) {
-    element = $(element);
-    element.focus();
-    if (element.select)
-      element.select();
+  serializeElements: function(elements) {
+    return elements.inject([], function(queryComponents, element) {
+      var queryComponent = Form.Element.serialize(element);
+      if (queryComponent) queryComponents.push(queryComponent);
+      return queryComponents;
+    }).join('&');
   }
-}
-
-/*--------------------------------------------------------------------------*/
+};
 
-var Form = {
+Form.Methods = {
   serialize: function(form) {
-    var elements = Form.getElements($(form));
-    var queryComponents = new Array();
-
-    for (var i = 0; i < elements.length; i++) {
-      var queryComponent = Form.Element.serialize(elements[i]);
-      if (queryComponent)
-        queryComponents.push(queryComponent);
-    }
-
-    return queryComponents.join('&');
+    return Form.serializeElements($(form).getElements());
   },
 
   getElements: function(form) {
-    form = $(form);
-    var elements = new Array();
-
-    for (var tagName in Form.Element.Serializers) {
-      var tagElements = form.getElementsByTagName(tagName);
-      for (var j = 0; j < tagElements.length; j++)
-        elements.push(tagElements[j]);
-    }
-    return elements;
+    return $A($(form).getElementsByTagName('*')).inject([],
+      function(elements, child) {
+        if (Form.Element.Serializers[child.tagName.toLowerCase()])
+          elements.push(Element.extend(child));
+        return elements;
+      }
+    );
   },
 
   getInputs: function(form, typeName, name) {
@@ -1438,53 +1708,68 @@
       return inputs;
 
     var matchingInputs = new Array();
-    for (var i = 0; i < inputs.length; i++) {
+    for (var i = 0, length = inputs.length; i < length; i++) {
       var input = inputs[i];
       if ((typeName && input.type != typeName) ||
           (name && input.name != name))
         continue;
-      matchingInputs.push(input);
+      matchingInputs.push(Element.extend(input));
     }
 
     return matchingInputs;
   },
 
   disable: function(form) {
-    var elements = Form.getElements(form);
-    for (var i = 0; i < elements.length; i++) {
-      var element = elements[i];
+    form = $(form);
+    form.getElements().each(function(element) {
       element.blur();
       element.disabled = 'true';
-    }
+    });
+    return form;
   },
 
   enable: function(form) {
-    var elements = Form.getElements(form);
-    for (var i = 0; i < elements.length; i++) {
-      var element = elements[i];
+    form = $(form);
+    form.getElements().each(function(element) {
       element.disabled = '';
-    }
+    });
+    return form;
   },
 
   findFirstElement: function(form) {
-    return Form.getElements(form).find(function(element) {
+    return $(form).getElements().find(function(element) {
       return element.type != 'hidden' && !element.disabled &&
         ['input', 'select', 'textarea'].include(element.tagName.toLowerCase());
     });
   },
 
   focusFirstElement: function(form) {
-    Field.activate(Form.findFirstElement(form));
+    form = $(form);
+    form.findFirstElement().activate();
+    return form;
+  }
+}
+
+Object.extend(Form, Form.Methods);
+
+/*--------------------------------------------------------------------------*/
+
+Form.Element = {
+  focus: function(element) {
+    $(element).focus();
+    return element;
   },
 
-  reset: function(form) {
-    $(form).reset();
+  select: function(element) {
+    $(element).select();
+    return element;
   }
 }
 
-Form.Element = {
+Form.Element.Methods = {
   serialize: function(element) {
     element = $(element);
+    if (element.disabled) return '';
     var method = element.tagName.toLowerCase();
     var parameter = Form.Element.Serializers[method](element);
 
@@ -1508,20 +1793,52 @@
 
     if (parameter)
       return parameter[1];
+  },
+
+  clear: function(element) {
+    $(element).value = '';
+    return element;
+  },
+
+  present: function(element) {
+    return $(element).value != '';
+  },
+
+  activate: function(element) {
+    element = $(element);
+    element.focus();
+    if (element.select)
+      element.select();
+    return element;
+  },
+
+  disable: function(element) {
+    element = $(element);
+    element.disabled = true;
+    return element;
+  },
+
+  enable: function(element) {
+    element = $(element);
+    element.blur();
+    element.disabled = false;
+    return element;
   }
 }
 
+Object.extend(Form.Element, Form.Element.Methods);
+var Field = Form.Element;
+
+/*--------------------------------------------------------------------------*/
+
 Form.Element.Serializers = {
   input: function(element) {
     switch (element.type.toLowerCase()) {
-      case 'submit':
-      case 'hidden':
-      case 'password':
-      case 'text':
-        return Form.Element.Serializers.textarea(element);
       case 'checkbox':
       case 'radio':
         return Form.Element.Serializers.inputSelector(element);
+      default:
+        return Form.Element.Serializers.textarea(element);
     }
     return false;
   },
@@ -1543,8 +1860,9 @@
   selectOne: function(element) {
     var value = '', opt, index = element.selectedIndex;
     if (index >= 0) {
-      opt = element.options[index];
-      value = opt.value || opt.text;
+      opt = Element.extend(element.options[index]);
+      // Uses the new potential extension if hasAttribute isn't native.
+      value = opt.hasAttribute('value') ? opt.value : opt.text;
     }
     return [element.name, value];
   },
@@ -1552,9 +1870,10 @@
   selectMany: function(element) {
     var value = [];
     for (var i = 0; i < element.length; i++) {
-      var opt = element.options[i];
+      var opt = Element.extend(element.options[i]);
       if (opt.selected)
-        value.push(opt.value || opt.text);
+        // Uses the new potential extension if hasAttribute isn't native.
+        value.push(opt.hasAttribute('value') ? opt.value : opt.text);
     }
     return [element.name, value];
   }
@@ -1628,9 +1947,7 @@
   },
 
   registerFormCallbacks: function() {
-    var elements = Form.getElements(this.element);
-    for (var i = 0; i < elements.length; i++)
-      this.registerCallback(elements[i]);
+    Form.getElements(this.element).each(this.registerCallback.bind(this));
   },
 
   registerCallback: function(element) {
@@ -1640,11 +1957,7 @@
         case 'radio':
           Event.observe(element, 'click', this.onElementEvent.bind(this));
           break;
-        case 'password':
-        case 'text':
-        case 'textarea':
-        case 'select-one':
-        case 'select-multiple':
+        default:
           Event.observe(element, 'change', this.onElementEvent.bind(this));
           break;
       }
@@ -1679,6 +1992,10 @@
   KEY_RIGHT:    39,
   KEY_DOWN:     40,
   KEY_DELETE:   46,
+  KEY_HOME:     36,
+  KEY_END:      35,
+  KEY_PAGEUP:   33,
+  KEY_PAGEDOWN: 34,
 
   element: function(event) {
     return event.target || event.srcElement;
@@ -1734,7 +2051,7 @@
 
   unloadCache: function() {
     if (!Event.observers) return;
-    for (var i = 0; i < Event.observers.length; i++) {
+    for (var i = 0, length = Event.observers.length; i < length; i++) {
       Event.stopObserving.apply(this, Event.observers[i]);
       Event.observers[i][0] = null;
     }
@@ -1742,7 +2059,7 @@
   },
 
   observe: function(element, name, observer, useCapture) {
-    var element = $(element);
+    element = $(element);
     useCapture = useCapture || false;
 
     if (name == 'keypress' &&
@@ -1750,11 +2067,11 @@
         || element.attachEvent))
       name = 'keydown';
 
-    this._observeAndCache(element, name, observer, useCapture);
+    Event._observeAndCache(element, name, observer, useCapture);
   },
 
   stopObserving: function(element, name, observer, useCapture) {
-    var element = $(element);
+    element = $(element);
     useCapture = useCapture || false;
 
     if (name == 'keypress' &&
@@ -1765,7 +2082,9 @@
     if (element.removeEventListener) {
       element.removeEventListener(name, observer, useCapture);
     } else if (element.detachEvent) {
-      element.detachEvent('on' + name, observer);
+      try {
+        element.detachEvent('on' + name, observer);
+      } catch (e) {}
     }
   }
 });
@@ -1819,7 +2138,8 @@
       valueL += element.offsetLeft || 0;
       element = element.offsetParent;
       if (element) {
-        p = Element.getStyle(element, 'position');
+        if(element.tagName=='BODY') break;
+        var p = Element.getStyle(element, 'position');
         if (p == 'relative' || p == 'absolute') break;
       }
     } while (element);
@@ -1875,17 +2195,6 @@
         element.offsetWidth;
   },
 
-  clone: function(source, target) {
-    source = $(source);
-    target = $(target);
-    target.style.position = 'absolute';
-    var offsets = this.cumulativeOffset(source);
-    target.style.top    = offsets[1] + 'px';
-    target.style.left   = offsets[0] + 'px';
-    target.style.width  = source.offsetWidth + 'px';
-    target.style.height = source.offsetHeight + 'px';
-  },
-
   page: function(forElement) {
     var valueT = 0, valueL = 0;
 
@@ -1902,8 +2211,10 @@
 
     element = forElement;
     do {
-      valueT -= element.scrollTop  || 0;
-      valueL -= element.scrollLeft || 0;
+      if (!window.opera || element.tagName=='BODY') {
+        valueT -= element.scrollTop  || 0;
+        valueL -= element.scrollLeft || 0;
+      }
     } while (element = element.parentNode);
 
     return [valueL, valueT];
@@ -2003,4 +2314,6 @@
 
     return [valueL, valueT];
   }
-}
\ No newline at end of file
+}
+
+Element.addMethods();
\ No newline at end of file

From gotcha at codespeak.net  Fri Jan  5 14:15:57 2007
From: gotcha at codespeak.net (gotcha at codespeak.net)
Date: Fri,  5 Jan 2007 14:15:57 +0100 (CET)
Subject: [KSS-checkins] r36166 - in kukit/kss.core/trunk/plugins: .
	draganddrop draganddrop/3rd_party draganddrop/browser
Message-ID: <20070105131557.1F09110076@code0.codespeak.net>

Author: gotcha
Date: Fri Jan  5 14:15:53 2007
New Revision: 36166

Added:
   kukit/kss.core/trunk/plugins/draganddrop/
   kukit/kss.core/trunk/plugins/draganddrop/3rd_party/
   kukit/kss.core/trunk/plugins/draganddrop/3rd_party/dragdrop.js
   kukit/kss.core/trunk/plugins/draganddrop/__init__.py
   kukit/kss.core/trunk/plugins/draganddrop/browser/
   kukit/kss.core/trunk/plugins/draganddrop/browser/kss_dragdrop.js
   kukit/kss.core/trunk/plugins/draganddrop/configure.zcml
Modified:
   kukit/kss.core/trunk/plugins/configure.zcml
Log:
first steps for scriptaculous drag and drop

Modified: kukit/kss.core/trunk/plugins/configure.zcml
==============================================================================
--- kukit/kss.core/trunk/plugins/configure.zcml	(original)
+++ kukit/kss.core/trunk/plugins/configure.zcml	Fri Jan  5 14:15:53 2007
@@ -13,4 +13,7 @@
   <!-- The scriptaculous effects -->
   <include package=".effects" />
 
+  <!-- The drag and drop -->
+  <include package=".draganddrop" />
+
 </configure>

Added: kukit/kss.core/trunk/plugins/draganddrop/3rd_party/dragdrop.js
==============================================================================
--- (empty file)
+++ kukit/kss.core/trunk/plugins/draganddrop/3rd_party/dragdrop.js	Fri Jan  5 14:15:53 2007
@@ -0,0 +1,946 @@
+// script.aculo.us dragdrop.js v1.6.5, Wed Nov 08 14:17:49 CET 2006
+
+// Copyright (c) 2005, 2006 Thomas Fuchs (http://script.aculo.us, http://mir.aculo.us)
+//           (c) 2005, 2006 Sammi Williams (http://www.oriontransfer.co.nz, sammi at oriontransfer.co.nz)
+// 
+// script.aculo.us is freely distributable under the terms of an MIT-style license.
+// For details, see the script.aculo.us web site: http://script.aculo.us/
+
+if(typeof Effect == 'undefined')
+  throw("dragdrop.js requires including script.aculo.us' effects.js library");
+
+var Droppables = {
+  drops: [],
+
+  remove: function(element) {
+    this.drops = this.drops.reject(function(d) { return d.element==$(element) });
+  },
+
+  add: function(element) {
+    element = $(element);
+    var options = Object.extend({
+      greedy:     true,
+      hoverclass: null,
+      tree:       false
+    }, arguments[1] || {});
+
+    // cache containers
+    if(options.containment) {
+      options._containers = [];
+      var containment = options.containment;
+      if((typeof containment == 'object') && 
+        (containment.constructor == Array)) {
+        containment.each( function(c) { options._containers.push($(c)) });
+      } else {
+        options._containers.push($(containment));
+      }
+    }
+    
+    if(options.accept) options.accept = [options.accept].flatten();
+
+    Element.makePositioned(element); // fix IE
+    options.element = element;
+
+    this.drops.push(options);
+  },
+  
+  findDeepestChild: function(drops) {
+    deepest = drops[0];
+      
+    for (i = 1; i < drops.length; ++i)
+      if (Element.isParent(drops[i].element, deepest.element))
+        deepest = drops[i];
+    
+    return deepest;
+  },
+
+  isContained: function(element, drop) {
+    var containmentNode;
+    if(drop.tree) {
+      containmentNode = element.treeNode; 
+    } else {
+      containmentNode = element.parentNode;
+    }
+    return drop._containers.detect(function(c) { return containmentNode == c });
+  },
+  
+  isAffected: function(point, element, drop) {
+    return (
+      (drop.element!=element) &&
+      ((!drop._containers) ||
+        this.isContained(element, drop)) &&
+      ((!drop.accept) ||
+        (Element.classNames(element).detect( 
+          function(v) { return drop.accept.include(v) } ) )) &&
+      Position.within(drop.element, point[0], point[1]) );
+  },
+
+  deactivate: function(drop) {
+    if(drop.hoverclass)
+      Element.removeClassName(drop.element, drop.hoverclass);
+    this.last_active = null;
+  },
+
+  activate: function(drop) {
+    if(drop.hoverclass)
+      Element.addClassName(drop.element, drop.hoverclass);
+    this.last_active = drop;
+  },
+
+  show: function(point, element) {
+    if(!this.drops.length) return;
+    var affected = [];
+    
+    if(this.last_active) this.deactivate(this.last_active);
+    this.drops.each( function(drop) {
+      if(Droppables.isAffected(point, element, drop))
+        affected.push(drop);
+    });
+        
+    if(affected.length>0) {
+      drop = Droppables.findDeepestChild(affected);
+      Position.within(drop.element, point[0], point[1]);
+      if(drop.onHover)
+        drop.onHover(element, drop.element, Position.overlap(drop.overlap, drop.element));
+      
+      Droppables.activate(drop);
+    }
+  },
+
+  fire: function(event, element) {
+    if(!this.last_active) return;
+    Position.prepare();
+
+    if (this.isAffected([Event.pointerX(event), Event.pointerY(event)], element, this.last_active)) {
+      if (this.last_active.onDrop) { 
+        this.last_active.onDrop(element, this.last_active.element, event);
+        }
+      }  
+  },
+
+  reset: function() {
+    if(this.last_active)
+      this.deactivate(this.last_active);
+  }
+}
+
+var Draggables = {
+  drags: [],
+  observers: [],
+  
+  register: function(draggable) {
+    if(this.drags.length == 0) {
+      this.eventMouseUp   = this.endDrag.bindAsEventListener(this);
+      this.eventMouseMove = this.updateDrag.bindAsEventListener(this);
+      this.eventKeypress  = this.keyPress.bindAsEventListener(this);
+      
+      Event.observe(document, "mouseup", this.eventMouseUp);
+      Event.observe(document, "mousemove", this.eventMouseMove);
+      Event.observe(document, "keypress", this.eventKeypress);
+    }
+    this.drags.push(draggable);
+  },
+  
+  unregister: function(draggable) {
+    this.drags = this.drags.reject(function(d) { return d==draggable });
+    if(this.drags.length == 0) {
+      Event.stopObserving(document, "mouseup", this.eventMouseUp);
+      Event.stopObserving(document, "mousemove", this.eventMouseMove);
+      Event.stopObserving(document, "keypress", this.eventKeypress);
+    }
+  },
+  
+  activate: function(draggable) {
+    if(draggable.options.delay) { 
+      this._timeout = setTimeout(function() { 
+        Draggables._timeout = null; 
+        window.focus(); 
+        Draggables.activeDraggable = draggable; 
+      }.bind(this), draggable.options.delay); 
+    } else {
+      window.focus(); // allows keypress events if window isn't currently focused, fails for Safari
+      this.activeDraggable = draggable;
+    }
+  },
+  
+  deactivate: function() {
+    this.activeDraggable = null;
+  },
+  
+  updateDrag: function(event) {
+    if(!this.activeDraggable) return;
+    var pointer = [Event.pointerX(event), Event.pointerY(event)];
+    // Mozilla-based browsers fire successive mousemove events with
+    // the same coordinates, prevent needless redrawing (moz bug?)
+    if(this._lastPointer && (this._lastPointer.inspect() == pointer.inspect())) return;
+    this._lastPointer = pointer;
+    
+    this.activeDraggable.updateDrag(event, pointer);
+  },
+  
+  endDrag: function(event) {
+    if(this._timeout) { 
+      clearTimeout(this._timeout); 
+      this._timeout = null; 
+    }
+    if(!this.activeDraggable) retu