[KSS-checkins] r49495 - in kukit/kss.core/branch/finish-closures/kss/core: pluginregistry/browser plugins/core/demo plugins/core/demo/coreplugin

gotcha at codespeak.net gotcha at codespeak.net
Fri Dec 7 09:43:34 CET 2007


Author: gotcha
Date: Fri Dec  7 09:43:27 2007
New Revision: 49495

Modified:
   kukit/kss.core/branch/finish-closures/kss/core/pluginregistry/browser/develui.css
   kukit/kss.core/branch/finish-closures/kss/core/plugins/core/demo/coreplugin/kss_evt_preventbubbling.kss
   kukit/kss.core/branch/finish-closures/kss/core/plugins/core/demo/coreplugin/kss_evt_preventbubbling.pt
   kukit/kss.core/branch/finish-closures/kss/core/plugins/core/demo/error_handling.kss
   kukit/kss.core/branch/finish-closures/kss/core/plugins/core/demo/error_handling.pt
   kukit/kss.core/branch/finish-closures/kss/core/plugins/core/demo/more_selectors.kss
   kukit/kss.core/branch/finish-closures/kss/core/plugins/core/demo/more_selectors.pt
Log:
simplify logger; move it to a macro

Modified: kukit/kss.core/branch/finish-closures/kss/core/pluginregistry/browser/develui.css
==============================================================================
--- kukit/kss.core/branch/finish-closures/kss/core/pluginregistry/browser/develui.css	(original)
+++ kukit/kss.core/branch/finish-closures/kss/core/pluginregistry/browser/develui.css	Fri Dec  7 09:43:27 2007
@@ -14,7 +14,7 @@
   font-size: 80%;
 }
 
-#global-links ul {
+#global-links ul, #log-reset {
   display: table-row;
 }
 
@@ -22,7 +22,7 @@
   display: table-cell;
 }
 
-#global-links a {
+#global-links a, #log-reset a {
   display: block;
   padding: 0.25em;
   margin: 0.25em;
@@ -89,6 +89,14 @@
   padding : 1em;
 }
 
+.log {
+  margin: 0;
+  padding: 0.4em;
+  background: #CCC;
+  color: gray;
+  font-style: italic;
+}
+
 .production, .error {
   color: red;
 }

Modified: kukit/kss.core/branch/finish-closures/kss/core/plugins/core/demo/coreplugin/kss_evt_preventbubbling.kss
==============================================================================
--- kukit/kss.core/branch/finish-closures/kss/core/plugins/core/demo/coreplugin/kss_evt_preventbubbling.kss	(original)
+++ kukit/kss.core/branch/finish-closures/kss/core/plugins/core/demo/coreplugin/kss_evt_preventbubbling.kss	Fri Dec  7 09:43:27 2007
@@ -1,30 +1,27 @@
 #parent-node:click {
     evt-click-allowbubbling: true;
     evt-click-preventdefault: true;
-    action-client: insertHTMLBefore;
-    insertHTMLBefore-kssSelector: #log-end;
-    insertHTMLBefore-html: "containing DIV. ";
+    action-client: insertHTMLAsLastChild;
+    insertHTMLAsLastChild-kssSelector: #logger;
+    insertHTMLAsLastChild-html: "containing DIV. ";
 }
 
 #bubbling-node:click {
     evt-click-preventdefault: true;
-    action-client: insertHTMLBefore;
-    insertHTMLBefore-kssSelector: #log-end;
-    insertHTMLBefore-html: "bubbling P. ";
+    action-client: insertHTMLAsLastChild;
+    insertHTMLAsLastChild-kssSelector: #logger;
+    insertHTMLAsLastChild-html: "bubbling P. ";
 }
 
 #not-bubbling-node:click {
     evt-click-preventdefault: true;
     evt-click-preventbubbling: true;
-    action-client: insertHTMLBefore;
-    insertHTMLBefore-kssSelector: #log-end;
-    insertHTMLBefore-html: "not bubbling P. ";
+    action-client: insertHTMLAsLastChild;
+    insertHTMLAsLastChild-kssSelector: #logger;
+    insertHTMLAsLastChild-html: "not bubbling P. ";
 }
 
 #log-reset a:click, #log-reset:click {
     action-client: clearChildNodes;
     clearChildNodes-kssSelector: #logger;
-    action-client: insertHTMLAsLastChild;
-    insertHTMLAsLastChild-kssSelector: #logger;
-    insertHTMLAsLastChild-html: "<p id='log-end'></p>";
 }

Modified: kukit/kss.core/branch/finish-closures/kss/core/plugins/core/demo/coreplugin/kss_evt_preventbubbling.pt
==============================================================================
--- kukit/kss.core/branch/finish-closures/kss/core/plugins/core/demo/coreplugin/kss_evt_preventbubbling.pt	(original)
+++ kukit/kss.core/branch/finish-closures/kss/core/plugins/core/demo/coreplugin/kss_evt_preventbubbling.pt	Fri Dec  7 09:43:27 2007
@@ -40,11 +40,6 @@
       Some text
       </p>
     </div>
-    <h1>Log</h1>
-    <p id="log-reset"><a>Reset log</a></p>
-    <p class="log">You clicked :</p>
-    <div id="logger" class="log">
-      <p id='log-end'></p>
-    </div>
+    <p metal:use-macro="context/@@body_macros/logger">logger</p>
   </body>
 </html>

Modified: kukit/kss.core/branch/finish-closures/kss/core/plugins/core/demo/error_handling.kss
==============================================================================
--- kukit/kss.core/branch/finish-closures/kss/core/plugins/core/demo/error_handling.kss	(original)
+++ kukit/kss.core/branch/finish-closures/kss/core/plugins/core/demo/error_handling.kss	Fri Dec  7 09:43:27 2007
@@ -13,9 +13,9 @@
 
 
 .handled:click {
-    errTest-error:  insertHTMLBefore;
-    insertHTMLBefore-kssSelector: #log-end;
-    insertHTMLBefore-html: "Error handler activated.";
+    errTest-error:  insertHTMLAsLastChild;
+    insertHTMLAsLastChild-kssSelector: #logger;
+    insertHTMLAsLastChild-html: "Error handler activated.";
 }
 
 /* Spinner control 
@@ -41,7 +41,4 @@
 #log-reset a:click, #log-reset:click {
     action-client: clearChildNodes;
     clearChildNodes-kssSelector: #logger;
-    action-client: insertHTMLAsLastChild;
-    insertHTMLAsLastChild-kssSelector: #logger;
-    insertHTMLAsLastChild-html: "<p id='log-end'></p>";
 }

Modified: kukit/kss.core/branch/finish-closures/kss/core/plugins/core/demo/error_handling.pt
==============================================================================
--- kukit/kss.core/branch/finish-closures/kss/core/plugins/core/demo/error_handling.pt	(original)
+++ kukit/kss.core/branch/finish-closures/kss/core/plugins/core/demo/error_handling.pt	Fri Dec  7 09:43:27 2007
@@ -64,12 +64,6 @@
     their number (currently in 4): click like crazy on the buttons and you will see that
     your server will not get hogged. More will be told about this topic in the upcoming
     documentation.</p>
-    <h1>Log</h1>
-    <p id="log-reset"><a>Reset log</a></p>
-    <p class="log">Error log :</p>
-    <div id="logger" class="log">
-      <p id='log-end'></p>
-    </div>
-
+    <p metal:use-macro="context/@@body_macros/logger">logger</p>
   </body>
 </html>

Modified: kukit/kss.core/branch/finish-closures/kss/core/plugins/core/demo/more_selectors.kss
==============================================================================
--- kukit/kss.core/branch/finish-closures/kss/core/plugins/core/demo/more_selectors.kss	(original)
+++ kukit/kss.core/branch/finish-closures/kss/core/plugins/core/demo/more_selectors.kss	Fri Dec  7 09:43:27 2007
@@ -1,9 +1,6 @@
 #log-reset a:click, #log-reset:click {
     action-client: clearChildNodes;
     clearChildNodes-kssSelector: #logger;
-    action-client: insertHTMLAsLastChild;
-    insertHTMLAsLastChild-kssSelector: #logger;
-    insertHTMLAsLastChild-html: "<p id='log-end'></p>";
 }
 
 #button-one:annoyclicker-click(annoyMe) {
@@ -17,9 +14,9 @@
 }
 
 behaviour:annoyclicker-annoy(annoyMe) {
-    action-client: insertHTMLBefore;
-    insertHTMLBefore-kssSelector: #log-end;
-    insertHTMLBefore-html: "Keep trying until you get there. ";
+    action-client: insertHTMLAsLastChild;
+    insertHTMLAsLastChild-kssSelector: #logger;
+    insertHTMLAsLastChild-html: "Keep trying until you get there. ";
 }
 
 #button-two:annoyclicker-click(annoyYou) {
@@ -32,7 +29,7 @@
 }
 
 behaviour:annoyclicker-annoy(annoyYou) {
-    action-client: insertHTMLBefore;
-    insertHTMLBefore-kssSelector: #log-end;
-    insertHTMLBefore-html: "Keep trying until you get there, from the second button. ";
+    action-client: insertHTMLAsLastChild;
+    insertHTMLAsLastChild-kssSelector: #logger;
+    insertHTMLAsLastChild-html: "Keep trying until you get there, from the second button. ";
 }

Modified: kukit/kss.core/branch/finish-closures/kss/core/plugins/core/demo/more_selectors.pt
==============================================================================
--- kukit/kss.core/branch/finish-closures/kss/core/plugins/core/demo/more_selectors.pt	(original)
+++ kukit/kss.core/branch/finish-closures/kss/core/plugins/core/demo/more_selectors.pt	Fri Dec  7 09:43:27 2007
@@ -39,11 +39,6 @@
     </div>
     <input type="button" id="button-one" value="Do it"/>
     <input type="button" id="button-two" value="Do it again"/>
-    <h1>Log</h1>
-    <p id="log-reset"><a>Reset log</a></p>
-    <p class="log">You clicked :</p>
-    <div id="logger" class="log">
-      <p id='log-end'></p>
-    </div>
+    <p metal:use-macro="context/@@body_macros/logger">logger</p>
   </body>
 </html>


More information about the Kukit-checkins mailing list