[KSS-checkins] r45742 - kukit/kukit.js/branch/gotcha-code-cleanup/kukit

gotcha at codespeak.net gotcha at codespeak.net
Thu Aug 16 18:45:33 CEST 2007


Author: gotcha
Date: Thu Aug 16 18:45:32 2007
New Revision: 45742

Modified:
   kukit/kukit.js/branch/gotcha-code-cleanup/kukit/oper.js
   kukit/kukit.js/branch/gotcha-code-cleanup/kukit/resourcedata.js
   kukit/kukit.js/branch/gotcha-code-cleanup/kukit/serveraction.js
Log:
coherent naming for kss parameters

Modified: kukit/kukit.js/branch/gotcha-code-cleanup/kukit/oper.js
==============================================================================
--- kukit/kukit.js/branch/gotcha-code-cleanup/kukit/oper.js	(original)
+++ kukit/kukit.js/branch/gotcha-code-cleanup/kukit/oper.js	Thu Aug 16 18:45:32 2007
@@ -119,11 +119,11 @@
     // Check kss action parms
     var nodes = null;
     // XXX TODO this should be refactored with parms constraint checking
-    for (key in this.kssParameters) {
+    for (key in this.kssParms) {
         switch (key) {
             case 'kssSelector': {
                 // The value already contains the results
-                nodes = this.kssParameters[key];
+                nodes = this.kssParms[key];
             } break;
             default: {
 ;;;            kukit.E = 'Wrong parameter : [' + key + '] starts with ';
@@ -168,7 +168,7 @@
 
 kukit.op.Oper.prototype.executeDefaultAction = function(name, optional) {
     // Check kss action parms
-;;; for (key in this.kssParameters) {
+;;; for (key in this.kssParms) {
 ;;;     kukit.E = 'Wrong parameter : [' + key + '] starts with "kss";';
 ;;;     kukit.E += ' normal parms (that do not start with kss)';
 ;;;     kukit.E += ' only are allowed in action-default keys.';
@@ -200,7 +200,7 @@
 };
 
 kukit.op.Oper.prototype.executeServerAction = function(name) {
-;;; for (key in this.kssParameters) {
+;;; for (key in this.kssParms) {
 ;;;     if (key == 'kssUrl') {
 ;;;         // Value will be evaluated.
 ;;;     } else if (key == 'kssSubmitForm') {

Modified: kukit/kukit.js/branch/gotcha-code-cleanup/kukit/resourcedata.js
==============================================================================
--- kukit/kukit.js/branch/gotcha-code-cleanup/kukit/resourcedata.js	(original)
+++ kukit/kukit.js/branch/gotcha-code-cleanup/kukit/resourcedata.js	Thu Aug 16 18:45:32 2007
@@ -512,7 +512,7 @@
     // handled as appropriate.
     // A cloned oper is returned.
     var parms = {};
-    var kssParameters = {};
+    var kssParms = {};
     // Make sure we have defaultParameters on oper
     if (typeof(oper.defaultParameters) == 'undefined') {
         oper.defaultParameters = {};
@@ -520,8 +520,8 @@
     for (var key in this.parms) {
         var kssvalue = this.parms[key]; 
         if (key.match(/^kss/)) {
-            // kssXxx parms are separated to kssParameters.
-            kssvalue.evaluate(kssParameters, key, oper.node,
+            // kssXxx parms are separated to kssParms.
+            kssvalue.evaluate(kssParms, key, oper.node,
                 oper.defaultParameters); 
         } else {
             // evaluate the method parms into parms
@@ -531,7 +531,7 @@
     }
     var anOper = oper.clone({
             'parms': parms,
-            'kssParameters': kssParameters,
+            'kssParms': kssParms,
             'action': this
         });
     return anOper;

Modified: kukit/kukit.js/branch/gotcha-code-cleanup/kukit/serveraction.js
==============================================================================
--- kukit/kukit.js/branch/gotcha-code-cleanup/kukit/serveraction.js	(original)
+++ kukit/kukit.js/branch/gotcha-code-cleanup/kukit/serveraction.js	Thu Aug 16 18:45:32 2007
@@ -20,7 +20,7 @@
 kukit.sa = {};
 
 kukit.sa.ServerAction = function(name, oper) {
-    this.url = oper.kssParameters.kssUrl;
+    this.url = oper.kssParms.kssUrl;
     if (typeof(this.url) == 'undefined') {
         this.url = name;
     }
@@ -80,7 +80,7 @@
     // also add the parms that result from submitting an entire form.
     // This is, unlike the normal parms, is a list. Keys and values are
     // added at the end of the query, without mangling names.
-    var submitForm = this.oper.kssParameters.kssSubmitForm;
+    var submitForm = this.oper.kssParms.kssSubmitForm;
     if (submitForm) {
         for (var i=0; i<submitForm.length; i++) {
             var item = submitForm[i];


More information about the Kukit-checkins mailing list