From reebalazs at codespeak.net Sat Oct 7 09:59:29 2006
From: reebalazs at codespeak.net (reebalazs at codespeak.net)
Date: Sat, 7 Oct 2006 09:59:29 +0200 (CEST)
Subject: [Kukit-checkins] r32978 - kukit/azax/trunk/plugins/effects/browser
Message-ID: <20061007075929.879D110068@code0.codespeak.net>
Author: reebalazs
Date: Sat Oct 7 09:59:20 2006
New Revision: 32978
Modified:
kukit/azax/trunk/plugins/effects/browser/plugin.js
Log:
Field update registry to make the "richfield validation bug" go away
- Implement Field update handlers registry. Kupu now works this way.
- Suffer with Kupu, IE problem. Kupu transforms the DOM generated by AT,
and is thus non-reentrant. I needed to add code to compensate this.
This causes a problem if we init kupu both from global startup and from
kss load event.
- Resolving clash between the global $ variables of MochiKit and prototype
in a terrible way. This is important for effects to work (and since
the spinner uses it, this is critical.)
Modified: kukit/azax/trunk/plugins/effects/browser/plugin.js
==============================================================================
--- kukit/azax/trunk/plugins/effects/browser/plugin.js (original)
+++ kukit/azax/trunk/plugins/effects/browser/plugin.js Sat Oct 7 09:59:20 2006
@@ -13,18 +13,37 @@
oper.completeParms([], {'type': 'fade'}, 'scriptaculous effect');
var node = oper.node;
if (oper.parms.type == 'fade') {
- Effect.Fade(node);
+ new Effect.Fade(node);
} else if (oper.parms.type == 'appear') {
- Effect.Appear(node);
+ new Effect.Appear(node);
} else if (oper.parms.type == 'puff') {
- Effect.Puff(node);
+ new Effect.Puff(node);
} else if (oper.parms.type == 'blinddown') {
- Effect.BlindDown(node);
+ new Effect.BlindDown(node);
} else if (oper.parms.type == 'blindup') {
- Effect.BlindUp(node);
+ new Effect.BlindUp(node);
}
});
kukit.cr.commandRegistry.registerFromAction('effect', kukit.cr.makeSelectorCommand);
+ // This is terrible. We needed to copy this part
+ // from prototype. Notice that I put this.$ =
+ // in the beginning. Without that the function
+ // declarations in IE won't overwrite each others,
+ // and one of them (first or last occurence) comes
+ // in. Now, we have a contradicting $ declaration
+ // in Mochikit, causing the problem.
+
+ this.$ = function $() {
+ var results = [], element;
+ for (var i = 0; i < arguments.length; i++) {
+ element = arguments[i];
+ if (typeof element == 'string')
+ element = document.getElementById(element);
+ results.push(Element.extend(element));
+ }
+ return results.length < 2 ? results[0] : results;
+ };
+
}
From reebalazs at codespeak.net Sat Oct 7 09:59:39 2006
From: reebalazs at codespeak.net (reebalazs at codespeak.net)
Date: Sat, 7 Oct 2006 09:59:39 +0200 (CEST)
Subject: [Kukit-checkins] r32979 - kukit/kukit.js/trunk/kukit
Message-ID: <20061007075939.7138C10060@code0.codespeak.net>
Author: reebalazs
Date: Sat Oct 7 09:59:34 2006
New Revision: 32979
Modified:
kukit/kukit.js/trunk/kukit/forms.js
Log:
Field update registry to make the "richfield validation bug" go away
- Implement Field update handlers registry. Kupu now works this way.
- Suffer with Kupu, IE problem. Kupu transforms the DOM generated by AT,
and is thus non-reentrant. I needed to add code to compensate this.
This causes a problem if we init kupu both from global startup and from
kss load event.
- Resolving clash between the global $ variables of MochiKit and prototype
in a terrible way. This is important for effects to work (and since
the spinner uses it, this is critical.)
Modified: kukit/kukit.js/trunk/kukit/forms.js
==============================================================================
--- kukit/kukit.js/trunk/kukit/forms.js (original)
+++ kukit/kukit.js/trunk/kukit/forms.js Sat Oct 7 09:59:34 2006
@@ -109,6 +109,10 @@
kukit.fo.getValueOfFormElement = function(element) {
// Returns the value of the form element / or null
+ // First: update the field in case an editor is lurking
+ // in the background
+ kukit.fo.fieldUpdateRegistry.doUpdate(element);
+ // Collect the data
if (element.selectedIndex != undefined) {
if (element.selectedIndex < 0) {
value="";
@@ -213,3 +217,37 @@
return kukit.fo.getAllFormVars(form);
};
+/* With editors, there are two main points of handling:
+
+ 1. we need to load them after injected dynamically
+ 2. we need to prepare the form before we want to use the form variables
+
+ Every editor has to register the field on their custody.
+ The update handler will be called automatically, when a form
+ value is about to be fetched.
+*/
+
+kukit.fo.FieldUpdateRegistry = function() {
+ this.editors = {};
+};
+
+kukit.fo.FieldUpdateRegistry.prototype.register = function(node, editor) {
+ var hash = kukit.rd.hashnode(node);
+ if (typeof(this.editors[hash]) != 'undefined') {
+ throw 'Double registration of editor update on node.';
+ }
+ this.editors[hash] = editor;
+ //kukit.logDebug('Registered '+node.name + ' hash=' + hash);
+};
+
+kukit.fo.FieldUpdateRegistry.prototype.doUpdate = function(node) {
+ var hash = kukit.rd.hashnode(node);
+ var editor = this.editors[hash];
+ if (typeof(editor) != 'undefined') {
+ editor.doUpdate(node);
+ //kukit.logDebug('Updated '+node.name + ' hash=' + hash);
+ }
+};
+
+kukit.fo.fieldUpdateRegistry = new kukit.fo.FieldUpdateRegistry();
+
From reebalazs at codespeak.net Sat Oct 7 10:50:52 2006
From: reebalazs at codespeak.net (reebalazs at codespeak.net)
Date: Sat, 7 Oct 2006 10:50:52 +0200 (CEST)
Subject: [Kukit-checkins] r32980 - kukit/azaxdemo/trunk/browser
Message-ID: <20061007085052.7533810068@code0.codespeak.net>
Author: reebalazs
Date: Sat Oct 7 10:50:49 2006
New Revision: 32980
Modified:
kukit/azaxdemo/trunk/browser/azax_effects.pt
kukit/azaxdemo/trunk/browser/azax_xpath.pt
kukit/azaxdemo/trunk/browser/header_macros.pt
Log:
Fix script inclusion order for effects
Modified: kukit/azaxdemo/trunk/browser/azax_effects.pt
==============================================================================
--- kukit/azaxdemo/trunk/browser/azax_effects.pt (original)
+++ kukit/azaxdemo/trunk/browser/azax_effects.pt Sat Oct 7 10:50:49 2006
@@ -2,8 +2,7 @@
-
-
+
+
+
+
+