[Kss-devel] API change in base2

[Jeroen Vloothuis]

Balazs Ree wrote:
> You are banging on open doors! The proposal for this is on launchpad
> since quite some time:
>   

> I really remember having discussed this with you personally on more 
> occasions, but from your reaction it seems that I may be wrong.
I am sorry if I came across as being the inventor of the idea. We indeed 
discussed this at some time. My memory is not the most reliable in the 
world so please blame it on that  :-)
> The implementation for this has been finished in the first week of 
> January, and is waiting for merge since then. I targeted this to be 
> merged for version of kss 1.4, but in the end another decision has been 
> made.
>
> I will rebase this on the newest kukit trunk (will be quite some work sue 
> to other merges since then), change the 
> variable names as discussed with Godefroid on the snowsprint, and submit 
> it for a second review. You can expect this within a few days
>
> Besides the implementation of the service layer, the branch contains a 
> generic refactored implementation of the entire kukit plugin system, as 
> well as several very important code cleanup and a few algorithmic 
> speedups as well.
>   
Is it possible to split these changes from the kukit.service (as the 
blueprint seems to call it) part? I am not saying that these changes are 
not good. It just seems (from your description) that the branch changes 
several things at once which could be done in smaller chunks. Am I 
correct, or is there a reason for doing everything together?

The reason I bring this up is that I think it would be easier to merge a 
small patch which only touches a few lines vs something which would 
changes the plugin api. The Firefox 3 support for Plone 3.1 would be a 
great reason imho to make a small change to add the kukit.service. 
Especially since this can be considered a bug fix with relatively minor 
impact.