[Kss-devel] closures

Godefroid Chapelle gotcha at bubblenet.be
Mon Sep 17 11:20:46 CEST 2007


Balazs Ree wrote:
> Hi Godefroid,
> 
> I disagree with the closures this way (unfortunately it"s done so the
> trouble is there already). Imo it is a huge mistake to indent
> everything. Code should stay unindented (ie. starts in column 0), the
> closure is simply a wrapper around it and has no purpose from a
> programming pov.

I agree with that statement. I will unindent the code I wrongly indented 
and will check-in again.
> 
> Also this way, you change every single line of code. We have no
> history/annotations or a possibility to diff "what has changed since
> then" any more. My merge from the tdr branch will be painful to
> impossible

If you wait one or two days, your merge will then be easier.

> 
> I would like it this way:
> 
> kukit.err = new function () {        /// MODULE START
> /* CLOSURE >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> */
> 
> // here everything is unindented
> var a = b;
> 
> /* END CLOSURE <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< */
> }();                              /// MODULE END
> 


-- 
Godefroid Chapelle (aka __gotcha)- BubbleNet  http://bubblenet.be



More information about the Kss-devel mailing list