From ree at ree.hu Tue Sep 4 13:00:52 2007 From: ree at ree.hu (Balazs Ree) Date: Tue, 4 Sep 2007 13:00:52 +0200 Subject: [Kss-devel] new release 1.2.1 of plone.app.kss Message-ID: Since Plone prepares for a bugfix release 3.0.1, let me summarize what we need to do: - As a decision made on the sprint, we do not make a bugfix release for kss.core - we will however make a 1.2.1 release for plone.app.kss and archetypes.kss that will go to the Plone release. Therefore if any of you have fixes ready for these products but you forgot to merge them, please merge them to trunk immediately. Once you have your merge on the trunk, or if it was there already but is done after the 3.0 release, please write a response to this mail, describing your change. We will be able to test these on the trunk and then you will be requested to merge these back to the 3.0 branch (if you have not done so) If your change requires fix in Products.CMFPlone or Products.Archetypes (skins, gs profiles), let us know as well! - I myself have two bugfixes in archetypes.kss, that I want in. Both are tested and merged back to 1.2 branch. archetypes.kss trunk -r8369, fixes bug #6938 (implement versioning work with inline edit) archetypes.kss trunk -r8377, fixes bug #6958 (inline edit is not active in the versioning preview) -- Balazs Ree From gotcha at bubblenet.be Tue Sep 4 15:47:20 2007 From: gotcha at bubblenet.be (Godefroid Chapelle) Date: Tue, 04 Sep 2007 15:47:20 +0200 Subject: [Kss-devel] new release 1.2.1 of plone.app.kss In-Reply-To: References: Message-ID: <46DD61E8.7040200@bubblenet.be> Balazs Ree wrote: I'd rather avoid plone.app.kss discussions on this list... > Since Plone prepares for a bugfix release 3.0.1, let me summarize what we > need to do: > > - As a decision made on the sprint, we do not make a bugfix release for > kss.core Right (This is ok for the list though). > > - we will however make a 1.2.1 release for plone.app.kss and > archetypes.kss that will go to the Plone release. > > Therefore if any of you have fixes ready for these products but you > forgot to merge them, please merge them to trunk immediately. > What does immediately mean ? We need to look at Malthe fixes in order to tell him if he can merge... I do not have time for tomorrow... > Once you have your merge on the trunk, or if it was there already but is > done after the 3.0 release, please write a response to this mail, > describing your change. We will be able to test these on the trunk and > then you will be requested to merge these back to the 3.0 branch (if you > have not done so) > > If your change requires fix in Products.CMFPlone or Products.Archetypes > (skins, gs profiles), let us know as well! > > > > > > - I myself have two bugfixes in archetypes.kss, that I want in. Both are > tested and merged back to 1.2 branch. > > archetypes.kss trunk -r8369, fixes bug #6938 > (implement versioning work with inline edit) > archetypes.kss trunk -r8377, fixes bug #6958 > (inline edit is not active in the versioning preview) > -- Godefroid Chapelle (aka __gotcha)- BubbleNet http://bubblenet.be From hedley at upfrontsystems.co.za Tue Sep 4 17:40:38 2007 From: hedley at upfrontsystems.co.za (Hedley Roos) Date: Tue, 04 Sep 2007 17:40:38 +0200 Subject: [Kss-devel] Large response goes missing In-Reply-To: References: <46C2F220.8080008@upfrontsystems.co.za> <200708152226.03638.jeroen.vloothuis@pareto.nl> <46CAE034.7040403@upfrontsystems.co.za> Message-ID: <46DD7C76.6060905@upfrontsystems.co.za> Seems I sent my reply directly to Balazs and not the list... so here we go again. It is not Azax/kss that sends such a large response but my Python Script. I'm basically setting a very large piece of markup (the 900k) as innerHTML for a div. Most of the time the markup never appears in my browser. It could of course be my browser / network at fault, but I doubt it (using FF2). When I set only a few chars (lik 'xxx') it works as expected. From gotcha at bubblenet.be Tue Sep 4 17:48:51 2007 From: gotcha at bubblenet.be (Godefroid Chapelle) Date: Tue, 04 Sep 2007 17:48:51 +0200 Subject: [Kss-devel] Large response goes missing In-Reply-To: <46DD7C76.6060905@upfrontsystems.co.za> References: <46C2F220.8080008@upfrontsystems.co.za> <200708152226.03638.jeroen.vloothuis@pareto.nl> <46CAE034.7040403@upfrontsystems.co.za> <46DD7C76.6060905@upfrontsystems.co.za> Message-ID: <46DD7E63.4040102@bubblenet.be> Hedley Roos wrote: > Seems I sent my reply directly to Balazs and not the list... so here we > go again. > > It is not Azax/kss that sends such a large response but my Python > Script. I'm basically setting a very large piece of markup (the 900k) as > innerHTML for a div. Most of the time the markup never appears in my > browser. It could of course be my browser / network at fault, but I > doubt it (using FF2). When I set only a few chars (lik 'xxx') it works > as expected. > _______________________________________________ > Kss-devel mailing list > Kss-devel at codespeak.net > http://codespeak.net/mailman/listinfo/kss-devel Did you check in Firebug if there is a timeout problem ? KSS stops to await for its request after a fixed time and closes the connection. Balazs, we might need to setup timeout on a request per request base. we could have kssTimeout parameter mentioned in KSS Hedley, this is prospective, it does not exist now. -- Godefroid Chapelle (aka __gotcha)- BubbleNet http://bubblenet.be From ree at ree.hu Tue Sep 4 17:45:38 2007 From: ree at ree.hu (Balazs Ree) Date: Tue, 4 Sep 2007 17:45:38 +0200 Subject: [Kss-devel] new release 1.2.1 of plone.app.kss References: <46DD61E8.7040200@bubblenet.be> Message-ID: Tue, 04 Sep 2007 15:47:20 +0200 keltez?ssel Godefroid Chapelle azt ?rta: > Balazs Ree wrote: > > I'd rather avoid plone.app.kss discussions on this list... > >> Since Plone prepares for a bugfix release 3.0.1, let me summarize what >> we need to do: >> >> - As a decision made on the sprint, we do not make a bugfix release for >> kss.core > > Right (This is ok for the list though). > > > > >> - we will however make a 1.2.1 release for plone.app.kss and >> archetypes.kss that will go to the Plone release. >> >> Therefore if any of you have fixes ready for these products but you >> forgot to merge them, please merge them to trunk immediately. >> > What does immediately mean ? > We need to look at Malthe fixes in order to tell him if he can merge... This depends on if it has tests. If yes, we can merge it. If not, tests need to be made but also this can be done in time. > I do not have time for tomorrow... Wichert asks the release on Monday. For this I would feel necessary to have to merges decided, tested, and merged in till Friday evening. I would like people to test it during the weekend. We may also want to make a bugday on Saturday, and have a look at the remaining issues in tracker. I believe Malthe and Jean-Francois both have merges. I agree we should continue this on plone-devel, unless you have some reaction first. -- Balazs Ree From ree at ree.hu Wed Sep 5 07:37:50 2007 From: ree at ree.hu (Balazs Ree) Date: Wed, 5 Sep 2007 07:37:50 +0200 Subject: [Kss-devel] Large response goes missing References: <46C2F220.8080008@upfrontsystems.co.za> <200708152226.03638.jeroen.vloothuis@pareto.nl> <46CAE034.7040403@upfrontsystems.co.za> <46DD7C76.6060905@upfrontsystems.co.za> <46DD7E63.4040102@bubblenet.be> Message-ID: Tue, 04 Sep 2007 17:48:51 +0200 keltez?ssel Godefroid Chapelle azt ?rta: > Hedley Roos wrote: >> Seems I sent my reply directly to Balazs and not the list... so here we >> go again. >> >> It is not Azax/kss that sends such a large response but my Python >> Script. I'm basically setting a very large piece of markup (the 900k) >> as innerHTML for a div. Most of the time the markup never appears in my >> browser. It could of course be my browser / network at fault, but I >> doubt it (using FF2). When I set only a few chars (lik 'xxx') it works >> as expected. >> _______________________________________________ Kss-devel mailing list >> Kss-devel at codespeak.net >> http://codespeak.net/mailman/listinfo/kss-devel > > Did you check in Firebug if there is a timeout problem ? > > KSS stops to await for its request after a fixed time and closes the > connection. > > Balazs, we might need to setup timeout on a request per request base. > > we could have > > kssTimeout parameter mentioned in KSS > > Hedley, this is prospective, it does not exist now. Yes, we were thinking about that, it might arrive one day as an action parameter for the server action. However what I would like to know, is _why_ you need to generate such a big html? It seems to be the wrong pattern and against the point of ajax, it is better to send to the page the html that is visible at that moment. -- Balazs Ree From usenet at diefenba.ch Wed Sep 5 08:52:26 2007 From: usenet at diefenba.ch (Kai Diefenbach) Date: Wed, 5 Sep 2007 08:52:26 +0200 Subject: [Kss-devel] Validators Message-ID: <1i3yl54.jztcwy1t9on0wN%usenet@diefenba.ch> Hi guys, today I realized that field validators (e.g. "isURL") are not recognized by KSS. If I leave a field (with tab) with an invalid value it displays no error (in contrary to leave a required filed blank). If I try to save it, the error is displayed as expected. As this behaviour is not consistent, it is not really bad, as the field is going to have valid data if the object is saved. IMO worse is the fact, that one is able to change the field with the inline edit and save it with a invalid value without complaining. Is there a workaround? Thanks in advance Kai -- Kai Diefenbach - http://diefenba.ch iqplusplus - http://iqpp.de From ree at ree.hu Wed Sep 5 09:07:11 2007 From: ree at ree.hu (Balazs Ree) Date: Wed, 5 Sep 2007 09:07:11 +0200 Subject: [Kss-devel] Validators References: <1i3yl54.jztcwy1t9on0wN%usenet@diefenba.ch> Message-ID: Hi Kai, Wed, 05 Sep 2007 08:52:26 +0200 keltez?ssel Kai Diefenbach azt ?rta: > today I realized that field validators (e.g. "isURL") are not recognized > by KSS. They should be so if they are not then this is a bug. > If I leave a field (with tab) with an invalid value it displays no error > (in contrary to leave a required filed blank). If I try to save it, the > error is displayed as expected. As this behaviour is not consistent, it > is not really bad, as the field is going to have valid data if the > object is saved. > > IMO worse is the fact, that one is able to change the field with the > inline edit and save it with a invalid value without complaining. If the bug is fixed then this will go away as well. > Is there a workaround? I don't think so. We need to look at the problem. Thanks for reporting. Would you file this bug into the Plone bug tracker, as a KSS bug? -- Balazs Ree From usenet at diefenba.ch Wed Sep 5 09:59:10 2007 From: usenet at diefenba.ch (Kai Diefenbach) Date: Wed, 5 Sep 2007 09:59:10 +0200 Subject: [Kss-devel] Validators References: <1i3yl54.jztcwy1t9on0wN%usenet@diefenba.ch> Message-ID: <1i3yoyh.1vk9eobs9hu92N%usenet@diefenba.ch> Balazs Ree wrote: > Wed, 05 Sep 2007 08:52:26 +0200 keltez?ssel Kai Diefenbach azt ?rta: > > > today I realized that field validators (e.g. "isURL") are not recognized > > by KSS. > Would you file this bug into the Plone bug tracker, as a KSS bug? Yes. I'm going to do that during the day. Kai -- Kai Diefenbach - http://diefenba.ch iqplusplus - http://iqpp.de From hedley at upfrontsystems.co.za Wed Sep 5 10:12:29 2007 From: hedley at upfrontsystems.co.za (Hedley Roos) Date: Wed, 05 Sep 2007 10:12:29 +0200 Subject: [Kss-devel] Large response goes missing In-Reply-To: References: <46C2F220.8080008@upfrontsystems.co.za> <200708152226.03638.jeroen.vloothuis@pareto.nl> <46CAE034.7040403@upfrontsystems.co.za> <46DD7C76.6060905@upfrontsystems.co.za> <46DD7E63.4040102@bubblenet.be> Message-ID: <46DE64ED.3020007@upfrontsystems.co.za> > > However what I would like to know, is _why_ you need to generate such a > big html? It seems to be the wrong pattern and against the point of ajax, > it is better to send to the page the html that is visible at that moment. > It IS the wrong pattern. My app has a template which displays a large object tree with expandable / collapsable nodes for navigation. It also provides inline editing. The problem arises when I expand a large subtree. I have changes my pattern. What I do now is to create the first 10 elements of the tree the KSS way, and then create "slots" for the remaining batches of elements. These slots are each filled with a simpler ajax call (ie not azax involved for them). FYI I use it in a product called PloneWurfl which is soon to be released. I'll send a link to the source so you can see how I manage the tree. Maybe you already have a better way of doing it. From gotcha at bubblenet.be Wed Sep 5 11:23:12 2007 From: gotcha at bubblenet.be (Godefroid Chapelle) Date: Wed, 05 Sep 2007 11:23:12 +0200 Subject: [Kss-devel] Validators In-Reply-To: <1i3yl54.jztcwy1t9on0wN%usenet@diefenba.ch> References: <1i3yl54.jztcwy1t9on0wN%usenet@diefenba.ch> Message-ID: <46DE7580.2020501@bubblenet.be> This list is for the development of KSS itself, can you move those mails to plone-dev ? Kai Diefenbach wrote: > Hi guys, > > today I realized that field validators (e.g. "isURL") are not recognized > by KSS. > > If I leave a field (with tab) with an invalid value it displays no error > (in contrary to leave a required filed blank). If I try to save it, the > error is displayed as expected. As this behaviour is not consistent, it > is not really bad, as the field is going to have valid data if the > object is saved. > > IMO worse is the fact, that one is able to change the field with the > inline edit and save it with a invalid value without complaining. > > Is there a workaround? > Can you give more details ? Do you mean that in archetypes base_view sthing is missing ? > Thanks in advance > Kai > -- Godefroid Chapelle (aka __gotcha)- BubbleNet http://bubblenet.be From usenet at diefenba.ch Wed Sep 5 13:33:36 2007 From: usenet at diefenba.ch (Kai Diefenbach) Date: Wed, 5 Sep 2007 13:33:36 +0200 Subject: [Kss-devel] Validators References: <1i3yl54.jztcwy1t9on0wN%usenet@diefenba.ch> <46DE7580.2020501@bubblenet.be> Message-ID: <1i3yyj1.1mknqez4p4ikmN%usenet@diefenba.ch> Hi Godefroid, Godefroid Chapelle wrote: > This list is for the development of KSS itself, can you move those mails > to plone-dev ? Yes, of course. For this thread, I let it on this list, if you don't mind? > > If I leave a field (with tab) with an invalid value it displays no error > > (in contrary to leave a required filed blank). If I try to save it, the > > error is displayed as expected. As this behaviour is not consistent, it > > is not really bad, as the field is going to have valid data if the > > object is saved. > > > > IMO worse is the fact, that one is able to change the field with the > > inline edit and save it with a invalid value without complaining. > Can you give more details ? I have a ATField with an validator e.g. "isURL". If I leave this field within the base_edit.pt I would expect that I get an error, If I haven't entered a valid URL (the same way Plone complains if I let a required field empty). But I don't get one. If I save the whole template Plone complains about the invalid URL, like it used to for earlier versions. Not nice but not a problem until here, because I'm not able to store the object with an invalid value. If I use the default inline edit feature of the base_view template now, I can click on this field and edit it. The problem is that I can now change the field's content to an invalid URL and save it without complaining. The object is now stored within a invalid URL. Kai -- Kai Diefenbach - http://diefenba.ch iqplusplus - http://iqpp.de From ree at ree.hu Fri Sep 7 15:53:51 2007 From: ree at ree.hu (Balazs Ree) Date: Fri, 7 Sep 2007 15:53:51 +0200 Subject: [Kss-devel] kss.core 1.2-1 release needed, too Message-ID: Hi everyone, we just need a new kss.core release, too. I just fixed the following bug, reported by ggozad: ------------------------------------------------------------------------ r46402 | reebalazs | 2007-09-07 15:30:56 +0200 (p, 07 szept 2007) | 1 line Fix logging from the event binder of [load, iload], that caused document:load fail in development mode (for real) ------------------------------------------------------------------------ (Revision numbers are of kss.core trunk.) This is already backported to 1.2 release branch, but I also suggest to backport the followings: ------------------------------------------------------------------------ r46031 | reebalazs | 2007-08-27 16:06:31 +0200 (h, 27 aug 2007) | 1 line Fix bug in replaceInnerHTML. (Caused content not bound.) ------------------------------------------------------------------------ ------------------------------------------------------------------------ r46103 | jfroche | 2007-08-28 20:50:32 +0200 (k, 28 aug 2007) | 2 lines fix IE bug in forms ------------------------------------------------------------------------ Any objections? -- Balazs Ree From gotcha at bubblenet.be Fri Sep 7 16:13:20 2007 From: gotcha at bubblenet.be (Godefroid Chapelle) Date: Fri, 07 Sep 2007 16:13:20 +0200 Subject: [Kss-devel] kss.core 1.2-1 release needed, too In-Reply-To: References: Message-ID: <46E15C80.4000509@bubblenet.be> Balazs Ree wrote: > Hi everyone, > > we just need a new kss.core release, too. I just fixed the following bug, > reported by ggozad: > > ------------------------------------------------------------------------ > r46402 | reebalazs | 2007-09-07 15:30:56 +0200 (p, 07 szept 2007) | 1 line > > Fix logging from the event binder of [load, iload], that caused > document:load fail in development mode (for real) > ------------------------------------------------------------------------ > > (Revision numbers are of kss.core trunk.) > > > This is already backported to 1.2 release branch, but I also suggest > to backport the followings: > > > ------------------------------------------------------------------------ > r46031 | reebalazs | 2007-08-27 16:06:31 +0200 (h, 27 aug 2007) | 1 line > > Fix bug in replaceInnerHTML. (Caused content not bound.) > ------------------------------------------------------------------------ > > > ------------------------------------------------------------------------ > r46103 | jfroche | 2007-08-28 20:50:32 +0200 (k, 28 aug 2007) | 2 lines > > fix IE bug in forms > > ------------------------------------------------------------------------ > > Any objections? > Seems ok for me -- Godefroid Chapelle (aka __gotcha)- BubbleNet http://bubblenet.be From ree at ree.hu Wed Sep 12 09:04:22 2007 From: ree at ree.hu (Balazs Ree) Date: Wed, 12 Sep 2007 09:04:22 +0200 Subject: [Kss-devel] plone.app.kss sprint after the Plone Conference in Naples (13-14-15 October) Message-ID: plone.app.kss sprint after the Plone Conference in Naples (13-14-15 October) The sprint track will be lead by Balazs Ree and Jeroen Vloothuis, and will be targeted at AJAX functionality for Plone 3.5: the development of the plone.app.kss and archetypes.kss products, and custom kss plugins. Read more information on the topic, and signal your interest on http://www.openplans.org/projects/plone-conference-2007/kss -- Balazs Ree From dokter at w20e.com Wed Sep 12 09:20:09 2007 From: dokter at w20e.com (Duco Dokter) Date: Wed, 12 Sep 2007 09:20:09 +0200 Subject: [Kss-devel] plone.app.kss sprint after the Plone Conference in Naples (13-14-15 October) In-Reply-To: References: Message-ID: <200709120920.09880.dokter@w20e.com> On Wednesday 12 September 2007 09:04:22 Balazs Ree wrote: This might be a good occasion to talk over the Drag-n-Drop part of KSS. That is, during the beers afterwards... > plone.app.kss sprint after the Plone Conference in Naples (13-14-15 > October) > > > The sprint track will be lead by Balazs Ree and Jeroen Vloothuis, and > will be targeted at AJAX functionality for Plone 3.5: the development of > the plone.app.kss and archetypes.kss products, and custom kss plugins. > > Read more information on the topic, and signal your interest on > http://www.openplans.org/projects/plone-conference-2007/kss -- In the plot, people came to the land; the land loved them; they worked and struggled and had lots of children. There was a Frenchman who talked funny and a greenhorn from England who was a fancy-pants but when it came to the crunch he was all courage. Those novels would make you retch. -- Canadian novelist Robertson Davies, on the generic Canadian novel. From optilude at gmx.net Wed Sep 12 09:40:22 2007 From: optilude at gmx.net (Martin Aspeli) Date: Wed, 12 Sep 2007 08:40:22 +0100 Subject: [Kss-devel] plone.app.kss sprint after the Plone Conference in Naples (13-14-15 October) In-Reply-To: <200709120920.09880.dokter@w20e.com> References: <200709120920.09880.dokter@w20e.com> Message-ID: Duco Dokter wrote: > On Wednesday 12 September 2007 09:04:22 Balazs Ree wrote: > > This might be a good occasion to talk over the Drag-n-Drop part of KSS. That > is, during the beers afterwards... I'd encourage you guys to look at ExtJS as well. I really think this is a library with solid components we could use in Plone. See my blog post here: http://martinaspeli.net/articles/extjs-is-awesome The problem, again, is page weight. We need to make sure that we don't slow down page rendering further. It's truly awful how bad browsers are at executing JS (Firefox basically freezes completely until it's done), but that's what we have to work with. Martin -- Acquisition is a jealous mistress From ree at ree.hu Wed Sep 12 10:08:38 2007 From: ree at ree.hu (Balazs Ree) Date: Wed, 12 Sep 2007 10:08:38 +0200 Subject: [Kss-devel] created howto for kss on plone 3 Message-ID: I've posted a new "howto" manual for kss on Plone 3, that is really a kind of answer to "frequently asked questions". http://plone.org/documentation/how-to/how-to-setup-and-use-kss-onplone-3.0 I tried to write down the answers to the most common questions that arrive to me. The first part is about configuration of kss on Plone, the second part is about development with kss. Remark: the majority of answers would not be needed if we had already the configuration center for kss. We plan to create this tool since a year or so, but it was always prioritized out. Now it becomes obvious that it's a must have for 3.5. Comments or suggestions are welcome. -- Balazs Ree From amckay at bluefountain.com Wed Sep 12 10:21:04 2007 From: amckay at bluefountain.com (Andy McKay) Date: Wed, 12 Sep 2007 09:21:04 +0100 Subject: [Kss-devel] [Plone-docs] created howto for kss on plone 3 In-Reply-To: References: Message-ID: <3CEB0A99-1A5F-491D-A847-52BF68FF562E@bluefountain.com> Thanks! I got a 404 btw, I think its: http://plone.org/documentation/how-to/how-to-setup-and-use-kss-on- plone-3.0 -- Andy McKay From wichert at wiggy.net Wed Sep 12 10:25:16 2007 From: wichert at wiggy.net (Wichert Akkerman) Date: Wed, 12 Sep 2007 10:25:16 +0200 Subject: [Kss-devel] [Plone-docs] created howto for kss on plone 3 In-Reply-To: References: Message-ID: <20070912082516.GB12676@wiggy.net> Sorry to be nitpicking, but I see you published your own document. Isn't there a policy not to allow that? There was a small error in the text: it said kss is by default enabled for anonymous users only. I changed that to say it is enabled for authenticated users only. Wichert. Previously Balazs Ree wrote: > I've posted a new "howto" manual for kss on Plone 3, that is really a > kind of answer to "frequently asked questions". > > http://plone.org/documentation/how-to/how-to-setup-and-use-kss-onplone-3.0 > > I tried to write down the answers to the most common questions that > arrive to me. > > The first part is about configuration of kss on Plone, the second part is > about development with kss. > > Remark: the majority of answers would not be needed if we had already the > configuration center for kss. We plan to create this tool since a year or > so, but it was always prioritized out. Now it becomes obvious that it's a > must have for 3.5. > > Comments or suggestions are welcome. > > -- > Balazs Ree > > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2005. > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > _______________________________________________ > Plone-docs mailing list > Plone-docs at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/plone-docs -- Wichert Akkerman It is simple to make things. http://www.wiggy.net/ It is hard to make things simple. From ree at ree.hu Wed Sep 12 10:41:59 2007 From: ree at ree.hu (Balazs Ree) Date: Wed, 12 Sep 2007 10:41:59 +0200 Subject: [Kss-devel] created howto for kss on plone 3 References: <20070912082516.GB12676@wiggy.net> Message-ID: Wed, 12 Sep 2007 10:25:16 +0200 keltez?ssel Wichert Akkerman azt ?rta: > Sorry to be nitpicking, but I see you published your own document. Isn't > there a policy not to allow that? Thanks, I am sorry, it won't happen next time. This time I ask if it can stay so. > There was a small error in the text: it said kss is by default enabled > for anonymous users only. I changed that to say it is enabled for > authenticated users only. Thanks. -- Balazs Ree From jeroen.vloothuis at pareto.nl Wed Sep 12 19:48:25 2007 From: jeroen.vloothuis at pareto.nl (Jeroen Vloothuis) Date: Wed, 12 Sep 2007 19:48:25 +0200 Subject: [Kss-devel] plone.app.kss sprint after the Plone Conference in Naples (13-14-15 October) In-Reply-To: References: <200709120920.09880.dokter@w20e.com> Message-ID: <200709121948.25660.jeroen.vloothuis@pareto.nl> On Wednesday 12 September 2007 09:40:22 Martin Aspeli wrote: > I'd encourage you guys to look at ExtJS as well. I really think this is > a library with solid components we could use in Plone. You may have noticed I am going to do a presentation on extending KSS. Integrating one or two things from ExtJS might make a good example. Are there any parts which you would like to see as part of a presentation? From massimo.azzolini at gmail.com Thu Sep 13 12:07:53 2007 From: massimo.azzolini at gmail.com (Massimo Azzolini) Date: Thu, 13 Sep 2007 12:07:53 +0200 Subject: [Kss-devel] plone.app.kss sprint after the Plone Conference in Naples (13-14-15 October) In-Reply-To: References: Message-ID: hi balatz, hi all, On 9/12/07, Balazs Ree wrote: > The sprint track will be lead by Balazs Ree and Jeroen Vloothuis, and > will be targeted at AJAX functionality for Plone 3.5: the development of > the plone.app.kss and archetypes.kss products, and custom kss plugins. in the last month a student (nicola senno) spent his stage in our company. we projected an "add-on" for plone3 and kss using DnD (drag and drop, not dungeons and dragons :). the project implements this functionality: since you can define (using kss) that some objects are draggable and others are droppable, we started defining that everything in the content area and in the navigation portlet is draggable and vice versa (they are also droppable). when you drag an obj A to another obj B, a div appears near the dropping point, asking if you want to copy, move or cancel operation (obviously you can copy or move depending on your access to both objects and if objA can be moved/copied into B). The behaviour is the same as in ms explorer or in konqueror.. after that the system completes the operation refreshing the parts of the plone interface that are involved in the operation. we planned to define which kind of div/actions we have to draw/implement depending on the area you are dropping. I try to explain it better: if I drag a page on a folder (inside the navigator) the action is obviously "I want to move/copy the page in that folder", but if I drag a an event to "march 19, 2007" on the calendar portlet, which is my goal? It could be: " I want to change the start/end date of the event" so the div should ask me to choose between if I wanna change the start or end date. In the same way we can write a shopping-cart-portlet and add item to it.. So we (nicola..) are trying to coding it using adapters which adapts a "INavigator"/"ICalendar"/"IMyPortlet" to a obj that draws the div and implements the underlying rules. we had some problem with the dnd implementation (as balatz said, there were problems..) but we relied on the fact that you surely fix it in the future.. If you may be interested in, we could extend/complete it during the sprint. see you in naples massimo From ree at ree.hu Thu Sep 13 13:07:49 2007 From: ree at ree.hu (Balazs Ree) Date: Thu, 13 Sep 2007 13:07:49 +0200 Subject: [Kss-devel] plone.app.kss sprint after the Plone Conference in Naples (13-14-15 October) References: Message-ID: Hi Massimo, On Thu, 13 Sep 2007 12:07:53 +0200 Massimo Azzolini wrote: > On 9/12/07 Balazs Ree wrote: >> The sprint track will be lead by Balazs Ree and Jeroen Vloothuis, and >> will be targeted at AJAX functionality for Plone 3.5: the development >> of the plone.app.kss and archetypes.kss products, and custom kss >> plugins. > > in the last month a student (nicola senno) spent his stage in our > company. we projected an "add-on" for plone3 and kss using DnD (drag and > drop, not dungeons and dragons :). > > the project implements this functionality: since you can define (using > kss) that some objects are draggable and others are droppable, we > started defining that everything in the content area and in the > navigation portlet is draggable and vice versa (they are also > droppable). > > when you drag an obj A to another obj B, a div appears near the dropping > point, asking if you want to copy, move or cancel operation (obviously > you can copy or move depending on your access to both objects and if > objA can be moved/copied into B). The behaviour is the same as in ms > explorer or in konqueror.. > > after that the system completes the operation refreshing the parts of > the plone interface that are involved in the operation. > > we planned to define which kind of div/actions we have to draw/implement > depending on the area you are dropping. I try to explain it better: if I > drag a page on a folder (inside the navigator) the action is obviously > "I want to move/copy the page in that folder", but if I drag a an event > to "march 19, 2007" on the calendar portlet, which is my goal? > It could be: " I want to change the start/end date of the event" so the > div should ask me to choose between if I wanna change the start or end > date. > In the same way we can write a shopping-cart-portlet and add item to > it.. > > So we (nicola..) are trying to coding it using adapters which adapts a > "INavigator"/"ICalendar"/"IMyPortlet" to a obj that draws the div and > implements the underlying rules. > > we had some problem with the dnd implementation (as balatz said, there > were problems..) but we relied on the fact that you surely fix it in > the future.. > > If you may be interested in, we could extend/complete it during the > sprint. > > see you in naples As I understand you want to make all (all lots of) elements generally draggable, others generally droppable, and build a generic drag-and-drop framework on the server side. I must mention that in our dnd experiments (which is on a currently unpublished branch, to be ported to kss.core 1.4 before or at the beginning of the sprint), we do not use such a server side mechanism, and we make the dnd mechanism work in the following simple way: 1. bind the draggables and droppables from kss, using css selection. Binding of draggables and droppables happens grouped: "These goodies can be dropped into these baskets", or "these portlets can be reordered in place". IE, portlets cannot be dropped to baskets and the client side is aware of this. 2. the server side is really simple, a single view that gets invoked on drop. All it needs to do is store the change in the content, or raise an exception if something went wrong. 3. if you want error handling, the client needs an error handler to revert the drop if the response comes with error. For a generic application (like shopping cart, or portlets rearrangement) when the draggables and droppables are all controlled by the same component, there is no need to have more server side logic than this. But if we want to support that a draggable defined by application component X (draggable page) can be dropped to a droppable defined by application component Y (nav portlet droppable), then such a construct may make sense. But still I think that the logic "what can be dropped to where" should be controlled by the kss resource and not on the server side zcml. And that we can even keep it in kss in these cases, because the css selection is so flexible. So I would like to ask two things from you: - you should state the exact usecase you are trying to support. Settle on the simplest goal you can think of. - I would also be interested in seeing the code, where is it available? Best wishes -- Balazs Ree From massimo.azzolini at gmail.com Fri Sep 14 13:00:14 2007 From: massimo.azzolini at gmail.com (Massimo Azzolini) Date: Fri, 14 Sep 2007 13:00:14 +0200 Subject: [Kss-devel] plone.app.kss sprint after the Plone Conference in Naples (13-14-15 October) In-Reply-To: References: Message-ID: hi balatz, I thought about your scenario and how it impacts on my previous ideas on dnd. On 9/13/07, Balazs Ree wrote: > As I understand you want to make all (all lots of) elements generally > draggable, others generally droppable, and build a generic drag-and-drop > framework on the server side. not really a generic dnd framework rather a pluggable framework. > I must mention that in our dnd experiments (which is on a currently > unpublished branch, to be ported to kss.core 1.4 before or at the > beginning of the sprint), we do not use such a server side mechanism, and > we make the dnd mechanism work in the following simple way: > > 1. bind the draggables and droppables from kss, using css selection. > Binding of draggables and droppables happens grouped: "These goodies > can be dropped into these baskets", or "these portlets can be > reordered in place". IE, portlets cannot be dropped to baskets and the > client side is aware of this. > 2. the server side is really simple, a single view that gets invoked on > drop. All it needs to do is store the change in the content, or > raise an exception if something went wrong. > 3. if you want error handling, the client needs an error handler to > revert the drop if the response comes with error. > > For a generic application (like shopping cart, or portlets rearrangement) > when the draggables and droppables are all controlled by the same > component, there is no need to have more server side logic than this. right, but if for the copy/move example we need a server logic, we need to ask to the user if he want to copy or to move, so we need to draw an area where to put the question. in this case the logic must be on the server. mustn't it? that's why I'm thinking about a pluggable system. If you dont need a server side logic, ok it's done, otherwise.. write down your own one. > But if we want to support that a draggable defined by application > component X (draggable page) can be dropped to a droppable defined by > application component Y (nav portlet droppable), then such a construct > may make sense. But still I think that the logic "what can be dropped to > where" should be controlled by the kss resource and not on the server > side zcml. And that we can even keep it in kss in these cases, because > the css selection is so flexible. again, in the move example, it depends on the user if he can move an object or not. imagine a folder with 2 pages. the first one can be just read by the user the other one can be both written or read. i cannot figure out how to describe this in kss, and, if I could, it have to be expressed dynamically by a function which depends on both objects and user. it should be great since a problem we have is that we can start a drag on whatever draggable object and end it on whatever droppable object, then do a roundtrip to the server which tell us if we can do nothing/just copy/copy or move. > So I would like to ask two things from you: > > - you should state the exact usecase you are trying to support. Settle on > the simplest goal you can think of. at least the copy/move operation in addition, could be interesting to use the tagcloud product and drag a tag to an object (or vice versa) to add a keyword to it. I have other ideas about the workflow and a simpler interface for write the comments on status changing, for example. it's not so easy to express via email. we could talk about it. > - I would also be interested in seeing the code, where is it available? nicola is working at it at home, the last version I have is not up-to-date. he's going to send me a newer one. bye max PS: obviously, sorry for my english. maybe when we meet in naples I can explain myself better using a pencil and a paper :D From gotcha at bubblenet.be Mon Sep 17 11:20:46 2007 From: gotcha at bubblenet.be (Godefroid Chapelle) Date: Mon, 17 Sep 2007 11:20:46 +0200 Subject: [Kss-devel] closures In-Reply-To: <1190009708.26957.6.camel@brumi.ree> References: <1190009708.26957.6.camel@brumi.ree> Message-ID: <46EE46EE.9070200@bubblenet.be> Balazs Ree wrote: > Hi Godefroid, > > I disagree with the closures this way (unfortunately it"s done so the > trouble is there already). Imo it is a huge mistake to indent > everything. Code should stay unindented (ie. starts in column 0), the > closure is simply a wrapper around it and has no purpose from a > programming pov. I agree with that statement. I will unindent the code I wrongly indented and will check-in again. > > Also this way, you change every single line of code. We have no > history/annotations or a possibility to diff "what has changed since > then" any more. My merge from the tdr branch will be painful to > impossible If you wait one or two days, your merge will then be easier. > > I would like it this way: > > kukit.err = new function () { /// MODULE START > /* CLOSURE >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> */ > > // here everything is unindented > var a = b; > > /* END CLOSURE <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< */ > }(); /// MODULE END > -- Godefroid Chapelle (aka __gotcha)- BubbleNet http://bubblenet.be From ggozadinos at gmail.com Wed Sep 19 09:32:57 2007 From: ggozadinos at gmail.com (Yiorgis Gozadinos) Date: Wed, 19 Sep 2007 10:32:57 +0300 Subject: [Kss-devel] kss implementation of egoban.org Message-ID: <42182c280709190032o466475f7qc48f0a65d2d6b934@mail.gmail.com> Hi, I briefly talked with you guys a bit on #kss about converting my site egoban.org which handles Go games and replays them through an AJAX interface. The conversion has been long done, and everything seems to work fine (except that I find it slightly slower which is I suppose expected) and overall I can say I'm pleased with the result. I had promised to bring it over to Naples as a showcase for kss but I had an emergency operation and I'm not sure if I'll attend. Because egoban.org still runs on 2.5.3 without kss if you want to have the code (it's not yet open source) and show it off live I would be happy to hand it over. Let me know... Yours, gg -------------- next part -------------- An HTML attachment was scrubbed... URL: http://codespeak.net/pipermail/kss-devel/attachments/20070919/c1da2be9/attachment.htm From gotcha at bubblenet.be Wed Sep 19 10:52:30 2007 From: gotcha at bubblenet.be (Godefroid Chapelle) Date: Wed, 19 Sep 2007 10:52:30 +0200 Subject: [Kss-devel] kss implementation of egoban.org In-Reply-To: <42182c280709190032o466475f7qc48f0a65d2d6b934@mail.gmail.com> References: <42182c280709190032o466475f7qc48f0a65d2d6b934@mail.gmail.com> Message-ID: <46F0E34E.50901@bubblenet.be> Yiorgis Gozadinos wrote: > Hi, > I briefly talked with you guys a bit on #kss about converting my site > egoban.org which handles Go games and replays them > through an AJAX interface. > The conversion has been long done, and everything seems to work fine > (except that I find it slightly slower which is I suppose expected) and > overall I can say I'm pleased with the result. > I had promised to bring it over to Naples as a showcase for kss but I > had an emergency operation and I'm not sure if I'll attend. > > Because egoban.org still runs on 2.5.3 without kss > if you want to have the code (it's not yet open source) and show it off > live I would be happy to hand it over. Let me know... > Yours, > gg > Hello Yiorgis, I would really like to see both code base. I think I would like to make a lightning talk about your site and migration... So yes, I'd like to see your code. But more thant that, I'd like some feedback about your experience. What were the problems ? What did you like ? What do you suggest ? One line answer to those three questions would be great... I am looking forward to see what you did ! -- Godefroid Chapelle (aka __gotcha)- BubbleNet http://bubblenet.be From ggozadinos at gmail.com Thu Sep 20 10:53:07 2007 From: ggozadinos at gmail.com (Yiorgis Gozadinos) Date: Thu, 20 Sep 2007 11:53:07 +0300 Subject: [Kss-devel] kss implementation of egoban.org In-Reply-To: <46F0E34E.50901@bubblenet.be> References: <42182c280709190032o466475f7qc48f0a65d2d6b934@mail.gmail.com> <46F0E34E.50901@bubblenet.be> Message-ID: <42182c280709200153r7c3e7e88pc3f1e827f490e35f@mail.gmail.com> On 9/19/07, Godefroid Chapelle wrote: > > Yiorgis Gozadinos wrote: > > Hi, > > I briefly talked with you guys a bit on #kss about converting my site > > egoban.org which handles Go games and replays them > > through an AJAX interface. > > The conversion has been long done, and everything seems to work fine > > (except that I find it slightly slower which is I suppose expected) and > > overall I can say I'm pleased with the result. > > I had promised to bring it over to Naples as a showcase for kss but I > > had an emergency operation and I'm not sure if I'll attend. > > > > Because egoban.org still runs on 2.5.3 without kss > > if you want to have the code (it's not yet open source) and show it off > > live I would be happy to hand it over. Let me know... > > Yours, > > gg > > > > Hello Yiorgis, > > I would really like to see both code base. I think I would like to make > a lightning talk about your site and migration... > > So yes, I'd like to see your code. But more thant that, I'd like some > feedback about your experience. What were the problems ? What did you > like ? What do you suggest ? > > One line answer to those three questions would be great... > > I am looking forward to see what you did ! > > Godefroid Chapelle (aka __gotcha)- BubbleNet http://bubblenet.be > > Hey, I'll start with describing my experience with kss ;) A bit on my background... Not a python guru but quite a seasoned programmer I started with plone/python about 2 years ago. egoban.org was a toy project aiming at getting me familiar with the bits and pieces necessary to do more serious plone programming. As such the currently running version is working fine but lacks in terms of design decisions. I had zero experience with js, so I decided to skip the pain part and decided to use mochikit which is a really sound lib for painless js. Things just worked but took a while to implement. Migrating to kss was much less painful than I originally thought. With zero previous experience it took 2 days to do everything. Take note that the first day was spent trying to find out why the first thing I tried on kss wasn't working. It turned out to be a kss bug that ree fixed. Although it is always disappointing when the first thing you try fails and you don't get it, ree was a fast responder and an even faster bug fixer, so after that everything went smoothly. I would say that with my currently limited knowledge of kss it would now take me about 3-4 hours to do the whole thing. Overall I really like kss. It is light and well designed. Things I missed are the following: 1) A better documentation. The tutorials are good and get you started but not everything is covered or well explained. I spent 1 hour for instance trying to fetch a stateVar from python, without having passed it as an argument. Although you can do setStateVar from python you can't get it. Although this is not bad necessarily it's nowhere to be found in the docs (at least I didn't find it). 2) The ability to let me a few dirty things easily. In the old code, I would fetch a node from the DOM by id. And I would obtain the whole bloody thing. I would be able to read it, change it, do whatever. With kss I have to pass individual attributes of the node as arguments. This, while it forces you to be more careful about your design, is hindering ocasionally. I'll give an example from my specific use case, but I think you can thing of other cases where such things would be useful. You can see how a Go board looks on egoban. The board is essentially a table holding images. When a stone is placed on the board the src of the image changes to the stone. When it is removed the stone is replaced by the original image. But that image (of the board position) is not the same for corners, sides and center. In the old code I used to set an attribute on the image node called emptysrc (or something similar) which I would copy to src when a stone was removed. I didn't have to do a series of if-elseif to decide which image to set. I'll agree this adds state to the client etc etc. But sometimes it's just simpler (and not necessarily bad) that way. So, yeah, I would love to be able to grab arbitrary nodes do whatever I want to them and send them back. I would also love to do getStateVar server side. I now pass arguments around just in case I need them. Why not fetch them when I do? That is, let me be dirty when I really really want to, and use stateVars like I did with global js vars. There you go, I'll answer any further questions comments whenever pain slips away and lets me access my computer. Keep up the good work, kss is in my opinion the BEST thing that happened with plone3... Yours, gg PS. I'll send to Godefroid full src... -------------- next part -------------- An HTML attachment was scrubbed... URL: http://codespeak.net/pipermail/kss-devel/attachments/20070920/153b12c0/attachment.htm From optilude at gmx.net Fri Sep 21 19:37:45 2007 From: optilude at gmx.net (Martin Aspeli) Date: Fri, 21 Sep 2007 18:37:45 +0100 Subject: [Kss-devel] Using an ExtJS component Message-ID: Hi guys, I'm interested in experimenting with this: http://extjs.com/playpen/ext-2.0-dev5/examples/organizer/organizer.html Imagine the thing on the right are contents of a folder, and the tree on the left is the Plone content hierarchy. With simple drag-and-drop, you can re-organise your content hierarchy pretty effectively. I could probably just sidestep KSS to use this, bringing in the ExtJS dependencies in a particular page template and set up the control, but I'd like to look at whether I can gain more by using KSS more directly. The ExtJS approach is quite simple. You typically set up some data structures/options that explain e.g. how to fetch data (using JSON, typically), what to do on a drop event, what headers and columns you want and so on. This all goes into an object which ypu then "apply" to a node (e.g. an empty div) and ExtJS renders the whole widget there. Here is the code for the example: http://extjs.com/playpen/ext-2.0-dev5/examples/organizer/organizer.js Let's forget about i18n and graceful degradation for now on. I'd be interested to hear how you feel this may be best woven into a Plone (3) site with KSS taking care of other JS. Martin -- Acquisition is a jealous mistress From optilude at gmx.net Thu Sep 27 01:30:24 2007 From: optilude at gmx.net (Martin Aspeli) Date: Thu, 27 Sep 2007 00:30:24 +0100 Subject: [Kss-devel] KSS timeout Message-ID: Hi guys, Is there a simple way to increase the KSS timeout? The 'sharing' tab on my instance times out (silently unless portal_javascripts is in debug mode!) when using an LDAP repository because the LDAP search takes too long. :) Martin -- Acquisition is a jealous mistress From ree at ree.hu Thu Sep 27 07:53:49 2007 From: ree at ree.hu (Balazs Ree) Date: Thu, 27 Sep 2007 07:53:49 +0200 Subject: [Kss-devel] KSS timeout References: Message-ID: On Thu, 27 Sep 2007 00:30:24 +0100 Martin Aspeli wrote: > Is there a simple way to increase the KSS timeout? The 'sharing' tab on > my instance times out (silently unless portal_javascripts is in debug > mode!) when using an LDAP repository because the LDAP search takes too > long. :) There is surrently an unsupported way only. By increasing the value // sending timeout in millisecs kukit.rm.RequestManager.prototype.sendingTimeout = 8000; in requestmanager.js, you can increase the timeout globally. In the future this will be settable as a kss action parameter on the server action. I plan to implement this soon. -- Balazs Ree From apm13 at columbia.edu Thu Sep 27 17:54:38 2007 From: apm13 at columbia.edu (Alec Mitchell) Date: Thu, 27 Sep 2007 08:54:38 -0700 Subject: [Kss-devel] KSS timeout In-Reply-To: References: Message-ID: <365118370709270854g22f44f64mced529f38842da45@mail.gmail.com> This may be a case where a simple workaround would be useful. You can add an error handler that submits the form directly if the server action fails (e.g. with a timeout). It's not ideal because it means the expensive search is performed twice, and the user has to wait for the timeout before the search starts again, but it's easy to implement. actionname-error: plone-submitCurrentForm; However, I question the purpose of using AJAX for requests that potentially take a long time to complete. Generally the purpose of these things is to make for a more responsive ui, but when the requests take more that a couple seconds I think AJAX can be pretty counter-intuitive (even with a progress spinner, though a fancy progress bar would help, even if it might be difficult to get right). Perhaps the KSS action can be turned off when the "large number of users" flag is enabled? Alec On 9/26/07, Balazs Ree wrote: > On Thu, 27 Sep 2007 00:30:24 +0100 Martin Aspeli wrote: > > > Is there a simple way to increase the KSS timeout? The 'sharing' tab on > > my instance times out (silently unless portal_javascripts is in debug > > mode!) when using an LDAP repository because the LDAP search takes too > > long. :) > > There is surrently an unsupported way only. By increasing the value > > // sending timeout in millisecs > kukit.rm.RequestManager.prototype.sendingTimeout = 8000; > > in requestmanager.js, you can increase the timeout globally. > > In the future this will be settable as a kss action parameter on the > server action. I plan to implement this soon. > > -- > Balazs Ree > > _______________________________________________ > Kss-devel mailing list > Kss-devel at codespeak.net > http://codespeak.net/mailman/listinfo/kss-devel > From optilude at gmx.net Sun Sep 30 00:57:37 2007 From: optilude at gmx.net (Martin Aspeli) Date: Sat, 29 Sep 2007 23:57:37 +0100 Subject: [Kss-devel] Regression/BBB in client-side action names and parameters Message-ID: Hi guys, This is just a heads-up... I went to look at the KSS interfaces again to look up some syntax, and then realised that since I wrote the KSS chapter in my book, you've deprecated/renamed a bunch of functions and parameters. These are the perils of writing about a pre-released version of Plone, of course. :) Whilst I welcome the consistency this brings, it does mean that the book is advising people to use the old syntax. Unfortunately, production is now finished, so it's too late to make changes. I am finding out how to publish errata, but at best this will be a note on some website. :-( Furthermore, it seems that the BBB code is not working (and the error message in Firebug is not particularly helpful). Here's the old KSS: #showClosedButton:click(show_button) { evt-click-preventdefault: true; action-client: toggleClass; toggleClass-classname: hiddenItem; action-client: removeClass; removeClass-kssSelector: css("#deliverablesTable tr.closed"); removeClass-name: hiddenItem; action-client: setStateVar; setStateVar-varname: showHidden; setStateVar-value: true; } #showClosedButton:click(hide_button) { evt-click-preventdefault: true; action-client: toggleClass; toggleClass-kssSelector: htmlid(hideClosedButton); toggleClass-classname: hiddenItem; } When I click the button, Firebug does this: [Exception... "'Error: Missing mandatory parameter [value] in [undefined].' when calling method: [nsIDOMEventListener::handleEvent]" nsresult: "0x8057001c (NS_ERROR_XPC_JS_THREW_JS_OBJECT)" location: "" data: no] initalizeTableSort(undefined)table_sorter.js (line 155) DOMContentLoadedInit() I have no idea why it's talking about the table sorter, but there you go. I have to change all the parameters from name/classname to value: #showClosedButton:click(show_button) { evt-click-preventdefault: true; action-client: toggleClass; toggleClass-value: hiddenItem; action-client: removeClass; removeClass-kssSelector: css("#deliverablesTable tr.closed"); removeClass-value: hiddenItem; action-client: setStateVar; setStateVar-varname: showHidden; setStateVar-value: true; } #showClosedButton:click(hide_button) { evt-click-preventdefault: true; action-client: toggleClass; toggleClass-kssSelector: htmlid(hideClosedButton); toggleClass-value: hiddenItem; } Now it works. I'd say this is an unintended regression that we may want to fix. The table in chapter 14 in my book lists the following: Function Parameter -------------------------------------------- addClassName name removeClassName name toggleClass classname As far as I can tell, it should've been: Function Parameter -------------------------------------------- addClass value removeClass value toggleClass value And the old ones are not working anymore. Martin -- Acquisition is a jealous mistress From ree at ree.hu Sun Sep 30 08:15:34 2007 From: ree at ree.hu (Balazs Ree) Date: Sun, 30 Sep 2007 08:15:34 +0200 Subject: [Kss-devel] Regression/BBB in client-side action names and parameters References: Message-ID: Hi Martin, On Sat, 29 Sep 2007 23:57:37 +0100, Martin Aspeli wrote: > This is just a heads-up... I went to look at the KSS interfaces again to > look up some syntax, and then realised that since I wrote the KSS > chapter in my book, you've deprecated/renamed a bunch of functions and > parameters. These are the perils of writing about a pre-released version > of Plone, of course. :) > > Whilst I welcome the consistency this brings, it does mean that the book > is advising people to use the old syntax. Unfortunately, production is > now finished, so it's too late to make changes. I am finding out how to > publish errata, but at best this will be a note on some website. :-( I am very sad to hear this, since I was extremely conscious about this issue. This was the last change made in kss.core, it was done way before the Plone release and getting it correctly in your book was a high priority for me. > Furthermore, it seems that the BBB code is not working (and the error > message in Firebug is not particularly helpful). ... and, by the time I made the change I really made sure the deprecation does work correctly. In addition I refused to make any new changes in the code of the kss.core after that point. That's all the precaution one can possibly imagine to not have things broken. However it happened and the only thing that remains now is to fix the BBB, and I will do that soon. Some words about regression testing of KSS because it is a connecting topic. Unfortunately at the moment we currently have a single way to test issues like this, and this is with the kissbot. This tests things with Selenium in pure kss (kss.demo), but at the moment not in Plone. This affects addClass and friends, because at the moment they only work in Plone and not in pure kss (this will also change but it is so at the moment). What do we need to have this situation of testing improved? One way is to *insist* that people write Selenium tests to cover *all* functionality. On the level of kss plugins we will support this with a paster template that gives you a skeleton with a working demo and a directory to place the selenium tests into, which then will run automatically by the kissbot. We also have to enforce selenium testing on the level of the Plone application, and since Sorrento I started to hassle people to do so as a base requirement for new features. However since then noone really complies to this "rule" which is currently mine only and there is no community consensus behind it. The next thing is that we also need to be able to run these tests automatically, at least nightly. For this we need more servers to be donated as slaves in the kissbot pool. Godefroid will provide more information about this, afaik we really need a lot of computing capacity for this This calls for a community action and I believe we should sit together to discuss this issue in Naples. It would be a real benefit for Plone to have full automated Selenium test coverage, not only for the benefit of KSS. A last remark about the error messages: we redesigned the error handling to give more useful error traceback during the last kss sprint, but that is only part of the new kss.core version (will come in effect in Plone 3.5). It would be possible to backport it to 3.0 but it touches a lot in the code and the decision was not to do it. -- Balazs Ree From optilude at gmx.net Sun Sep 30 13:21:02 2007 From: optilude at gmx.net (Martin Aspeli) Date: Sun, 30 Sep 2007 12:21:02 +0100 Subject: [Kss-devel] Regression/BBB in client-side action names and parameters In-Reply-To: References: Message-ID: Hi Balazs, > I am very sad to hear this, since I was extremely conscious about this > issue. This was the last change made in kss.core, it was done way before > the Plone release and getting it correctly in your book was a high > priority for me. I understand - the error is entirely on our side. Balazs did in fact email me about this (and I thought I'd actioned the suggestions in that email), but either I was confused or the editors got lost, and I just didn't pick it up in time. >> Furthermore, it seems that the BBB code is not working (and the error >> message in Firebug is not particularly helpful). > > ... and, by the time I made the change I really made sure the deprecation > does work correctly. In addition I refused to make any new changes in the > code of the kss.core after that point. That's all the precaution one can > possibly imagine to not have things broken. > > However it happened and the only thing that remains now is to fix the > BBB, and I will do that soon. It looked to me like there was BBB code there, just that it wasn't working quite as intended? Or perhaps I'm wrong. I know you guys take BBB and deprecation very seriously - that's why I posted here as soon as I found a problem. This is the only sensible policy to have and the only way to give people confidence in the framework. As far as KSS is concerned, I consider this a minor BBB bug that hopefully is easy to fix. In any case, I'm sorry to have caused trouble, and I will be publishing this as errata as soon as I know how. Martin -- Acquisition is a jealous mistress