[Kss-devel] the getUtility acquisition issue, fix

[Jeroen Vloothuis]

Balazs Ree wrote:
> The fix itself is here: 
> https://svn.plone.org/svn/collective/plonekss/five.localsitemanager/registry.py
>
> Please test it out! (You have to overwrite the relevant file with it.)
>   
Great work, I tested it out and it works a lot better then before the
patch. I encountered a few problems though which might not be related to
the patch.

Reloading of the recent changes portlet does not work anymore. This
means that if you edit the description or title of a page (tested with
the front page) it no longer reloads itself.

Inline editing works but only saves if I change the focus of the field
(pressing enter does not change the field).
> The issue opens another question. Obviously, at one point someone 
> committed something to Five / Plone without realizing that it is broken 
> code. This should not have happened at the first place.
> Did it or did it not break our tests? If no, we need tests against this. 
> If yes, how could this happen, ie. why do people check in code that break 
> tests, and how can we make sure this cannot happen again?
We cannot expect Zope/CMF core people to run the Plone tests when they
change things (although in this case a few involved where Plone devs as
well). Maybe it would be best to detect changes like this as early as
possible? Using the buildbot setup it should be possible to get
notifications about breakage a bit sooner then we did now?

Also creating selenium tests or other more complete functional tests
should help a lot.