[Kss-devel] change parameter names on toggleClass etc. actions, and a dependency problem

[Balazs Ree]

Fri, 08 Jun 2007 20:51:12 +0100 keltezéssel Martin Aspeli azt írta:

> Godefroid Chapelle wrote:
>> Balazs Ree wrote:
>>> Fri, 08 Jun 2007 11:28:58 +0200 keltezéssel Godefroid Chapelle azt
>>> írta:
>>>
>>> Then, value is redundant either. So why not simply:
>>>
>>> toggleClass, addClass, removeClass ?
>> 
>> +1
> 
> +1
> 
> Short and memorable is good.

Done now on trunk with proper BBB.

However I noticed a big problem. These actions are dependent on the 
global addClassName and removeClassName functions, which are however not 
in kss but in Plone. I realized this wnen I added the missing demos and 
tests for them.

I think we have two choices and we must at least decide asap:

- add the missing javascript code to kss.core, or:

- remove the addClass, removeClass actions from the core, and move them
  to the Plone plugin and commandset.


And a message to all developers: All future checkins that concern new 
actions without a kss.demo page and selenium testcase, and a 
corresponding unittest to call the command and check for its resonse, is 
a big NO-NO.

Guilty in this case are Florian who checked in the javascript, and 
myself, who added the commands to the commandset without trying it and 
thinking about the consequences.

-- 
Balazs Ree