[Kss-devel] change parameter names on toggleClass etc. actions

[Balazs Ree]

Fri, 08 Jun 2007 11:28:58 +0200 keltezéssel Godefroid Chapelle azt írta:

> Balazs Ree wrote:

>> toggleClass                      requires "className" addClassName,
>> removeClassName    require  "name"

>> In case this meets an agreement, I would volunteer to do these changes,
>> including javascript, commandsets, demos, and selenium tests, all with
>> proper BBB naturally.
>> 
>> Any opinions?

> I think 'name' is not correct. Those actions actually change the class
> 'value'.
> 
> If you work on changing and getting coherence, I think we should go to
> 
> toggleClassValue, addClassValue, removeClassValue

Then, value is redundant either. So why not simply:

toggleClass, addClass, removeClass ?

> with a single 'value' parameter.

This sounds good.

-- 
Balazs Ree