[Kss-devel] planned merge of ree-stripout-comments

Balazs Ree ree at ree.hu
Fri Jun 8 10:19:40 CEST 2007


Hi All,

I plan to merge in the ree-stripout-comments branchs to trunk, and I am 
interested if there are any objections.

Pro Merge:

- It's there for a while and it works.

- it is difficult to maintain 2 versions of the js code (changes cause 
diffs everywhere even with equivalent lines), plus we have other branches 
that need to depend on this or that one, causing extra work and making 
merges difficult.

- I plan to keep the current resource defaults at first. Ie, RR uses +
+resource++kukit-src.js and will continue to do so, this will involve 
precompressing with the new 'devel' filter which gives you the full 
unstripped code (equivalent to as before) but the ;;;-s themselves 
removed, so even that cannot cause a headache. Users that want to try the 
new dual source formats and the switching mechanism, will need to follow 
instructions on how to change things in RR to activate them.



Con Merge:

- We agreed the current ;;; commentification needs to be changed because 
we don't like how we apply it in some cases, but till now we have not 
started yet to enhance it. However since it won't be active by default, 
it is not likely to cause any problems so yet I'd prefer to bring it to 
trunk and change things later, instead of waiting to settle it and having 
to deal with forking codebase.



Again, this is very unlikely to cause any problems because of what I 
wrote above. Actually noone would notice it really. If there is no word 
against this merge, i'd do this on the weekend. In case something is not 
entirely clear about the issue, please ask and I clarify for more.


-- 
Balazs Ree



More information about the Kss-devel mailing list