[Cython] asking for review of my patch for #287
Dag Sverre Seljebotn
dagss at student.matnat.uio.no
Tue May 12 17:58:05 CEST 2009
Lisandro Dalcin wrote:
> I want to raise your attention to ticket #287, as my patch could be
> controversial. I even changed my mind, and fixed my previous work on
> all this to prefer 'nb_int' over 'nb_long' in __Pyx_PyNumber_Int().
> This change was not a quick hack to get things solved, but rather a
> hard to take decision after diving core CPython sources from 2.3 to
> 2.7. IMHO, the 'nb_long' slot should have been deprecated long, long
> ago in core CPython. I would like this to be discussed a bit more
> before next release.
I don't think I'm qualified to comment on this. Do you consider it safe
enough yourself for inclusion in Cython 0.11.2, or is it blocked pending
review by Stefan or Robert?
--
Dag Sverre
More information about the Cython-dev
mailing list