[Cython] typo in ExprNode.py

[Hoyt Koepke]

Okay, I isolated the problem and created a small test case for this
section of code.

--Hoyt

# HG changeset patch
# User hoytak at gmail.com
# Date 1231615306 28800
# Node ID 7992887cb01ec1c9aa029bc0e15f4806e99b1c3e
# Parent  f77199c86f6f461971d4ce0817ed68aa80e25cc5
New test case for non-constant DEF statements.

diff -r f77199c86f6f -r 7992887cb01e tests/compile/nonconst_def.pyx
--- /dev/null   Thu Jan 01 00:00:00 1970 +0000
+++ b/tests/compile/nonconst_def.pyx    Sat Jan 10 11:21:46 2009 -0800
@@ -0,0 +1,3 @@
+import os
+DEF ospath = os.path
+

(also attached)


On Sat, Jan 10, 2009 at 12:51 AM, Robert Bradshaw
<robertwb at math.washington.edu> wrote:
> On Jan 10, 2009, at 12:08 AM, Stefan Behnel wrote:
>
>> Hi,
>>
>> Hoyt Koepke wrote:
>>> beginswith() in ExprNode.py should be startswith()
>>
>> Thanks for catching that, I applied the patch. I would expect the
>> same bug
>> in Pyrex, BTW.
>>
>> It looks like we lack a test case for this specific part of the
>> code. Could
>> you come up with something here?
>>
>> http://wiki.cython.org/
>> HackerGuide#head-6afd0aa52fa6a1de32f6d554b5d30556699e4f18
>>
>> Might fit in here:
>>
>>       tests/run/consts.pyx
>>       tests/run/ct_DEF.pyx
>>
>>
>>> P.S. Is this the best way to send little updates like these?
>>> Should I
>>> send them to the whole list?
>>
>> I think it's perfect for small to medium sized patches. More
>> complex stuff
>> should go to the bug tracker, but for patches like this, a quick
>> review
>> while reading your mail and a quick import is the most efficient
>> way to
>> apply them.
>
> I agree. I try and make track tickets for history and completeness
> (e.g. it makes release notes much easier) but for something like this
> it is (currently) the best way to go about it.
>
> If no one responds, make sure a ticket gets filed so it doesn't get
> lost in the archives.
>
> - Robert
>
> _______________________________________________
> Cython-dev mailing list
> Cython-dev at codespeak.net
> http://codespeak.net/mailman/listinfo/cython-dev
>



-- 

++++++++++++++++++++++++++++++++++++++++++++++++
+ Hoyt Koepke
+ University of Washington Department of Statistics
+ http://www.stat.washington.edu/~hoytak/
+ hoytak at gmail.com
++++++++++++++++++++++++++++++++++++++++++
-------------- next part --------------
A non-text attachment was scrubbed...
Name: new_test_changeset
Type: application/octet-stream
Size: 450 bytes
Desc: not available
Url : http://codespeak.net/pipermail/cython-dev/attachments/20090110/797f437c/attachment-0001.obj