[Cython] Asking for review: More result_code refactor etc.

[Robert Bradshaw]

On Sep 29, 2008, at 11:23 AM, Dag Sverre Seljebotn wrote:

> Buffer access towards complex types (treating them as a struct of two
> floats) are now up in -dagss.
>
> In order to get there I had to do a couple of dangerous things  
> regarding
> result_code though. These patches are really small but someone with  
> more
> knowledge may have more or less confidence in them than I:

Sorry to take so long to answer this, but changes like this make me  
wary too. (I think they're *good* changes, they're just scary ones to  
try and pronounce safe).

> http://hg.cython.org/cython-dagss/rev/b2bcc32021fd
> http://hg.cython.org/cython-dagss/rev/a8a9e4c7d5bd

After looking at them (again), I say +1.

> Note that this should fix the CloneNode issue I talked about. (And all
> tests pass btw; yet this is the kind of thing that would cause
> horrendous failures in obscure cases which are likely not tested  
> for...)
>
> Also in -dagss I've introduces NewTempExprNode, which is a  
> transitionary
> class where the temp allocation is moved to code generation.  
> Ideally all
> ExprNodes should descend from this one instead (and then it should be
> folded back into ExprNode to complete the migration).

That sounds like a good idea.

> Some classes fail hard when they are changed to the new scheme. It  
> works
> for BinOpNode which now uses it. This should allow partial migration.
> (One must make sure a class can work with the new temp allocation  
> scheme
> before constructing them in a transform after analysis).

Good point.

- Robert