[Cython] code review

Robert Bradshaw robertwb at math.washington.edu
Mon May 5 20:06:16 CEST 2008


> Guys, please don't get me wrong.
>
> I'm not saying "let's use roundup, period." For amount of patches I  
> observe I
> think plain cython-patches would do, and then, if needed, we could  
> use any
> tool which would do the job.
>
> Only myself I observed that doing things in text editor is handy,  
> thus I
> value tools that provide this ability.
>
> I really hope Guido's codereview would be good though and helpful  
> and well
> designed.
>
> Let's settle on something practical,


I agree that we need something practical. I have also been frustrated  
with the speed (both page load time and having to navigate multiple  
pages to do simple tasks) with launchpad, which is why I don't use it  
as much as I probably should. I would also much prefer to self-host  
our own bug tracker.

I'd also vote for trac, but I guess that's no surprise because I'm  
also part of the Sage team (as are a lot of other potential Cython  
developers). The workflow of using trac to manage bugs and feature  
requests works well. Also, cython.org is hosted from the same server  
as sagemath, so we know that trac will always run well on it as it is  
being used for the Sage project. I wrote a simple bundle inspector  
for trac, it has good support for outgoing email notifications, and  
when the UW math department started using Trac for their help system  
I wrote a simple plugin that lets it accept incoming tickets as well  
if people want this. (One big problem with this is that one then has  
to deal with the issue of spam, so I would suggest only ticket  
modification, not creation, be allowed via email if we decide to do  
this.) If people like this suggestion I can go ahead and set up a  
trac server.

On the questions of patches vs. bundles, for small changes,  
especially if there aren't interdependencies, I prefer patches. Once  
you get beyond a couple of changesets bundles become easier to deal  
with, especially to make sure nothing slips between the cracks (this  
is less of an issue if we start using a good ticketing system as  
discussed above). Note that one can use "hg incoming -p" to see the  
contents of a bundle without applying it.

- Robert



More information about the Cython-dev mailing list