[Cython] code review

[Michael Abshoff]

Kirill Smelkov wrote:
> В сообщении от Воскресенье 04 мая 2008 Gary Furnish написал(a):
>   
>> The canonical example of a project that uses trac is Sage:
>> http://trac.sagemath.org/sage_trac
>> It has good email integration (notify on ticket modification, etc,
>> although it is supposed to be even better in the next version).
>>     
>
> I'd like to clarify what I mean saying "good email integration":
>
>   Good email integration is two-way
>
> That is:
>
> -> it is possible to affect state of the issues, add comments to patch review,
>    etc... by sending mail.
>   

Nope.

> <- you get notification mails, when someone changes something through web
>    interface, or another way.
>
>   
Yes.

> Personally, I think having the first entry is important - a lot of tasks could
> be done via plain emails, and at least some people are more productive with
> keyboard & text editor (compared to clicking with mouse) :)
>
>   
Well, some people like the Debian bugtracker which does let you submit 
item email, some people don't. Trac does not offer that in the default 
config and I don't think it is a good idea to do that. Trac offers some 
subset of wiki tags which make it preferable to use only the 
webinterface. The Debian bug tracker reads like an email list, so if you 
want that there is no advantage to switching to Trac.

> Does Trac have two-way email integration?
>   
Nope. It might be something available at trac-hacks, but last time I 
checked I didn't see anything.

>> Normally we attach patches to a ticket and then just comment them in
>> the ticket associated with the patch.  This associates the bug/feature
>> ticket with the patch (as opposed to needing two systems if you went
>> with something like codeview + launchpad).  Compared to trac,
>> launchpad is slow for webpage response time.  It is also slow on
>> ticket creation time (I can create a ticket for a given item in maybe
>> 30 seconds on one page in trac, whereas launchpad has so much
>> complexity it is significantly more time consuming, requires a
>> multipage creation step, etc).
>>     
>
> Gary, All, imagine you could create a patch issue with plain 'hg email',
> or create new issue with just sending mail to special address.
>
> Isn't this cool!?
>   

No. I don't really see the benefit there by just firing off an email. 
Our work flows are probably very different and I am no mouse pusher, but 
I prefer Trac and its workflow. I was skeptical initially, but since I 
spend a lot of time daily with Trac putting releases together for Sage I 
am quite sold on its work flow. I generally dislie the "submit bug 
report by email" work flow. We have sage-devel for the discussion bit 
and if we really have an issue we open a ticket.

We run 0.10.x, which is the current stable release. It has a couple 
issues, but those are mostly getting sorted out in 0.11. The main point 
of running your own trac install is that you own your data and do not 
depend on some other org to do things for you. Robert Bradshaw wrote an 
hg inspection module to let you check out patches and bundles online. 
There is also svn integration per default and some optional code to 
watch commits in an hg repo.

> Roundup has this now and it works. Also, although Roundup is not so shiny,
> it was choosen as the tracker for Python itself:
>
>   
Sure, but you need Django and a couple other things. Trac is self 
contained and has next to no dependencies, i.e. the default db is 
sqlite. It scales well for Sage, so I would assume it will work well for 
Cython which deals with a lot fewer patches on average compared to Sage.

> http://bugs.python.org/
>
> What do you think?
>   
:)

Cheers,

Michael

> _______________________________________________
> Cython-dev mailing list
> Cython-dev at codespeak.net
> http://codespeak.net/mailman/listinfo/cython-dev
>