[Cython] [PATCH 0 of 2] A couple of handy patches when using cython in-tree

Gary Furnish gfurnish at gfurnish.net
Sun May 4 13:22:46 CEST 2008


I strongly disagree.  Bundles are horrible for small changes.  Text
patches are easy to examine without using hg.  I should not have to
modify my repo to inspect a 3 line patch.

On Sun, May 4, 2008 at 4:08 AM, Kirill Smelkov <kirr at mns.spb.ru> wrote:
> Hi,
>
>  В сообщении от Воскресенье 04 мая 2008 Stefan Behnel написал(a):
>
> > Hi,
>  >
>  > Kirill Smelkov wrote:
>  > > Here is a couple of handy patches for the case when cython is used "in-tree",
>  > > i.e. when no installation is done.
>  > >
>  > > - First we need to 'chmod a+x' relevant files in bin/ ,
>  > > - and second, it would be convenient to finally create reasonable .hgignore
>  >
>  > Thanks, your patches are appreciated. Still, for the next time, could you send
>  > a bundle of changesets (hg bundle) instead of one mail per patch? Although
>  > this list is called "cython-dev", it's a somewhat general purpose list for
>  > Cython, so many people who read it do not care about small fixes and changes.
>
>  Stefan, I see your points.
>
>  I used 'hg email --outgoing' to send my patches, so if i want it to be sent as
>  bundle, I'd use 'hg email --bundle'.
>
>  I see one problem with this approach though: bundle is a binary file, and if
>  someone would like to comment on the patch itself - he'll need to manually
>  paste relevant chunks into reply mail.
>
>  I understand this list is general purpose, so maybe it would be good idea to
>  create separate list for patches? e.g. cython-patches at codespeak.net
>
>  Then sending patches there in plain text would be ok for all:
>
>  - readable patches right in email client
>  - ready-to apply patches right from email client  (one button in mutt)
>  - easy to comment on patches
>
>  This is common technique, and for example we do this in sympy-patches:
>
>  http://groups.google.com/group/sympy-patches/
>
>  What do you think?
>
>  Kirill.
>
>
> _______________________________________________
>  Cython-dev mailing list
>  Cython-dev at codespeak.net
>  http://codespeak.net/mailman/listinfo/cython-dev
>


More information about the Cython-dev mailing list