[Cython] Cython circular cdef import patch

[Stefan Behnel]

Gary Furnish wrote:
> Can you produce a testcase for this issue?  It is *critical* for fast
> symbolics in Sage, so I would prefer to fix the bug as opposed to
> reverting.
> I see the problem now, but I will need the test cases you are using to
> produce a fix.  Once I have them it should be a relatively easy patch.

Personally, I do not consider the patch that was applied a clean patch, as
it mixes a number of independent smaller and bigger changes - and a subset
of them has proven to be problematic.

So I attached a changeset that reverts the parts that I think were related
to the behaviour I see and that does some minor source cleanup of the
affected areas. I had to do that by hand, as the three related changesets
(one by you, two by Robert) are split around the package merge, which
makes it really hard to get them reverted cleanly.

I will try to come up with a test case - which may take a bit longer as I
am not sure the current test suite is ready to handle multi-file tests
(although a mix of .pyx and .pxd should work, I'll have to check that). I
would ask you to provide a clean patch against my reverted source version,
so that we have a single clean changeset of what you wanted to achieve,
possibly followed by one or more bug fix commits that eventually lead to a
working patch.

I'm not questioning the intention of your changes in general, I'm just
concerned about a) getting the bugs out and b) making it traceable in the
revision history what change had what effects. Smaller, separate
self-contained commits are always better than a mix of different changes
in a big patch.

BTW, what is the "init2" function for? From what I read, you seem to have
cut it out of the original module init function. What's its purpose?
(implying: what would be a clearer name than "init2"?) And: why is it
declared "PyMODINIT_FUNC" instead of plain "void", which seems to be the
way you call it?

Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: revert-circular-cdef-changes.patch
Type: application/octet-stream
Size: 15125 bytes
Desc: not available
Url : http://codespeak.net/pipermail/cython-dev/attachments/20080409/f141747b/attachment-0001.obj